all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: kifer@cs.sunysb.edu, emacs-devel@gnu.org
Subject: Re: Diff faces
Date: Fri, 12 Oct 2007 11:59:47 -0400	[thread overview]
Message-ID: <E1IgMvT-0001IW-5u@fencepost.gnu.org> (raw)
In-Reply-To: <87tzoxqk2y.fsf@jurta.org> (message from Juri Linkov on Fri, 12 Oct 2007 02:59:17 +0300)

    Ediff puts face names as strings on overlays, but describe-face accepts
    only symbols.  The patch below fixes describe-face to not fail on face
    name strings.  As for fixing ediff, I don't know whether this is necessary,
    since face names as strings are mostly interchangeable with face symbols.
    There are only two places in ediff*.el files that call `face-name' to
    convert face symbols to strings, so these calls could be removed.

I agree describe-face should handle a string as the face property,
since that's a documented feature.  So please install that patch.

However, is there a good reason for ediff to use strings
instead of symbols to specify the faces?

  parent reply	other threads:[~2007-10-12 15:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 23:59 Diff faces Juri Linkov
2007-10-12  1:21 ` Stefan Monnier
2007-10-14 21:30   ` Juri Linkov
2007-10-15 14:36     ` Stefan Monnier
2007-10-15 23:52       ` Juri Linkov
2007-10-16  3:20         ` Stefan Monnier
2007-10-16  4:12       ` Miles Bader
2007-10-19 16:18     ` Stefan Monnier
2007-10-19 20:55       ` Juri Linkov
2007-10-19 23:42         ` Andreas Schwab
2007-10-20  0:16           ` Juri Linkov
2007-10-20 12:51             ` Stefan Monnier
2007-10-20  0:52         ` Stefan Monnier
2007-10-12 15:59 ` Richard Stallman [this message]
2007-10-12 19:42   ` Michael Kifer
2007-10-13  6:41     ` Richard Stallman
2007-10-13  6:55       ` Michael Kifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IgMvT-0001IW-5u@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=kifer@cs.sunysb.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.