all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* 23.0.50; find-func: can no longer find adviced subrs
@ 2007-09-08  3:39 raman
  2007-09-08  9:04 ` Johan Bockgård
  2007-09-08 17:56 ` T. V. Raman
  0 siblings, 2 replies; 8+ messages in thread
From: raman @ 2007-09-08  3:39 UTC (permalink / raw)
  To: emacs-pretest-bug


This used to work until 23.0.

But now, when you do find-func on a subr that is advised, it no
longer finds the C source where the subr is defined.

I suspect this may be related to some of the changes that went
into advice.el in the last few weeks.


In GNU Emacs 23.0.50.9 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2007-09-07 on labrador
configured using `configure  '--prefix=/usr/local' '--with-gtk' '--with-gpm' '--with-rsvg' '--with-png' '--with-jpeg' '--with-gif''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: nil

Major mode: VM Presentation

Minor modes in effect:
  erc-track-minor-mode: t
  jabber-activity-mode: t
  dynamic-completion-mode: t
  dired-omit-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  display-time-mode: t
  desktop-save-mode: t
  auto-insert-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t

Recent input:
SPC d o SPC m e SPC n o SPC d o ESC DEL g o o d . RET 
RET T h a n k s , RET RET - - R a m a n RET T e l : 
SPC 4 0 8 SPC 3 6 3 SPC 3 5 6 5 RET E m a i l : SPC 
r DEL t v r a m a n @ c o m c a s t . n e t C-x @ h 
s c d RET g r e p SPC c o m c a s t SPC . f e t c h 
m a i l r c RET C-p C-p ESC > c a t SPC . f e t c h 
m TAB r TAB RET C-p C-p C-p C-e e ESC b ESC b ESC b 
C-e w ESC > ESC [ [ C ESC m C-c C-c TAB TAB TAB ESC 
[ C RET C-x h C-e n C-e s e C-g C-g C-e m q q q q C-t 
g 4 RET C-t n C-t n C-x @ h s c d RET C-e t C-e x m 
ESC m SPC j ' C-h f n e x t SPC ESC DEL f o r e w TAB 
C-g C-g C-h ESC f f o r e ESC DEL f o r w TAB l i n 
TAB RET C-e m ESC [ [ D C-h f C-g C-g C-h ESC f d e 
l e t e SPC w i n d TAB RET ESC m ESC x r e p o r t 
- e m ESC TAB C-g C-g ESC x r e p o r t SPC e m TAB 
b TAB RET

Recent messages:
Not on a block [2 times]
Quit [2 times]
Loading find-func...done
Emacspeak pronunciation dictionaries are now active in this buffer
Loading vc-cvs...done
Quit [2 times]
Don't know where `delete-window' is defined
signal: Don't know where `delete-window' is defined
widget-tabable-at: Wrong type argument: consp, t
Quit
Quit

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-08  3:39 23.0.50; find-func: can no longer find adviced subrs raman
@ 2007-09-08  9:04 ` Johan Bockgård
  2007-09-08 17:00   ` T. V. Raman
  2007-09-08 17:56 ` T. V. Raman
  1 sibling, 1 reply; 8+ messages in thread
From: Johan Bockgård @ 2007-09-08  9:04 UTC (permalink / raw)
  To: emacs-devel; +Cc: emacs-pretest-bug

raman <raman@users.sf.net> writes:

> This used to work until 23.0.

Are you sure? I discovered this problem a long time ago. (I don't know
if it ever worked.)

> But now, when you do find-func on a subr that is advised, it no
> longer finds the C source where the subr is defined.
>
> I suspect this may be related to some of the changes that went
> into advice.el in the last few weeks.

-- 
Johan Bockgård

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-08  9:04 ` Johan Bockgård
@ 2007-09-08 17:00   ` T. V. Raman
  0 siblings, 0 replies; 8+ messages in thread
From: T. V. Raman @ 2007-09-08 17:00 UTC (permalink / raw)
  To: bojohan+news; +Cc: emacs-pretest-bug, emacs-devel


It used to not work a long time ago, but it has been working
under pre-release 22 for quite a while. 
A current work-around is to ask find-func to find ad-Orig-<func> 

>>>>> "Johan" == Johan Bockgård <bojohan> writes:
    Johan> raman <raman@users.sf.net> writes:
    >> This used to work until 23.0.
    Johan> 
    Johan> Are you sure? I discovered this problem a long time
    Johan> ago. (I don't know if it ever worked.)
    Johan> 
    >> But now, when you do find-func on a subr that is advised,
    >> it no longer finds the C source where the subr is defined.
    >> 
    >> I suspect this may be related to some of the changes that
    >> went into advice.el in the last few weeks.
    Johan> 
    Johan> -- Johan Bockgård
    Johan> 
    Johan> 
    Johan> 
    Johan> _______________________________________________
    Johan> Emacs-devel mailing list Emacs-devel@gnu.org
    Johan> http://lists.gnu.org/mailman/listinfo/emacs-devel

--
Best Regards,
--raman


Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman
IRC:    irc://irc.freenode.net/#emacs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* 23.0.50; find-func: can no longer find adviced subrs
  2007-09-08  3:39 23.0.50; find-func: can no longer find adviced subrs raman
  2007-09-08  9:04 ` Johan Bockgård
@ 2007-09-08 17:56 ` T. V. Raman
  2007-09-10 20:54   ` Davis Herring
  1 sibling, 1 reply; 8+ messages in thread
From: T. V. Raman @ 2007-09-08 17:56 UTC (permalink / raw)
  To: raman; +Cc: emacs-pretest-bug


Here is some additional information to help track down this
problem:

the problem appears to stem from the fact that symbol-function on
an adviced subr now returns the compiled advice form, rather than
the #<subr subrname>
-- this causes find-function-noselect to fail 

the problem also shows up when you do describe-function on an
adviced subr -- the help buffer text wrongly identifies it as an
interactive function at the top of the help text.

Other parts of emacs still know it's a subr -- the bototm of the
help text says "this subr is adviced ..."


>>>>> "tvrReply-to: raman@users.sf.net" == T V Raman <raman@users.sf.net> writes:
    tvrReply-to: raman@users.sf.net> This used to work until
    tvrReply-to: raman@users.sf.net> 23.0.
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> But now, when you do
    tvrReply-to: raman@users.sf.net> find-func on a subr that is
    tvrReply-to: raman@users.sf.net> advised, it no longer finds
    tvrReply-to: raman@users.sf.net> the C source where the subr
    tvrReply-to: raman@users.sf.net> is defined.
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> I suspect this may be
    tvrReply-to: raman@users.sf.net> related to some of the
    tvrReply-to: raman@users.sf.net> changes that went into
    tvrReply-to: raman@users.sf.net> advice.el in the last few
    tvrReply-to: raman@users.sf.net> weeks.
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> In GNU Emacs 23.0.50.9
    tvrReply-to: raman@users.sf.net> (i686-pc-linux-gnu, GTK+
    tvrReply-to: raman@users.sf.net> Version 2.8.20) of
    tvrReply-to: raman@users.sf.net> 2007-09-07 on labrador
    tvrReply-to: raman@users.sf.net> configured using `configure
    tvrReply-to: raman@users.sf.net> '--prefix=/usr/local'
    tvrReply-to: raman@users.sf.net> '--with-gtk' '--with-gpm'
    tvrReply-to: raman@users.sf.net> '--with-rsvg' '--with-png'
    tvrReply-to: raman@users.sf.net> '--with-jpeg' '--with-gif''
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> Important settings: value of
    tvrReply-to: raman@users.sf.net> $LC_ALL: nil value of
    tvrReply-to: raman@users.sf.net> $LC_COLLATE: nil value of
    tvrReply-to: raman@users.sf.net> $LC_CTYPE: nil value of
    tvrReply-to: raman@users.sf.net> $LC_MESSAGES: nil value of
    tvrReply-to: raman@users.sf.net> $LC_MONETARY: nil value of
    tvrReply-to: raman@users.sf.net> $LC_NUMERIC: nil value of
    tvrReply-to: raman@users.sf.net> $LC_TIME: nil value of
    tvrReply-to: raman@users.sf.net> $LANG: en_US.UTF-8
    tvrReply-to: raman@users.sf.net> locale-coding-system: utf-8
    tvrReply-to: raman@users.sf.net> default-enable-multibyte-characters:
    tvrReply-to: raman@users.sf.net> nil
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> Major mode: VM Presentation
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> Minor modes in effect:
    tvrReply-to: raman@users.sf.net> erc-track-minor-mode: t
    tvrReply-to: raman@users.sf.net> jabber-activity-mode: t
    tvrReply-to: raman@users.sf.net> dynamic-completion-mode: t
    tvrReply-to: raman@users.sf.net> dired-omit-mode: t
    tvrReply-to: raman@users.sf.net> shell-dirtrack-mode: t
    tvrReply-to: raman@users.sf.net> savehist-mode: t
    tvrReply-to: raman@users.sf.net> display-time-mode: t
    tvrReply-to: raman@users.sf.net> desktop-save-mode: t
    tvrReply-to: raman@users.sf.net> auto-insert-mode: t
    tvrReply-to: raman@users.sf.net> file-name-shadow-mode: t
    tvrReply-to: raman@users.sf.net> global-font-lock-mode: t
    tvrReply-to: raman@users.sf.net> unify-8859-on-encoding-mode:
    tvrReply-to: raman@users.sf.net> t utf-translate-cjk-mode: t
    tvrReply-to: raman@users.sf.net> auto-compression-mode: t
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> Recent input: SPC d o SPC m
    tvrReply-to: raman@users.sf.net> e SPC n o SPC d o ESC DEL g
    tvrReply-to: raman@users.sf.net> o o d . RET RET T h a n k s
    tvrReply-to: raman@users.sf.net> , RET RET - - R a m a n RET
    tvrReply-to: raman@users.sf.net> T e l : SPC 4 0 8 SPC 3 6 3
    tvrReply-to: raman@users.sf.net> SPC 3 5 6 5 RET E m a i l :
    tvrReply-to: raman@users.sf.net> SPC r DEL t v r a m a n @ c
    tvrReply-to: raman@users.sf.net> o m c a s t . n e t C-x @ h
    tvrReply-to: raman@users.sf.net> s c d RET g r e p SPC c o m
    tvrReply-to: raman@users.sf.net> c a s t SPC . f e t c h m a
    tvrReply-to: raman@users.sf.net> i l r c RET C-p C-p ESC > c
    tvrReply-to: raman@users.sf.net> a t SPC . f e t c h m TAB r
    tvrReply-to: raman@users.sf.net> TAB RET C-p C-p C-p C-e e
    tvrReply-to: raman@users.sf.net> ESC b ESC b ESC b C-e w ESC
    tvrReply-to: raman@users.sf.net> > ESC [ [ C ESC m C-c C-c
    tvrReply-to: raman@users.sf.net> TAB TAB TAB ESC [ C RET C-x
    tvrReply-to: raman@users.sf.net> h C-e n C-e s e C-g C-g C-e
    tvrReply-to: raman@users.sf.net> m q q q q C-t g 4 RET C-t n
    tvrReply-to: raman@users.sf.net> C-t n C-x @ h s c d RET C-e
    tvrReply-to: raman@users.sf.net> t C-e x m ESC m SPC j ' C-h
    tvrReply-to: raman@users.sf.net> f n e x t SPC ESC DEL f o r
    tvrReply-to: raman@users.sf.net> e w TAB C-g C-g C-h ESC f f
    tvrReply-to: raman@users.sf.net> o r e ESC DEL f o r w TAB l
    tvrReply-to: raman@users.sf.net> i n TAB RET C-e m ESC [ [ D
    tvrReply-to: raman@users.sf.net> C-h f C-g C-g C-h ESC f d e
    tvrReply-to: raman@users.sf.net> l e t e SPC w i n d TAB RET
    tvrReply-to: raman@users.sf.net> ESC m ESC x r e p o r t - e
    tvrReply-to: raman@users.sf.net> m ESC TAB C-g C-g ESC x r e
    tvrReply-to: raman@users.sf.net> p o r t SPC e m TAB b TAB
    tvrReply-to: raman@users.sf.net> RET
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> Recent messages: Not on a
    tvrReply-to: raman@users.sf.net> block [2 times] Quit [2
    tvrReply-to: raman@users.sf.net> times] Loading
    tvrReply-to: raman@users.sf.net> find-func...done Emacspeak
    tvrReply-to: raman@users.sf.net> pronunciation dictionaries
    tvrReply-to: raman@users.sf.net> are now active in this
    tvrReply-to: raman@users.sf.net> buffer Loading vc-cvs...done
    tvrReply-to: raman@users.sf.net> Quit [2 times] Don't know
    tvrReply-to: raman@users.sf.net> where `delete-window' is
    tvrReply-to: raman@users.sf.net> defined signal: Don't know
    tvrReply-to: raman@users.sf.net> where `delete-window' is
    tvrReply-to: raman@users.sf.net> defined widget-tabable-at:
    tvrReply-to: raman@users.sf.net> Wrong type argument: consp,
    tvrReply-to: raman@users.sf.net> t Quit Quit
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> -- Best Regards, --raman
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net>       
    tvrReply-to: raman@users.sf.net> Email: raman@users.sf.net
    tvrReply-to: raman@users.sf.net> WWW:
    tvrReply-to: raman@users.sf.net> http://emacspeak.sf.net/raman/
    tvrReply-to: raman@users.sf.net> AIM: emacspeak GTalk:
    tvrReply-to: raman@users.sf.net> tv.raman.tv@gmail.com PGP:
    tvrReply-to: raman@users.sf.net> http://emacspeak.sf.net/raman/raman-almaden.asc
    tvrReply-to: raman@users.sf.net> Google: tv+raman IRC:
    tvrReply-to: raman@users.sf.net> irc://irc.freenode.net/#emacs
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> 
    tvrReply-to: raman@users.sf.net> _______________________________________________
    tvrReply-to: raman@users.sf.net> Emacs-devel mailing list
    tvrReply-to: raman@users.sf.net> Emacs-devel@gnu.org
    tvrReply-to: raman@users.sf.net> http://lists.gnu.org/mailman/listinfo/emacs-devel

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-08 17:56 ` T. V. Raman
@ 2007-09-10 20:54   ` Davis Herring
  2007-09-11 20:30     ` Richard Stallman
                       ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Davis Herring @ 2007-09-10 20:54 UTC (permalink / raw)
  To: raman; +Cc: emacs-pretest-bug

> the problem appears to stem from the fact that symbol-function on
> an adviced subr now returns the compiled advice form, rather than
> the #<subr subrname>
> -- this causes find-function-noselect to fail

This should not be surprising: the symbol's function definition now -is-
that advice form and not a subr.

> the problem also shows up when you do describe-function on an
> adviced subr -- the help buffer text wrongly identifies it as an
> interactive function at the top of the help text.

The advice form is an interactive function, and is correctly described as
such.  One can argue that the help system should be more aware of advice,
but it is not necessarily trivial to distinguish between advice and an
arbitrary lambda stored in a symbol's function cell.  Perhaps
`describe-function' should consult the `ad-advice-info' property on its
argument when constructing its first line of output.  `find-function'
could do something similar.

> Other parts of emacs still know it's a subr -- the bototm of the
> help text says "this subr is adviced ..."

That text is generated by the advice system and knows what the original
function is.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-10 20:54   ` Davis Herring
@ 2007-09-11 20:30     ` Richard Stallman
  2007-09-19  3:18     ` Richard Stallman
  2007-10-02 22:00     ` Richard Stallman
  2 siblings, 0 replies; 8+ messages in thread
From: Richard Stallman @ 2007-09-11 20:30 UTC (permalink / raw)
  To: herring; +Cc: emacs-pretest-bug, raman

    > Other parts of emacs still know it's a subr -- the bototm of the
    > help text says "this subr is adviced ..."

    That text is generated by the advice system and knows what the original
    function is.

If we can do this for describe-function, we can do it for
find-function.  It is just a matter of implementing it.

Would someone please implement this, and ack?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-10 20:54   ` Davis Herring
  2007-09-11 20:30     ` Richard Stallman
@ 2007-09-19  3:18     ` Richard Stallman
  2007-10-02 22:00     ` Richard Stallman
  2 siblings, 0 replies; 8+ messages in thread
From: Richard Stallman @ 2007-09-19  3:18 UTC (permalink / raw)
  To: herring; +Cc: emacs-pretest-bug, raman

[I sent this message a few weeks ago but did not get a response.]

    > Other parts of emacs still know it's a subr -- the bototm of the
    > help text says "this subr is adviced ..."

    That text is generated by the advice system and knows what the original
    function is.

If we can do this for describe-function, we can do it for
find-function.  It is just a matter of implementing it.

Would someone please implement this, and ack?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: 23.0.50; find-func: can no longer find adviced subrs
  2007-09-10 20:54   ` Davis Herring
  2007-09-11 20:30     ` Richard Stallman
  2007-09-19  3:18     ` Richard Stallman
@ 2007-10-02 22:00     ` Richard Stallman
  2 siblings, 0 replies; 8+ messages in thread
From: Richard Stallman @ 2007-10-02 22:00 UTC (permalink / raw)
  To: herring; +Cc: emacs-pretest-bug, raman

[I sent this message twice but did not get a response.]

    > Other parts of emacs still know it's a subr -- the bototm of the
    > help text says "this subr is adviced ..."

    That text is generated by the advice system and knows what the original
    function is.

If we can do this for describe-function, we can do it for
find-function.  It is just a matter of implementing it.

Would someone please implement this, and ack?

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2007-10-02 22:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-08  3:39 23.0.50; find-func: can no longer find adviced subrs raman
2007-09-08  9:04 ` Johan Bockgård
2007-09-08 17:00   ` T. V. Raman
2007-09-08 17:56 ` T. V. Raman
2007-09-10 20:54   ` Davis Herring
2007-09-11 20:30     ` Richard Stallman
2007-09-19  3:18     ` Richard Stallman
2007-10-02 22:00     ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.