ls in eshell will cause the prompt jumped to mid of buf

ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

in eshell, if the files listed by ls are too many to display in current  
view of the buf, the prompt will scroll to the midle of it.

I encounted this issue in emacs-unicode-2 in windows xp and 22.0.91.1 in  
ubuntu.

Is there something incorrect in my .emacs or a bug in eshell?

Thanks!

Re: ls in eshell will cause the prompt jumped to mid of buf

[Richard Stallman]

    in eshell, if the files listed by ls are too many to display in current  
    view of the buf, the prompt will scroll to the midle of it.

Could you please send me a *precise* test case for this bug?  The test
case should start with `emacs -q', so that your .emacs file does not
affect it, and it should show exactly what text to put in the buffer,
what commands to execute, and how and where to click.  Also please say
exactly what incorrect results you get.

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

OK, please let me descript what I have done step by step.

1. emacs -q
2. M-x eshell
3. ls
4. ls
5. do 'ls' to list the files, until the prompt reachs the bottom
6. ls, then the prompt will scroll to the half of a page. I think it  
should be still stayed at the bottom.

If you do 'ls' in a path where has lots of files and can not be displayed  
in one page, the prompt will
appear in the half of the page directly, instead of the bottom of the page.

Is it a intended behavior? If yes, how to disable the feature?

I asked this (a intended behavior?), because if I do the following:
1.  emacs -q
2. C-x C-f
3. then hit 'enter', 'enter'..... in the keyboard
it will do the same behavior as in eshell (scroll to the half of a page).

But after I set following in .emacs, it can scroll line by line.

  '(scroll-conservatively 10000)
  '(scroll-down-aggressively 0.01)
  '(scroll-margin 3)
  '(scroll-preserve-screen-position t)
  '(scroll-up-aggressively 0.01)

But the above settings did not effect the 'eshell'. And I could not get  
help from *info* or the web
(http://www.gnu.org/software/emacs/manual/html_node/eshell/Smart-scrolling.html),  
they are
empty.

At last, let me make clear my request, that is: how to scroll line by line  
in eshell?

Thanks in advance!


On Wed, 19 Sep 2007 03:34:06 +0800, Richard Stallman <rms@gnu.org> wrote:

>     in eshell, if the files listed by ls are too many to display in  
> current
>     view of the buf, the prompt will scroll to the midle of it.
>
> Could you please send me a *precise* test case for this bug?  The test
> case should start with `emacs -q', so that your .emacs file does not
> affect it, and it should show exactly what text to put in the buffer,
> what commands to execute, and how and where to click.  Also please say
> exactly what incorrect results you get.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

"William Xue" wrote:

> At last, let me make clear my request, that is: how to scroll line
> by line in eshell?

(add-hook 'eshell-output-filter-functions 'eshell-postoutput-scroll-to-bottom)

I think this should be there by default (since there are variables to
control _how_ it scrolls, as for comint).

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

On Wed, 19 Sep 2007 11:32:35 +0800, Glenn Morris <rgm@gnu.org> wrote:

> "William Xue" wrote:
>
>> At last, let me make clear my request, that is: how to scroll line
>> by line in eshell?
>
> (add-hook 'eshell-output-filter-functions  
> 'eshell-postoutput-scroll-to-bottom)

Thanks, it makes things closer.

Now, after hiting 'enter', the prompt is at the bottom, but when input a  
letter, it will
move one or two line up.

>
> I think this should be there by default (since there are variables to
> control _how_ it scrolls, as for comint).

ls in eshell will cause the prompt jumped to mid of buf

[Richard Stallman]

Can someone please DTRT, then ack?

He also said

    I encounted this issue in emacs-unicode-2 in windows xp and 22.0.91.1 in  
    ubuntu.

Date: Wed, 19 Sep 2007 09:39:02 +0800
To: rms@gnu.org
Subject: Re: ls in eshell will cause the prompt jumped to mid of buf
From: "William Xue" <william.xue@gmail.com>
Organization: SMILING
Cc: emacs-devel@gnu.org
Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8
MIME-Version: 1.0
In-Reply-To: <E1IXipi-0006Ol-R9@fencepost.gnu.org>

OK, please let me descript what I have done step by step.

1. emacs -q
2. M-x eshell
3. ls
4. ls
5. do 'ls' to list the files, until the prompt reachs the bottom
6. ls, then the prompt will scroll to the half of a page. I think it  
should be still stayed at the bottom.

If you do 'ls' in a path where has lots of files and can not be displayed  
in one page, the prompt will
appear in the half of the page directly, instead of the bottom of the page.

Is it a intended behavior? If yes, how to disable the feature?

I asked this (a intended behavior?), because if I do the following:
1.  emacs -q
2. C-x C-f
3. then hit 'enter', 'enter'..... in the keyboard
it will do the same behavior as in eshell (scroll to the half of a page).

But after I set following in .emacs, it can scroll line by line.

  '(scroll-conservatively 10000)
  '(scroll-down-aggressively 0.01)
  '(scroll-margin 3)
  '(scroll-preserve-screen-position t)
  '(scroll-up-aggressively 0.01)

But the above settings did not effect the 'eshell'. And I could not get  
help from *info* or the web
(http://www.gnu.org/software/emacs/manual/html_node/eshell/Smart-scrolling.html),  
they are
empty.

At last, let me make clear my request, that is: how to scroll line by line  
in eshell?

Thanks in advance!


On Wed, 19 Sep 2007 03:34:06 +0800, Richard Stallman <rms@gnu.org> wrote:

>     in eshell, if the files listed by ls are too many to display in  
> current
>     view of the buf, the prompt will scroll to the midle of it.
>
> Could you please send me a *precise* test case for this bug?  The test
> case should start with `emacs -q', so that your .emacs file does not
> affect it, and it should show exactly what text to put in the buffer,
> what commands to execute, and how and where to click.  Also please say
> exactly what incorrect results you get.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Richard Stallman]

Can someone please DTRT, then ack?

He also said

    I encounted this issue in emacs-unicode-2 in windows xp and 22.0.91.1 in  
    ubuntu.

Date: Wed, 19 Sep 2007 09:39:02 +0800
To: rms@gnu.org
Subject: Re: ls in eshell will cause the prompt jumped to mid of buf
From: "William Xue" <william.xue@gmail.com>
Organization: SMILING
Cc: emacs-devel@gnu.org
Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8
MIME-Version: 1.0
In-Reply-To: <E1IXipi-0006Ol-R9@fencepost.gnu.org>

OK, please let me descript what I have done step by step.

1. emacs -q
2. M-x eshell
3. ls
4. ls
5. do 'ls' to list the files, until the prompt reachs the bottom
6. ls, then the prompt will scroll to the half of a page. I think it  
should be still stayed at the bottom.

If you do 'ls' in a path where has lots of files and can not be displayed  
in one page, the prompt will
appear in the half of the page directly, instead of the bottom of the page.

Is it a intended behavior? If yes, how to disable the feature?

I asked this (a intended behavior?), because if I do the following:
1.  emacs -q
2. C-x C-f
3. then hit 'enter', 'enter'..... in the keyboard
it will do the same behavior as in eshell (scroll to the half of a page).

But after I set following in .emacs, it can scroll line by line.

  '(scroll-conservatively 10000)
  '(scroll-down-aggressively 0.01)
  '(scroll-margin 3)
  '(scroll-preserve-screen-position t)
  '(scroll-up-aggressively 0.01)

But the above settings did not effect the 'eshell'. And I could not get  
help from *info* or the web
(http://www.gnu.org/software/emacs/manual/html_node/eshell/Smart-scrolling.html),  
they are
empty.

At last, let me make clear my request, that is: how to scroll line by line  
in eshell?

Thanks in advance!


On Wed, 19 Sep 2007 03:34:06 +0800, Richard Stallman <rms@gnu.org> wrote:

>     in eshell, if the files listed by ls are too many to display in  
> current
>     view of the buf, the prompt will scroll to the midle of it.
>
> Could you please send me a *precise* test case for this bug?  The test
> case should start with `emacs -q', so that your .emacs file does not
> affect it, and it should show exactly what text to put in the buffer,
> what commands to execute, and how and where to click.  Also please say
> exactly what incorrect results you get.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

"William Xue" wrote:

>> (add-hook 'eshell-output-filter-functions
>> 'eshell-postoutput-scroll-to-bottom)
>
> Thanks, it makes things closer.
>
> Now, after hiting 'enter', the prompt is at the bottom, but when
> input a letter, it will move one or two line up.

Not for me (though maybe I don't understand what you mean).

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Thu, 20 Sep 2007 09:39:21 +0800, Glenn Morris <rgm@gnu.org> wrote:

> "William Xue" wrote:
>
>>> (add-hook 'eshell-output-filter-functions
>>> 'eshell-postoutput-scroll-to-bottom)
>>
>> Thanks, it makes things closer.
>>
>> Now, after hiting 'enter', the prompt is at the bottom, but when
>> input a letter, it will move one or two line up.
>
> Not for me (though maybe I don't understand what you mean).


You can see the different between e:\sc_tmp_13.png and e:\sc_tmp_14.png.

Thanks!

[-- Attachment #2: sc_tmp_13.png --]
[-- Type: image/png, Size: 19054 bytes --]

[-- Attachment #3: sc_tmp_14.png --]
[-- Type: image/png, Size: 17181 bytes --]

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

"William Xue" wrote:

>>> Now, after hiting 'enter', the prompt is at the bottom, but when
>>> input a letter, it will move one or two line up.
[...]
> You can see the different between e:\sc_tmp_13.png and e:\sc_tmp_14.png.

Yes, I can. It doesn't do that for me though.

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

On Thu, 20 Sep 2007 16:13:39 +0800, Glenn Morris <rgm@gnu.org> wrote:

> "William Xue" wrote:
>
>>>> Now, after hiting 'enter', the prompt is at the bottom, but when
>>>> input a letter, it will move one or two line up.
> [...]
>> You can see the different between e:\sc_tmp_13.png and e:\sc_tmp_14.png.
>
> Yes, I can. It doesn't do that for me though.


I found the issue only occured in the default 'emacs -q' started window.


After I changed the window size, it works very well.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

Richard Stallman wrote:

> Can someone please DTRT, then ack?

I have DTRT on the trunk. Since it changes the behaviour, I'm inclined
to leave the release branch alone.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Richard Stallman]

    I found the issue only occured in the default 'emacs -q' started window.

That is an important addition to the description of the test
case to reproduce the bug.  Thanks.

Re: ls in eshell will cause the prompt jumped to mid of buf

[Richard Stallman]

    > Can someone please DTRT, then ack?

    I have DTRT on the trunk. Since it changes the behaviour, I'm inclined
    to leave the release branch alone.

The old behavior seems like a bug to me, so I think it should be fixed
in Emacs 22.

Do you think it is not a bug?

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

Richard Stallman wrote:

> The old behavior seems like a bug to me, so I think it should be fixed
> in Emacs 22.

Fair enough; done.

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

On Thu, 20 Sep 2007 16:13:39 +0800, Glenn Morris <rgm@gnu.org> wrote:

> "William Xue" wrote:
>
>>>> Now, after hiting 'enter', the prompt is at the bottom, but when
>>>> input a letter, it will move one or two line up.
> [...]
>> You can see the different between e:\sc_tmp_13.png and e:\sc_tmp_14.png.
>
> Yes, I can. It doesn't do that for me though.

I found the issue was cause by the setting for 'scroll-margin'.

I set 'scroll-margin' to 3, when input a char, the prompt scroll up 3  
lines.

Can I set the 'scroll-margin' to 0 only for 'eshell'? I have tried  
something on load hook, but failed.


-- 
Yours,
WilliamX

Re: ls in eshell will cause the prompt jumped to mid of buf

[Glenn Morris]

"William Xue" wrote:

> Can I set the 'scroll-margin' to 0 only for 'eshell'? I have tried  
> something on load hook, but failed.

(add-hook 'eshell-mode-hook
   (lambda () (set (make-local-variable 'scroll-margin) 0)))

Re: ls in eshell will cause the prompt jumped to mid of buf

[William Xue]

On Sat, 29 Sep 2007 02:07:02 +0800, Glenn Morris <rgm@gnu.org> wrote:

> "William Xue" wrote:
>
>> Can I set the 'scroll-margin' to 0 only for 'eshell'? I have tried
>> something on load hook, but failed.
>
> (add-hook 'eshell-mode-hook
>    (lambda () (set (make-local-variable 'scroll-margin) 0)))

Eh, yes, make-local-variable.

Thank you very much!

-- 
Yours,
WilliamX