From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: something like linum.el ought to be added
Date: Sun, 16 Sep 2007 23:58:43 -0400
Message-ID: <E1IX7kx-0007iZ-25@fencepost.gnu.org>
References: <86hcm4rw70.fsf@macs.hw.ac.uk>
	<E1IUmVj-0004eb-ND@fencepost.gnu.org> <m1tzq2pgp1.fsf@gmx.at>
	<f7ccd24b0709150724iabf3f72v11aa1eea15b668c1@mail.gmail.com>
	<m17imr534t.fsf@gmx.at> <E1IWmlt-0007c3-A5@fencepost.gnu.org>
	<m1ir6aa9ii.fsf@gmx.at>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1190001564 9731 80.91.229.12 (17 Sep 2007 03:59:24 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 17 Sep 2007 03:59:24 +0000 (UTC)
Cc: lekktu@gmail.com, emacs-devel@gnu.org
To: Markus Triska <markus.triska@gmx.at>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 17 05:59:23 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IX7lZ-0007UK-Cf
	for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2007 05:59:21 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1IX7lX-0005Hp-OJ
	for ged-emacs-devel@m.gmane.org; Sun, 16 Sep 2007 23:59:19 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IX7lU-0005He-5Q
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:16 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IX7lT-0005HL-5F
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:15 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IX7lS-0005H9-Sj
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:14 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1IX7lS-00024P-IN
	for emacs-devel@gnu.org; Sun, 16 Sep 2007 23:59:14 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1IX7kx-0007iZ-25; Sun, 16 Sep 2007 23:58:43 -0400
In-reply-to: <m1ir6aa9ii.fsf@gmx.at> (message from Markus Triska on Sun, 16
	Sep 2007 17:57:09 +0200)
X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:79072
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/79072>

It looks good, except for minor nits.  It can be installed, with these
nits fixed.

    +  if (!current_matrix_up_to_date_p
    +      && !NILP(Vwindow_bottom_change_functions))
    +      safe_run_hooks (Qwindow_bottom_change_functions);

It needs a space between NILP and the paren.

    +  DEFVAR_LISP ("window-bottom-change-functions", &Vwindow_bottom_change_functions,
    +    doc: /* List of functions to call when visibility changes may have altered
    +the position of the bottom of the window. */);

The first line of that doc string (like every doc string) should stand
on its own.