From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; savehist save invalid syntax Date: Mon, 10 Sep 2007 19:54:07 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1189472289 19652 80.91.229.12 (11 Sep 2007 00:58:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2007 00:58:09 +0000 (UTC) Cc: schwab@suse.de, sdl.web@gmail.com, emacs-pretest-bug@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 11 10:57:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IV0Zn-0004a7-Ik for ged-emacs-devel@m.gmane.org; Tue, 11 Sep 2007 09:54:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUt5R-0000tM-4u for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 19:54:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUt5N-0000rw-6T for emacs-devel@gnu.org; Mon, 10 Sep 2007 19:54:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUt5M-0000rh-HM for emacs-devel@gnu.org; Mon, 10 Sep 2007 19:54:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUt5M-0000re-Dd for emacs-devel@gnu.org; Mon, 10 Sep 2007 19:54:32 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUt5M-0006kp-65 for emacs-devel@gnu.org; Mon, 10 Sep 2007 19:54:32 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IUt4x-0000lo-SN; Mon, 10 Sep 2007 19:54:07 -0400 In-reply-to: X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78535 gmane.emacs.pretest.bugs:19837 Archived-At: I looked a bit closer at the rest as well, and I think that `savehist-prin1-readable' needs to actually read what it prints (like it did before Davis's patch). It should raise an error (hence remove the written entry and return nil) if either the write or the read fails. Why is this necessary, if `prin1' signals an error when printing anything unreadable?