all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: "Chris Moore" <dooglus@gmail.com>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: hexl: doesn't play nicely with dynamic-completion-mode
Date: Sun, 09 Sep 2007 21:13:11 -0400	[thread overview]
Message-ID: <E1IUXpv-0007Bk-TX@fencepost.gnu.org> (raw)
In-Reply-To: <a9691ee20709091101o8f56f0oc8a7657845b4baba@mail.gmail.com> (dooglus@gmail.com)

Here's a more elegant and general version of the fix.
Does it work in your test case?

*** completion.el	19 Aug 2007 16:31:48 -0400	1.63
--- completion.el	09 Sep 2007 16:31:50 -0400	
***************
*** 2231,2238 ****
  
  (defun completion-separator-self-insert-command (arg)
    (interactive "p")
!   (use-completion-before-separator)
!   (self-insert-command arg))
  
  (defun completion-separator-self-insert-autofilling (arg)
    (interactive "p")
--- 2231,2240 ----
  
  (defun completion-separator-self-insert-command (arg)
    (interactive "p")
!   (if (command-remapping 'self-insert-command)
!       (funcall (command-remapping 'self-insert-command) arg)
!     (use-completion-before-separator)
!     (self-insert-command arg)))
  
  (defun completion-separator-self-insert-autofilling (arg)
    (interactive "p")

  reply	other threads:[~2007-09-10  1:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m2r6tcu25g.fsf@gmail.com>
2007-09-08 14:47 ` hexl: doesn't play nicely with dynamic-completion-mode Chris Moore
     [not found]   ` <E1IUCIj-0000B4-Rz@fencepost.gnu.org>
2007-09-09 18:01     ` Chris Moore
2007-09-10  1:13       ` Richard Stallman [this message]
2007-09-10 11:35         ` Chris Moore
2007-09-10 14:14           ` Stefan Monnier
2007-09-10 18:43             ` Chris Moore
2007-09-10 20:20               ` Stefan Monnier
2007-09-13  8:26                 ` Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IUXpv-0007Bk-TX@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=dooglus@gmail.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.