From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Interactive specs of C functions.
Date: Sat, 08 Sep 2007 15:48:01 -0400
Message-ID: <E1IU6Hh-0002aX-9R@fencepost.gnu.org>
References: <87sl5qr093.fsf@cadilhac.name>
	<jwvabry4aph.fsf-monnier+emacs@gnu.org>
	<yoijveam9m8o.fsf@gamma02.me.chalmers.se>
	<jwv642lzyt9.fsf-monnier+emacs@gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1189281032 20724 80.91.229.12 (8 Sep 2007 19:50:32 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 8 Sep 2007 19:50:32 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 08 21:50:31 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IU6K6-0004PD-HX
	for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 21:50:30 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1IU6K4-0000Xe-CA
	for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 15:50:28 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IU6I4-00080D-Cu
	for emacs-devel@gnu.org; Sat, 08 Sep 2007 15:48:24 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IU6I2-0007zO-OS
	for emacs-devel@gnu.org; Sat, 08 Sep 2007 15:48:23 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IU6I2-0007zI-Cs
	for emacs-devel@gnu.org; Sat, 08 Sep 2007 15:48:22 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1IU6I2-00074m-1e
	for emacs-devel@gnu.org; Sat, 08 Sep 2007 15:48:22 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1IU6Hh-0002aX-9R; Sat, 08 Sep 2007 15:48:01 -0400
In-reply-to: <jwv642lzyt9.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Fri, 07 Sep 2007 22:18:48 -0400)
X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:78287
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/78287>

    Indeed.  How 'bout the patch below?

    -  if (SUBRP (fun))
    -    {
    -      string = (unsigned char *) XSUBR (fun)->prompt;
    -      if (!string)
    -	{
    -	lose:
    -	  wrong_type_argument (Qcommandp, function);
    -	}

That would be a slowdown in very important cases.  It would be better
to keep that code, but have it fall through when it doesn't find an
interactive string in the special way, into the general case.