From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: [cezar@mixandgo.ro: skeleton bug] Date: Fri, 07 Sep 2007 11:33:20 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1189132438 11810 80.91.229.12 (7 Sep 2007 02:33:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2007 02:33:58 +0000 (UTC) Cc: cezar@mixandgo.ro, rms@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 04:33:53 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ITTfL-0005ok-H3 for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2007 04:33:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITTfJ-0004nB-Bc for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2007 22:33:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ITTfE-0004mU-Hr for emacs-devel@gnu.org; Thu, 06 Sep 2007 22:33:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ITTfD-0004mI-5K for emacs-devel@gnu.org; Thu, 06 Sep 2007 22:33:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITTfC-0004mF-QR for emacs-devel@gnu.org; Thu, 06 Sep 2007 22:33:42 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ITTf8-0004hK-Hc; Thu, 06 Sep 2007 22:33:39 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id l872XSw7001407; Fri, 7 Sep 2007 11:33:28 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id l872XSrY009421; Fri, 7 Sep 2007 11:33:28 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id l872XKEb029840; Fri, 7 Sep 2007 11:33:20 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.67) (envelope-from ) id 1ITTeq-0002FC-7X; Fri, 07 Sep 2007 11:33:20 +0900 In-reply-to: (message from Stefan Monnier on Mon, 03 Sep 2007 17:22:57 -0400) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.0 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78059 Archived-At: In article , Stefan Monnier writes: > > I found that this is because of the following incompatible > > change in emacs-unicode-2. > > Emacs-22: (char-or-string-p -1) => t > > Emacs-23: (char-or-string-p -1) => nil > > According to the function name, I think it should return nil > > on -1. > > Which do you think is better? > > (1) Revert the change of char-or-string-p. > > (2) Keep char-or-string-p as is in emacs-unicode-2, > > make a new function integer-or-string-p, and check all > > occurrences of char-or-string-p in *.el files. > > I think we should keep the changed behavior of char-or-string-p, > > which fits with its name, and check all 8 callers. > Agreed, Ok. It was only skeleton.el that has a problem, and I fixed it. I didn't create integer-or-string-p because it seems that the function is not that useful. In skeleton.el, I simply used the combination of integerp and stringp. --- Kenichi Handa handa@m17n.org