From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: regression in C-x v = in latest versions Date: Sat, 25 Aug 2007 21:08:43 -0400 Message-ID: References: <200708191705.57599.pogonyshev@gmx.net> <200708232340.30025.pogonyshev@gmx.net> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1188090749 29759 80.91.229.12 (26 Aug 2007 01:12:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2007 01:12:29 +0000 (UTC) Cc: emacs-devel@gnu.org, pogonyshev@gmx.net To: Glenn Morris , monnier@IRO.UMontreal.CA Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 26 03:12:26 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IP6fx-0001lU-1f for ged-emacs-devel@m.gmane.org; Sun, 26 Aug 2007 03:12:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IP6fw-0002KA-An for ged-emacs-devel@m.gmane.org; Sat, 25 Aug 2007 21:12:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IP6cS-0006w4-LN for emacs-devel@gnu.org; Sat, 25 Aug 2007 21:08:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IP6cR-0006v2-Qk for emacs-devel@gnu.org; Sat, 25 Aug 2007 21:08:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IP6cR-0006ul-El for emacs-devel@gnu.org; Sat, 25 Aug 2007 21:08:47 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IP6cR-0004od-5u for emacs-devel@gnu.org; Sat, 25 Aug 2007 21:08:47 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IP6cN-00047P-PQ; Sat, 25 Aug 2007 21:08:43 -0400 In-reply-to: (message from Glenn Morris on Sat, 25 Aug 2007 16:50:38 -0400) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77179 Archived-At: This problem (only in the CVS trunk, therefore not relevant for Emacs 22.2, by the way) was introduced by Eric Raymond's 2007-07-18 change to VC. The (rather ominous) cvs log entry reads only: Put the lower half (the back-end) of NewVC in place. This commit makes only the minimum changes needed to get the old vc.el logic working with the new back ends. I asked him to provide a proper change log, and he did not do it. It isn't fair that he is leaving this job to be done by someone else, but if he won't do it, I think we need someone else to do it -- for the sake of maintainability. Stefan, can you do it? You know the VC code best. Anyway, it's caused by the removal of this code from vc-svn-diff: (if (and oldvers (equal oldvers (vc-workfile-version file))) ;; Use nil rather than the current revision because svn ;; handles it better (i.e. locally). (setq oldvers nil)) "file" has now been replaced by "files", a list. vc-workfile-version can easily be generalized to accept a list of files as input, so here's a possible patch. Though I don't understand how this is supposed to work now. I don't understand. Is this patch your suggested fix, or is it the patch you say broke things? Please always be explicit about that. It is not good to have to guess the answer. If it is your suggested fix, why do you suggest generalizing vc-workfile-version? Stefan, what do you think about how to fix this?