all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Glenn Morris <rgm@gnu.org>, monnier@IRO.UMontreal.CA
Cc: emacs-devel@gnu.org, pogonyshev@gmx.net
Subject: Re: regression in C-x v = in latest versions
Date: Sat, 25 Aug 2007 21:08:43 -0400	[thread overview]
Message-ID: <E1IP6cN-00047P-PQ@fencepost.gnu.org> (raw)
In-Reply-To: <a17injjq3l.fsf@fencepost.gnu.org> (message from Glenn Morris on Sat, 25 Aug 2007 16:50:38 -0400)

    This problem (only in the CVS trunk, therefore not relevant for Emacs
    22.2, by the way) was introduced by Eric Raymond's 2007-07-18 change
    to VC. The (rather ominous) cvs log entry reads only:

	Put the lower half (the back-end) of NewVC in place. This commit
	makes only the minimum changes needed to get the old vc.el logic
	working with the new back ends.

I asked him to provide a proper change log, and he did not do it.
It isn't fair that he is leaving this job to be done by
someone else, but if he won't do it, I think we need someone
else to do it -- for the sake of maintainability.

Stefan, can you do it?  You know the VC code best.

    Anyway, it's caused by the removal of this code from vc-svn-diff:

    (if (and oldvers (equal oldvers (vc-workfile-version file)))   
      ;; Use nil rather than the current revision because svn
      ;; handles it better (i.e. locally).   
      (setq oldvers nil))

    "file" has now been replaced by "files", a list. vc-workfile-version
    can easily be generalized to accept a list of files as input, so
    here's a possible patch. Though I don't understand how this is
    supposed to work now.

I don't understand.  Is this patch your suggested fix, or is it the
patch you say broke things?  Please always be explicit about that.
It is not good to have to guess the answer.

If it is your suggested fix, why do you suggest generalizing
vc-workfile-version?

Stefan, what do you think about how to fix this?

  parent reply	other threads:[~2007-08-26  1:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 14:05 regression in C-x v = in latest versions Paul Pogonyshev
2007-08-23 20:40 ` Paul Pogonyshev
2007-08-24 16:10   ` Richard Stallman
2007-08-25  0:05     ` Nick Roberts
2007-08-25 20:52       ` Richard Stallman
2007-08-25 21:07         ` Chong Yidong
2007-08-26 14:56           ` Richard Stallman
2007-08-25 22:37         ` Nick Roberts
2007-08-25 20:50   ` Glenn Morris
2007-08-25 21:14     ` Paul Pogonyshev
2007-08-26  1:08     ` Richard Stallman [this message]
2007-08-26  2:12       ` Glenn Morris
2007-08-26 22:47         ` Richard Stallman
2007-08-27  7:05           ` Glenn Morris
2007-08-26  2:31       ` Stefan Monnier
2007-08-26 22:47         ` Richard Stallman
2007-08-27  2:15           ` Chong Yidong
2007-08-27 18:18             ` Richard Stallman
2007-09-02 17:46               ` Dan Nicolaescu
2007-08-26  2:27     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IP6cN-00047P-PQ@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=pogonyshev@gmx.net \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.