[n_schumacher@web.de: diff-find-file-name and /dev/null]

[n_schumacher@web.de: diff-find-file-name and /dev/null]

[Richard Stallman]

Would someone please install this if it's correct, and then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
To: bug-gnu-emacs@gnu.org
From: Nikolaj Schumacher <n_schumacher@web.de>
Date: Sat, 18 Aug 2007 00:53:23 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: diff-find-file-name and /dev/null

- --=-=-=

Hello,

using diff files (from git) that create new files like this:

- --- /dev/null
+++ b/foo/bar.c

I noticed that `diff-goto-source' opens /dev/null, which is usually not
desirable.  I use the attached small change to get the actual file.


regards,
Nikolaj Schumacher


- --=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=emacs-diff-find-file-name.patch
Content-Description: patch

- --- lisp/diff-mode.el	2007-08-17 06:03:27.000000000 +0200
+++ lisp/diff-mode.el	2007-08-18 00:48:25.000000000 +0200
@@ -667,6 +667,7 @@
       (or (ignore-errors (diff-beginning-of-file))
 	  (re-search-forward diff-file-header-re nil t)))
     (let ((fs (diff-hunk-file-names old)))
+      (setq fs (delete "/dev/null" fs))
       (if prefix (setq fs (mapcar (lambda (f) (concat prefix f)) fs)))
       (or
        ;; use any previously used preference

- --=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs

- --=-=-=--
------- End of forwarded message -------

Re: [n_schumacher@web.de: diff-find-file-name and /dev/null]

[Glenn Morris]

Richard Stallman wrote:

> Would someone please install this if it's correct, and then ack?

I fixed this a slightly different way.

> From: Nikolaj Schumacher <n_schumacher@web.de>
> Subject: diff-find-file-name and /dev/null
> To: bug-gnu-emacs@gnu.org
> Date: Sat, 18 Aug 2007 00:53:23 +0200