all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: [n_schumacher@web.de: diff-find-file-name and /dev/null]
Date: Sat, 18 Aug 2007 20:44:48 -0400	[thread overview]
Message-ID: <E1IMYuO-00058l-B6@fencepost.gnu.org> (raw)

Would someone please install this if it's correct, and then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
To: bug-gnu-emacs@gnu.org
From: Nikolaj Schumacher <n_schumacher@web.de>
Date: Sat, 18 Aug 2007 00:53:23 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: diff-find-file-name and /dev/null

- --=-=-=

Hello,

using diff files (from git) that create new files like this:

- --- /dev/null
+++ b/foo/bar.c

I noticed that `diff-goto-source' opens /dev/null, which is usually not
desirable.  I use the attached small change to get the actual file.


regards,
Nikolaj Schumacher


- --=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=emacs-diff-find-file-name.patch
Content-Description: patch

- --- lisp/diff-mode.el	2007-08-17 06:03:27.000000000 +0200
+++ lisp/diff-mode.el	2007-08-18 00:48:25.000000000 +0200
@@ -667,6 +667,7 @@
       (or (ignore-errors (diff-beginning-of-file))
 	  (re-search-forward diff-file-header-re nil t)))
     (let ((fs (diff-hunk-file-names old)))
+      (setq fs (delete "/dev/null" fs))
       (if prefix (setq fs (mapcar (lambda (f) (concat prefix f)) fs)))
       (or
        ;; use any previously used preference

- --=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs

- --=-=-=--
------- End of forwarded message -------

             reply	other threads:[~2007-08-19  0:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19  0:44 Richard Stallman [this message]
2007-08-27  7:12 ` [n_schumacher@web.de: diff-find-file-name and /dev/null] Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IMYuO-00058l-B6@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.