From: Richard Stallman <rms@gnu.org>
To: Masatake YAMATO <jet@gyve.org>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] automatic multiple grep session
Date: Fri, 17 Aug 2007 00:50:09 -0400 [thread overview]
Message-ID: <E1ILtmj-0002rF-W9@fencepost.gnu.org> (raw)
In-Reply-To: <20070817.060714.149802751.jet@gyve.org> (message from Masatake YAMATO on Fri, 17 Aug 2007 06:07:14 +0900 (JST))
+(defcustom grep-use-command-line-as-buffer-name nil
+ "Use the command line of grep as the name for grep buffer if non-nil.
I can't make sense of that sentence, or that variable name.
Can you please explain what this feature is intended to do?
+(defun grep-make-buffer-name-function (seed-string)
+ "Make a function that returns a buffer name derived from SEED-STRING.
+This is used when `grep-use-command-line-as-buffer-name' is non-nil."
+ (when grep-use-command-line-as-buffer-name
+ (eval `(lambda (mode) (format "*%s*"
+ ,seed-string)))))
What's the purpose of calling `eval' here?
It is a bad thing to do, when it is not really necessary,
and I can't see the purpose of doing so here.
Please note that some of the code you changed had its line
breaks in the wrong place; I just fixed that.
prev parent reply other threads:[~2007-08-17 4:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 21:07 [patch] automatic multiple grep session Masatake YAMATO
2007-08-16 22:43 ` Lennart Borgman (gmail)
2007-08-17 3:24 ` Stefan Monnier
2007-08-18 1:37 ` Lennart Borgman (gmail)
2007-08-19 23:18 ` Juri Linkov
2007-08-17 4:50 ` Richard Stallman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ILtmj-0002rF-W9@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jet@gyve.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.