From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: status of dir-vars or dir-locals inclusion in emacs? Date: Tue, 31 Jul 2007 13:05:46 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1185901426 24885 80.91.229.12 (31 Jul 2007 17:03:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2007 17:03:46 +0000 (UTC) Cc: joakim@verona.se, emacs-devel@gnu.org To: tromey@redhat.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 31 19:03:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IFv8D-0006rb-1b for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2007 19:03:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IFv8C-0005pD-Jj for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2007 13:03:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IFv89-0005p8-Pz for emacs-devel@gnu.org; Tue, 31 Jul 2007 13:03:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IFv88-0005ow-EC for emacs-devel@gnu.org; Tue, 31 Jul 2007 13:03:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IFv88-0005ot-8L for emacs-devel@gnu.org; Tue, 31 Jul 2007 13:03:32 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IFv87-0007SI-SQ for emacs-devel@gnu.org; Tue, 31 Jul 2007 13:03:31 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IFvAI-0003B2-OX; Tue, 31 Jul 2007 13:05:46 -0400 In-reply-to: (message from Tom Tromey on Sun, 29 Jul 2007 16:59:34 -0600) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75862 Archived-At: I did want to ask whether this is something that should be enabled by default. Definitely. It looks ready to install, as far as I can see, aside from some minor points. Do you disagree? (defun project-install-bindings-from-alist (mode-alist) "Apply local variable settings from MODE-ALIST." (mapc (lambda (pair) (let ((variable (car pair)) Using dolist would be clearer (and more efficient). ;; - need a way to add to auto-mode-alist per-project ;; e.g., semantic wants GCC's .def files to be c-mode ;; (RMS points out that this is also easily done by adding comments ;; to the particular files.) The point is, we don't need another way to do it, so that item should be deleted. ;; - maybe an easy way to integrate with customize? That would be a very good feature to add. ;; - per-project and per-mode new file skeletons I don't think that is very important. Some doc comments: The comments at the start of the file tend to use passive voice: Settings can be ;; checked in to the project's version control and they will ;; automatically be found and used by Emacs. ;; A project class can be defined manually using ;; `define-project-bindings'. Then a directory can be associated with a ;; given class using `set-directory-project'. The active voice is easier to read, and clearer, because it states the subject. Can you please rewrite all the passive voice sentences to active, except when there is some very strong specific reason to use passive voice? ;; When a file is loaded, project.el will search up the directory ;; hierarchy. Please stick to present tense except when that won't work. ;; (define-project-bindings 'gcc ;; '((nil . ((indent-tabs-mode . t) ;; (tab-width . 8) ;; (fill-column . 80))) That's not indented right.