From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: pp-eval-expression enhancements Date: Wed, 25 Jul 2007 11:02:45 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1185375739 10750 80.91.229.12 (25 Jul 2007 15:02:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Jul 2007 15:02:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 25 17:02:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDiNT-0000qK-58 for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 17:02:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDiNS-0008FL-Uo for ged-emacs-devel@m.gmane.org; Wed, 25 Jul 2007 11:02:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDiMN-0007M4-H7 for emacs-devel@gnu.org; Wed, 25 Jul 2007 11:01:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDiML-0007LG-Ti for emacs-devel@gnu.org; Wed, 25 Jul 2007 11:01:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDiML-0007L8-Na for emacs-devel@gnu.org; Wed, 25 Jul 2007 11:01:05 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IDiMJ-0007DE-Vh for emacs-devel@gnu.org; Wed, 25 Jul 2007 11:01:04 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IDiNx-0003e5-PY; Wed, 25 Jul 2007 11:02:45 -0400 In-reply-to: X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75524 Archived-At: Would someone please install this in the trunk, then ack? From: "Drew Adams" To: Date: Tue, 24 Jul 2007 10:18:30 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" In-Reply-To: Cc: emacs-devel@gnu.org Subject: RE: pp-eval-expression enhancements > Can you please send the two changes that I'd like to install, > with change log? Then we can install them. Below. What about also replacing the binding of `M-:' so that it invokes `pp-eval-expression'? What is the downside to that? If it's for the prefix arg of `eval-expression', we could add the prefix arg to `pp-eval-expression' also. If it's for `eval-expression-debug-on-error', then `pp-eval-expression' could be made aware of that also. It seems to me that for interactive use (`M-:') `pp-eval-expression' is more useful than `eval-expression'. --------8<----------------- Change log: 2007-07-24 Drew Adams * pp.el: pp-eval-expression: Added progress message. Made buffer writable. --------8<----------------- *** pp-CVS-2007-07-10.el Tue Jul 10 15:37:26 2007 --- pp-CVS-patched-2007-07-24.el Tue Jul 24 09:58:02 2007 *************** *** 103,108 **** --- 103,109 ---- (interactive (list (read-from-minibuffer "Eval: " nil read-expression-map t 'read-expression-history))) + (message "Evaluating...") (setq values (cons (eval expression) values)) (let* ((old-show-function temp-buffer-show-function) ;; Use this function to display the buffer. *************** *** 126,138 **** (progn (select-window window) (run-hooks 'temp-buffer-show-hook)) ! (select-window old-selected))) ! (message "%s" (buffer-substring (point-min) (point))) ! )))))) (with-output-to-temp-buffer "*Pp Eval Output*" (pp (car values)) (with-current-buffer standard-output (emacs-lisp-mode) (set (make-local-variable 'font-lock-verbose) nil))))) ;;;###autoload --- 127,140 ---- (progn (select-window window) (run-hooks 'temp-buffer-show-hook)) ! (select-window old-selected) ! (message "Evaluating...done. See buffer *Pp Eval Output*."))) ! (message "%s" (buffer-substring (point-min) (point))))))))) (with-output-to-temp-buffer "*Pp Eval Output*" (pp (car values)) (with-current-buffer standard-output (emacs-lisp-mode) + (setq buffer-read-only nil) (set (make-local-variable 'font-lock-verbose) nil))))) ;;;###autoload _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel