From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: vc-revert broken for Subversion files Date: Tue, 24 Jul 2007 12:45:39 -0400 Message-ID: References: <18083.30192.743099.875105@rgrjr.dyndns.org> <200707221859.l6MIxbA9014188@oogie-boogie.ics.uci.edu> <87d4ykt8eh.fsf@ambire.localdomain> <87k5sq51lc.fsf@ambire.localdomain> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1185295451 11075 80.91.229.12 (24 Jul 2007 16:44:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Jul 2007 16:44:11 +0000 (UTC) Cc: rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 24 18:44:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDNUW-0004Yv-Gj for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 18:44:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDNUV-0003dp-Ts for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 12:44:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IDNUR-0003Z5-Oq for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IDNUQ-0003We-VD for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IDNUQ-0003WH-Rd for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:02 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IDNUQ-0000Pm-Hw for emacs-devel@gnu.org; Tue, 24 Jul 2007 12:44:02 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IDNVz-0002oD-Id; Tue, 24 Jul 2007 12:45:39 -0400 In-reply-to: <87k5sq51lc.fsf@ambire.localdomain> (message from Thien-Thi Nguyen on Mon, 23 Jul 2007 22:03:59 +0200) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75458 Archived-At: * vc-hooks.el: Generalize stay-local-p to operate on lists of files. Change two keybindings to point to new function names. * vc-arch.el, vc-bzr.el, vc-cvs.el, vc-hg.el, vc-mcvs.el, vc-rcs.el, vc-sccs.el, vc-svn.el: These now implement the NewVC-fileset. * vc.el: Adapted for NewVC-fileset, but no functional changes yet. yes. unfortunately, even w/ this ChangeLog entry, i am unable to determine the intent (sense) of the "generalization". my doubt is as follows: I have asked him to put in a clear and detailed change log entry. when applied to many files, i can imagine two equally valid policies: (a) if any file of the list is stay-local-p, enable optimizations. (b) if all files of the list are stay-local-p, enable optimizations. as is (just checked in), the code supports (a) but not (b). could maintainers of client code give this some thought, and confirm or revise the code accordingly? it comes down to "any" vs "all" semantics, of which i'm slightly paranoid, having been bitten in a previous life... the more i think about it, the more (b) would make sense (AND gate), since optimizations may not be possible if any one file in the list is NOT stay-local-p. this boolean stuff is (simply ;-) weird... Could you write to him and Stefan to discuss the question?