* Emacs unicode 2 build failed
@ 2007-05-28 6:29 Herbert Euler
2007-05-28 6:55 ` Kenichi Handa
0 siblings, 1 reply; 8+ messages in thread
From: Herbert Euler @ 2007-05-28 6:29 UTC (permalink / raw)
To: emacs-devel
The error message is
gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -I.
-I/home/xgp/src/emacs/newcvs/emacs/src -D_BSD_SOURCE -g -O2 term.c
In file included from term.c:418:
buffer.h:403: redefinition of `struct buffer_text'
buffer.h:461: redefinition of `struct buffer'
make[1]: *** [term.o] Error 1
make[1]: Leaving directory `/home/xgp/src/emacs/newcvs/emacs/src'
make: *** [src] Error 2
term.c includes buffer.h twice and there is no any protection in
buffer.h
Regards,
Guanpeng Xu
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-05-28 6:29 Herbert Euler
@ 2007-05-28 6:55 ` Kenichi Handa
2007-05-28 17:03 ` Giorgos Keramidas
0 siblings, 1 reply; 8+ messages in thread
From: Kenichi Handa @ 2007-05-28 6:55 UTC (permalink / raw)
To: Herbert Euler; +Cc: emacs-devel
In article <BAY143-F39233A4B056401AC2C409FDA280@phx.gbl>, "Herbert Euler" <herberteuler@hotmail.com> writes:
> The error message is
> gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -I.
> -I/home/xgp/src/emacs/newcvs/emacs/src -D_BSD_SOURCE -g -O2 term.c
> In file included from term.c:418:
> buffer.h:403: redefinition of `struct buffer_text'
> buffer.h:461: redefinition of `struct buffer'
> make[1]: *** [term.o] Error 1
> make[1]: Leaving directory `/home/xgp/src/emacs/newcvs/emacs/src'
> make: *** [src] Error 2
> term.c includes buffer.h twice and there is no any protection in
> buffer.h
I've just deleted the second include.
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-05-28 6:55 ` Kenichi Handa
@ 2007-05-28 17:03 ` Giorgos Keramidas
2007-05-29 0:54 ` Kenichi Handa
2007-05-29 4:10 ` Richard Stallman
0 siblings, 2 replies; 8+ messages in thread
From: Giorgos Keramidas @ 2007-05-28 17:03 UTC (permalink / raw)
To: Kenichi Handa; +Cc: Herbert Euler, emacs-devel
On 2007-05-28 15:55, Kenichi Handa <handa@m17n.org> wrote:
> In article <BAY143-F39233A4B056401AC2C409FDA280@phx.gbl>, "Herbert Euler" <herberteuler@hotmail.com> writes:
>
> > The error message is
> > gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -I.
> > -I/home/xgp/src/emacs/newcvs/emacs/src -D_BSD_SOURCE -g -O2 term.c
> > In file included from term.c:418:
> > buffer.h:403: redefinition of `struct buffer_text'
> > buffer.h:461: redefinition of `struct buffer'
> > make[1]: *** [term.o] Error 1
> > make[1]: Leaving directory `/home/xgp/src/emacs/newcvs/emacs/src'
> > make: *** [src] Error 2
>
> > term.c includes buffer.h twice and there is no any protection in
> > buffer.h
>
> I've just deleted the second include.
Wouldn't it be a `better' solution to add something like the following
to buffer.h, to avoid multiple inclusions of the header text?
%%%
diff -Nprc3 gnu.c9d9b15c47d7/src/buffer.h gnu/src/buffer.h
*** gnu.c9d9b15c47d7/src/buffer.h Mon May 28 20:02:15 2007
--- gnu/src/buffer.h Mon May 28 20:02:15 2007
*************** along with GNU Emacs; see the file COPYI
*** 19,24 ****
--- 19,26 ----
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA. */
+ #ifndef EMACS_BUFFER_H
+ #define EMACS_BUFFER_H
/* Accessing the parameters of the current buffer. */
*************** extern int last_per_buffer_idx;
*** 1003,1005 ****
--- 1005,1009 ----
/* arch-tag: 679305dd-d41c-4a50-b170-3caf5c97b2d1
(do not change this comment) */
+
+ #endif /* EMACS_BUFFER_H */
%%%
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-05-28 17:03 ` Giorgos Keramidas
@ 2007-05-29 0:54 ` Kenichi Handa
2007-05-29 4:10 ` Richard Stallman
1 sibling, 0 replies; 8+ messages in thread
From: Kenichi Handa @ 2007-05-29 0:54 UTC (permalink / raw)
To: Giorgos Keramidas; +Cc: herberteuler, emacs-devel
In article <20070528170313.GA69126@kobe.laptop>, Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> > > term.c includes buffer.h twice and there is no any protection in
> > > buffer.h
> >
> > I've just deleted the second include.
> Wouldn't it be a `better' solution to add something like the following
> to buffer.h, to avoid multiple inclusions of the header text?
I think it's a good change, but I think unnecessary multiple
inclusion should also be deleted.
And, I want to postpone any cosmetic changes in
emacs-unicode-2. I don't object to add "#ifdef" in buffer.h
in the trunk.
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-05-28 17:03 ` Giorgos Keramidas
2007-05-29 0:54 ` Kenichi Handa
@ 2007-05-29 4:10 ` Richard Stallman
1 sibling, 0 replies; 8+ messages in thread
From: Richard Stallman @ 2007-05-29 4:10 UTC (permalink / raw)
To: Giorgos Keramidas; +Cc: herberteuler, emacs-devel, handa
Wouldn't it be a `better' solution to add something like the following
to buffer.h, to avoid multiple inclusions of the header text?
In the trunk, let's do this.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Emacs unicode 2 build failed
@ 2007-07-16 1:58 Herbert Euler
2007-07-18 1:09 ` Kenichi Handa
0 siblings, 1 reply; 8+ messages in thread
From: Herbert Euler @ 2007-07-16 1:58 UTC (permalink / raw)
To: emacs-devel
Newest checking build failed:
gcc -c -I/usr/X11R6/include -I/usr/local/include -L/usr/local/lib
-Demacs -DHAVE_CONFIG_H -I. -I/home/xgp/src/emacs-build/emacs/src
-/usr/X11R6/include -I/usr/local/include -L/usr/local/lib -g -O2
keymap.c
keymap.c: In function `Faccessible_keymaps':
keymap.c:2245: `accessible_keymaps_char_table' undeclared (first use in this
function)
keymap.c:2245: (Each undeclared identifier is reported only once
keymap.c:2245: for each function it appears in.)
keymap.c: In function `where_is_internal':
keymap.c:2751: warning: passing arg 4 of `where_is_internal_1' makes pointer
from integer without a cast
keymap.c:2751: too many arguments to function `where_is_internal_1'
keymap.c:2751: void value not ignored as it ought to be
keymap.c:2765: `where_is_internal_2' undeclared (first use in this function)
keymap.c:2777: warning: passing arg 4 of `where_is_internal_1' makes pointer
from integer without a cast
keymap.c:2777: too many arguments to function `where_is_internal_1'
keymap.c:2777: void value not ignored as it ought to be
keymap.c: At top level:
keymap.c:2994: `where_is_internal_2' used prior to declaration
keymap.c: In function `where_is_internal_2':
keymap.c:3025: warning: passing arg 4 of `where_is_internal_1' makes pointer
from integer without a cast
keymap.c:3025: too many arguments to function `where_is_internal_1'
keymap.c:3025: void value not ignored as it ought to be
keymap.c:3035: warning: passing arg 4 of `where_is_internal_1' makes pointer
from integer without a cast
keymap.c:3035: too many arguments to function `where_is_internal_1'
keymap.c:3035: void value not ignored as it ought to be
keymap.c: At top level:
keymap.c:3052: conflicting types for `where_is_internal_1'
keymap.c:2623: previous declaration of `where_is_internal_1'
keymap.c: In function `where_is_internal_1':
keymap.c:3085: `d' undeclared (first use in this function)
gmake[2]: *** [keymap.o] Error 1
gmake[2]: Leaving directory `/home/xgp/src/emacs-build/emacs/src'
gmake[1]: *** [bootstrap-build] Error 2
gmake[1]: Leaving directory `/home/xgp/src/emacs-build/emacs'
gmake: *** [bootstrap] Error 2
Regards,
Guanpeng Xu
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-07-16 1:58 Emacs unicode 2 build failed Herbert Euler
@ 2007-07-18 1:09 ` Kenichi Handa
2007-07-18 18:31 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Kenichi Handa @ 2007-07-18 1:09 UTC (permalink / raw)
To: Herbert Euler; +Cc: emacs-devel
In article <BAY143-F30AE6AB63A5E53E8773A33DAF80@phx.gbl>, "Herbert Euler" <herberteuler@hotmail.com> writes:
> Newest checking build failed:
> gcc -c -I/usr/X11R6/include -I/usr/local/include -L/usr/local/lib
> -Demacs -DHAVE_CONFIG_H -I. -I/home/xgp/src/emacs-build/emacs/src
> -/usr/X11R6/include -I/usr/local/include -L/usr/local/lib -g -O2
> keymap.c
> keymap.c: In function `Faccessible_keymaps':
> keymap.c:2245: `accessible_keymaps_char_table' undeclared (first use in this
> function)
This is because of imcomplete merging of the CVS trunk.
Stefan is now taking care of it.
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs unicode 2 build failed
2007-07-18 1:09 ` Kenichi Handa
@ 2007-07-18 18:31 ` Stefan Monnier
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Monnier @ 2007-07-18 18:31 UTC (permalink / raw)
To: Kenichi Handa; +Cc: Herbert Euler, emacs-devel
>> gcc -c -I/usr/X11R6/include -I/usr/local/include -L/usr/local/lib
>> -Demacs -DHAVE_CONFIG_H -I. -I/home/xgp/src/emacs-build/emacs/src
>> -/usr/X11R6/include -I/usr/local/include -L/usr/local/lib -g -O2
>> keymap.c
>> keymap.c: In function `Faccessible_keymaps':
>> keymap.c:2245: `accessible_keymaps_char_table' undeclared (first use in this
>> function)
> This is because of imcomplete merging of the CVS trunk.
> Stefan is now taking care of it.
AFAIK it was fixed yesterday already, so if you still see problems, please
report them.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-07-18 18:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-16 1:58 Emacs unicode 2 build failed Herbert Euler
2007-07-18 1:09 ` Kenichi Handa
2007-07-18 18:31 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2007-05-28 6:29 Herbert Euler
2007-05-28 6:55 ` Kenichi Handa
2007-05-28 17:03 ` Giorgos Keramidas
2007-05-29 0:54 ` Kenichi Handa
2007-05-29 4:10 ` Richard Stallman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.