* Re: OS X: load-path on self-contained build
2007-07-15 22:11 ` Seiji Zenitani
@ 2007-07-16 15:49 ` Richard Stallman
2007-07-23 22:30 ` Richard Stallman
` (3 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2007-07-16 15:49 UTC (permalink / raw)
To: Seiji Zenitani; +Cc: emacs-devel
Your patch is small enough that we could install it without legal
papers. Thanks.
Would those who maintain Emacs on MacOS please DTRT?
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-07-15 22:11 ` Seiji Zenitani
2007-07-16 15:49 ` Richard Stallman
@ 2007-07-23 22:30 ` Richard Stallman
2007-07-30 20:48 ` Richard Stallman
` (2 subsequent siblings)
4 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2007-07-23 22:30 UTC (permalink / raw)
To: emacs-devel
Would those who maintain Emacs on MacOS please DTRT?
The attached patch (by R. Yoshitake; GPL) works fine for me.
Is there any potential side-effects?
Seiji Zenitani
zenitani@mac.com
--- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
+++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
@@ -5331,12 +5335,12 @@
q[0] = '\0';
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/lisp");
+ strcat (p, "/Contents/Resources/site-lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
strcat (q, p);
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/leim");
+ strcat (p, "/Contents/Resources/lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
@@ -5345,7 +5349,7 @@
}
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/site-lisp");
+ strcat (p, "/Contents/Resources/leim");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-07-15 22:11 ` Seiji Zenitani
2007-07-16 15:49 ` Richard Stallman
2007-07-23 22:30 ` Richard Stallman
@ 2007-07-30 20:48 ` Richard Stallman
2007-07-31 2:13 ` Seiji Zenitani
2007-08-06 16:33 ` Richard Stallman
4 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2007-07-30 20:48 UTC (permalink / raw)
To: emacs-devel
[I sent this message two weeks ago but did not get a response.]
Would those who maintain Emacs on MacOS please DTRT
and ack?
The attached patch (by R. Yoshitake; GPL) works fine for me.
Is there any potential side-effects?
Seiji Zenitani
zenitani@mac.com
--- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
+++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
@@ -5331,12 +5335,12 @@
q[0] = '\0';
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/lisp");
+ strcat (p, "/Contents/Resources/site-lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
strcat (q, p);
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/leim");
+ strcat (p, "/Contents/Resources/lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
@@ -5345,7 +5349,7 @@
}
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/site-lisp");
+ strcat (p, "/Contents/Resources/leim");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-07-15 22:11 ` Seiji Zenitani
` (2 preceding siblings ...)
2007-07-30 20:48 ` Richard Stallman
@ 2007-07-31 2:13 ` Seiji Zenitani
2007-08-01 21:46 ` Vinicius Jose Latorre
2007-08-06 16:33 ` Richard Stallman
4 siblings, 1 reply; 15+ messages in thread
From: Seiji Zenitani @ 2007-07-31 2:13 UTC (permalink / raw)
To: emacs-devel
Hi,
Could anyone please deal with the below patch? According to the CVS,
that part was written by Dr. Andrew Choi 5 years ago (revision 1.9,
Fri Aug 16 02:30:21 2002 UTC). I noticed that comment strings (/
* ... */) near the relevant lines should reflect the change, too.
Seiji Zenitani
zenitani@mac.com
On 2007/07/15, at 18:11, Seiji Zenitani wrote:
> On 2007/07/10, at 18:01, Richard Stallman wrote:
>
>> Would someone please fix this, then ack?
>
>
> The attached patch (by R. Yoshitake; GPL) works fine for me.
> Is there any potential side-effects?
>
>
> Seiji Zenitani
> zenitani@mac.com
>
>
> --- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
> +++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
> @@ -5331,12 +5335,12 @@
> q[0] = '\0';
> strcpy (p, app_bundle_pathname);
> - strcat (p, "/Contents/Resources/lisp");
> + strcat (p, "/Contents/Resources/site-lisp");
> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
> strcat (q, p);
> strcpy (p, app_bundle_pathname);
> - strcat (p, "/Contents/Resources/leim");
> + strcat (p, "/Contents/Resources/lisp");
> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
> {
> if (q[0] != '\0')
> @@ -5345,7 +5349,7 @@
> }
> strcpy (p, app_bundle_pathname);
> - strcat (p, "/Contents/Resources/site-lisp");
> + strcat (p, "/Contents/Resources/leim");
> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
> {
> if (q[0] != '\0')
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-07-31 2:13 ` Seiji Zenitani
@ 2007-08-01 21:46 ` Vinicius Jose Latorre
2007-08-01 22:06 ` Seiji Zenitani
0 siblings, 1 reply; 15+ messages in thread
From: Vinicius Jose Latorre @ 2007-08-01 21:46 UTC (permalink / raw)
To: Seiji Zenitani; +Cc: emacs-devel
Done.
Patch applied in trunk and Emacs 22 branch.
Seiji Zenitani wrote:
> Hi,
>
> Could anyone please deal with the below patch? According to the CVS,
> that part was written by Dr. Andrew Choi 5 years ago (revision 1.9,
> Fri Aug 16 02:30:21 2002 UTC). I noticed that comment strings (/* ...
> */) near the relevant lines should reflect the change, too.
>
> Seiji Zenitani
> zenitani@mac.com
>
> On 2007/07/15, at 18:11, Seiji Zenitani wrote:
>> On 2007/07/10, at 18:01, Richard Stallman wrote:
>>
>>> Would someone please fix this, then ack?
>>
>>
>> The attached patch (by R. Yoshitake; GPL) works fine for me.
>> Is there any potential side-effects?
>>
>>
>> Seiji Zenitani
>> zenitani@mac.com
>>
>>
>> --- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
>> +++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
>> @@ -5331,12 +5335,12 @@
>> q[0] = '\0';
>> strcpy (p, app_bundle_pathname);
>> - strcat (p, "/Contents/Resources/lisp");
>> + strcat (p, "/Contents/Resources/site-lisp");
>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>> strcat (q, p);
>> strcpy (p, app_bundle_pathname);
>> - strcat (p, "/Contents/Resources/leim");
>> + strcat (p, "/Contents/Resources/lisp");
>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>> {
>> if (q[0] != '\0')
>> @@ -5345,7 +5349,7 @@
>> }
>> strcpy (p, app_bundle_pathname);
>> - strcat (p, "/Contents/Resources/site-lisp");
>> + strcat (p, "/Contents/Resources/leim");
>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>> {
>> if (q[0] != '\0')
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-08-01 21:46 ` Vinicius Jose Latorre
@ 2007-08-01 22:06 ` Seiji Zenitani
2007-08-01 22:23 ` Vinicius Jose Latorre
0 siblings, 1 reply; 15+ messages in thread
From: Seiji Zenitani @ 2007-08-01 22:06 UTC (permalink / raw)
To: Vinicius Jose Latorre; +Cc: emacs-devel
In order to avoid future misunderstanding,
could you please fix the relevant comment string, too?
--- mac.c.orig 2007-08-01 18:00:27.000000000 -0400
+++ mac.c 2007-08-01 18:01:53.000000000 -0400
@@ -5322,8 +5322,8 @@
/* P should have sufficient room for the pathname of the bundle plus
the subpath in it leading to the respective directories. Q
should have three times that much room because EMACSLOADPATH can
- have the value "<path to lisp dir>:<path to leim dir>:<path to
- site-lisp dir>". */
+ have the value "<path to site-lisp dir>:<path to lisp dir>:<path
+ to leim dir>". */
p = (char *) alloca (app_bundle_pathname_len + 50);
q = (char *) alloca (3 * app_bundle_pathname_len + 150);
if (!getenv ("EMACSLOADPATH"))
On Wednesday, August 01, 2007, at 05:45PM, "Vinicius Jose Latorre" <viniciusjl@ig.com.br> wrote:
>
>Done.
>
>Patch applied in trunk and Emacs 22 branch.
>
>
>Seiji Zenitani wrote:
>> Hi,
>>
>> Could anyone please deal with the below patch? According to the CVS,
>> that part was written by Dr. Andrew Choi 5 years ago (revision 1.9,
>> Fri Aug 16 02:30:21 2002 UTC). I noticed that comment strings (/* ...
>> */) near the relevant lines should reflect the change, too.
>>
>> Seiji Zenitani
>> zenitani@mac.com
>>
>> On 2007/07/15, at 18:11, Seiji Zenitani wrote:
>>> On 2007/07/10, at 18:01, Richard Stallman wrote:
>>>
>>>> Would someone please fix this, then ack?
>>>
>>>
>>> The attached patch (by R. Yoshitake; GPL) works fine for me.
>>> Is there any potential side-effects?
>>>
>>>
>>> Seiji Zenitani
>>> zenitani@mac.com
>>>
>>>
>>> --- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
>>> +++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
>>> @@ -5331,12 +5335,12 @@
>>> q[0] = '\0';
>>> strcpy (p, app_bundle_pathname);
>>> - strcat (p, "/Contents/Resources/lisp");
>>> + strcat (p, "/Contents/Resources/site-lisp");
>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>> strcat (q, p);
>>> strcpy (p, app_bundle_pathname);
>>> - strcat (p, "/Contents/Resources/leim");
>>> + strcat (p, "/Contents/Resources/lisp");
>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>> {
>>> if (q[0] != '\0')
>>> @@ -5345,7 +5349,7 @@
>>> }
>>> strcpy (p, app_bundle_pathname);
>>> - strcat (p, "/Contents/Resources/site-lisp");
>>> + strcat (p, "/Contents/Resources/leim");
>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>> {
>>> if (q[0] != '\0')
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-08-01 22:06 ` Seiji Zenitani
@ 2007-08-01 22:23 ` Vinicius Jose Latorre
2007-08-01 22:40 ` Glenn Morris
0 siblings, 1 reply; 15+ messages in thread
From: Vinicius Jose Latorre @ 2007-08-01 22:23 UTC (permalink / raw)
To: Seiji Zenitani; +Cc: emacs-devel
Done.
Patch applied in trunk and Emacs 22 branch.
Seiji Zenitani wrote:
> In order to avoid future misunderstanding,
> could you please fix the relevant comment string, too?
>
> --- mac.c.orig 2007-08-01 18:00:27.000000000 -0400
> +++ mac.c 2007-08-01 18:01:53.000000000 -0400
> @@ -5322,8 +5322,8 @@
> /* P should have sufficient room for the pathname of the bundle plus
> the subpath in it leading to the respective directories. Q
> should have three times that much room because EMACSLOADPATH can
> - have the value "<path to lisp dir>:<path to leim dir>:<path to
> - site-lisp dir>". */
> + have the value "<path to site-lisp dir>:<path to lisp dir>:<path
> + to leim dir>". */
> p = (char *) alloca (app_bundle_pathname_len + 50);
> q = (char *) alloca (3 * app_bundle_pathname_len + 150);
> if (!getenv ("EMACSLOADPATH"))
>
> On Wednesday, August 01, 2007, at 05:45PM, "Vinicius Jose Latorre" <viniciusjl@ig.com.br> wrote:
>
>> Done.
>>
>> Patch applied in trunk and Emacs 22 branch.
>>
>>
>> Seiji Zenitani wrote:
>>
>>> Hi,
>>>
>>> Could anyone please deal with the below patch? According to the CVS,
>>> that part was written by Dr. Andrew Choi 5 years ago (revision 1.9,
>>> Fri Aug 16 02:30:21 2002 UTC). I noticed that comment strings (/* ...
>>> */) near the relevant lines should reflect the change, too.
>>>
>>> Seiji Zenitani
>>> zenitani@mac.com
>>>
>>> On 2007/07/15, at 18:11, Seiji Zenitani wrote:
>>>
>>>> On 2007/07/10, at 18:01, Richard Stallman wrote:
>>>>
>>>>
>>>>> Would someone please fix this, then ack?
>>>>>
>>>> The attached patch (by R. Yoshitake; GPL) works fine for me.
>>>> Is there any potential side-effects?
>>>>
>>>>
>>>> Seiji Zenitani
>>>> zenitani@mac.com
>>>>
>>>>
>>>> --- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
>>>> +++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
>>>> @@ -5331,12 +5335,12 @@
>>>> q[0] = '\0';
>>>> strcpy (p, app_bundle_pathname);
>>>> - strcat (p, "/Contents/Resources/lisp");
>>>> + strcat (p, "/Contents/Resources/site-lisp");
>>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>>> strcat (q, p);
>>>> strcpy (p, app_bundle_pathname);
>>>> - strcat (p, "/Contents/Resources/leim");
>>>> + strcat (p, "/Contents/Resources/lisp");
>>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>>> {
>>>> if (q[0] != '\0')
>>>> @@ -5345,7 +5349,7 @@
>>>> }
>>>> strcpy (p, app_bundle_pathname);
>>>> - strcat (p, "/Contents/Resources/site-lisp");
>>>> + strcat (p, "/Contents/Resources/leim");
>>>> if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
>>>> {
>>>> if (q[0] != '\0')
>>>>
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-08-01 22:23 ` Vinicius Jose Latorre
@ 2007-08-01 22:40 ` Glenn Morris
2007-08-01 23:13 ` Vinicius Jose Latorre
0 siblings, 1 reply; 15+ messages in thread
From: Glenn Morris @ 2007-08-01 22:40 UTC (permalink / raw)
To: Vinicius Jose Latorre; +Cc: Seiji Zenitani, emacs-devel
Vinicius Jose Latorre wrote:
> Patch applied in trunk and Emacs 22 branch.
Looks like the ChangeLog entry has the wrong author. In either case,
it should be marked as a "tiny change". Thanks.
>>>>> The attached patch (by R. Yoshitake; GPL) works fine for me.
~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: OS X: load-path on self-contained build
2007-08-01 22:40 ` Glenn Morris
@ 2007-08-01 23:13 ` Vinicius Jose Latorre
2007-08-02 0:08 ` Vinicius Jose Latorre
0 siblings, 1 reply; 15+ messages in thread
From: Vinicius Jose Latorre @ 2007-08-01 23:13 UTC (permalink / raw)
To: Glenn Morris; +Cc: Seiji Zenitani, emacs-devel
Ooops, does anyone know the email of R. Yoshitake?
What email should be inserted?
Glenn Morris wrote:
> Vinicius Jose Latorre wrote:
>
>
>> Patch applied in trunk and Emacs 22 branch.
>>
>
> Looks like the ChangeLog entry has the wrong author. In either case,
> it should be marked as a "tiny change". Thanks.
>
>
>>>>>> The attached patch (by R. Yoshitake; GPL) works fine for me.
>>>>>>
> ~~~~~~~~~~~~~~
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: OS X: load-path on self-contained build
2007-08-01 23:13 ` Vinicius Jose Latorre
@ 2007-08-02 0:08 ` Vinicius Jose Latorre
0 siblings, 0 replies; 15+ messages in thread
From: Vinicius Jose Latorre @ 2007-08-02 0:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: Seiji Zenitani, emacs-devel
Seiji gave the right email address.
Done.
ChangeLog fixed in trunk and Emacs 22 branch.
Vinicius Jose Latorre wrote:
>
> Ooops, does anyone know the email of R. Yoshitake?
>
> What email should be inserted?
>
>
> Glenn Morris wrote:
>> Vinicius Jose Latorre wrote:
>>
>>
>>> Patch applied in trunk and Emacs 22 branch.
>>>
>>
>> Looks like the ChangeLog entry has the wrong author. In either case,
>> it should be marked as a "tiny change". Thanks.
>>
>>
>>>>>>> The attached patch (by R. Yoshitake; GPL) works fine for me.
>>>>>>>
>> ~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: OS X: load-path on self-contained build
2007-07-15 22:11 ` Seiji Zenitani
` (3 preceding siblings ...)
2007-07-31 2:13 ` Seiji Zenitani
@ 2007-08-06 16:33 ` Richard Stallman
2007-08-06 18:08 ` Glenn Morris
4 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2007-08-06 16:33 UTC (permalink / raw)
To: emacs-devel
[I sent this message twice but did not get a response.]
Would those who maintain Emacs on MacOS please DTRT
and ack?
The attached patch (by R. Yoshitake; GPL) works fine for me.
Is there any potential side-effects?
Seiji Zenitani
zenitani@mac.com
--- src/mac.c.orig 2007-04-20 09:26:45.000000000 -0400
+++ src/mac.c 2007-06-09 18:54:42.000000000 -0400
@@ -5331,12 +5335,12 @@
q[0] = '\0';
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/lisp");
+ strcat (p, "/Contents/Resources/site-lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
strcat (q, p);
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/leim");
+ strcat (p, "/Contents/Resources/lisp");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
@@ -5345,7 +5349,7 @@
}
strcpy (p, app_bundle_pathname);
- strcat (p, "/Contents/Resources/site-lisp");
+ strcat (p, "/Contents/Resources/leim");
if (stat (p, &st) == 0 && (st.st_mode & S_IFMT) == S_IFDIR)
{
if (q[0] != '\0')
^ permalink raw reply [flat|nested] 15+ messages in thread