From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: find-file-noselect needs save-match-data Date: Fri, 15 Jun 2007 04:48:09 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1181897303 13434 80.91.229.12 (15 Jun 2007 08:48:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2007 08:48:23 +0000 (UTC) Cc: miles.bader@necel.com, schwab@suse.de, emacs-devel@gnu.org, juri@jurta.org, monnier@iro.umontreal.ca, miles@gnu.org To: "Herbert Euler" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 15 10:48:21 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hz7Tg-0000tg-9P for ged-emacs-devel@m.gmane.org; Fri, 15 Jun 2007 10:48:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hz7Tf-00085z-Pi for ged-emacs-devel@m.gmane.org; Fri, 15 Jun 2007 04:48:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hz7Tc-00085q-J2 for emacs-devel@gnu.org; Fri, 15 Jun 2007 04:48:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hz7Tb-00085R-5X for emacs-devel@gnu.org; Fri, 15 Jun 2007 04:48:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hz7Ta-00085O-W5 for emacs-devel@gnu.org; Fri, 15 Jun 2007 04:48:15 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hz7Ta-0001dP-JO for emacs-devel@gnu.org; Fri, 15 Jun 2007 04:48:14 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1Hz7TV-0002MX-Gf; Fri, 15 Jun 2007 04:48:09 -0400 In-reply-to: (herberteuler@hotmail.com) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72930 Archived-At: Finally, I knew it's in type-break, and then I knew the problem is caused by `find-file-noselect' which is put on `post-command-hook' and changes the match data. I think it is a bug to expect the match data to be preserved across `post-command-hook'. Which code expects that? We should fix that code to protect itself. However, I think `find-file-noselect' may as well call `save-match-data' for the sake of other places it may be used.