From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: contribution of ruby-mode.el Date: Sun, 03 Jun 2007 17:27:50 -0400 Message-ID: References: <200706021912.l52JC7DD018615@sharui.nakada.kanuma.tochigi.jp> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1180906380 20922 80.91.229.12 (3 Jun 2007 21:33:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2007 21:33:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nobuyoshi Nakada Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 23:32:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Huxh4-00004u-GO for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2007 23:32:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Huxh4-0007eG-0f for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2007 17:32:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HuxcR-0001Cr-Lh for emacs-devel@gnu.org; Sun, 03 Jun 2007 17:28:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HuxcQ-0001An-ST for emacs-devel@gnu.org; Sun, 03 Jun 2007 17:28:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HuxcQ-0001AK-Lv for emacs-devel@gnu.org; Sun, 03 Jun 2007 17:28:10 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HuxcQ-0000qI-Fy for emacs-devel@gnu.org; Sun, 03 Jun 2007 17:28:10 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1Huxc6-000669-OO; Sun, 03 Jun 2007 17:27:50 -0400 In-reply-to: <200706021912.l52JC7DD018615@sharui.nakada.kanuma.tochigi.jp> (message from Nobuyoshi Nakada on Sun, 03 Jun 2007 04:12:07 +0900) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72154 Archived-At: To make this program understandable and maintainable, please give every defconst and every defun a doc string that explains what jobs they do. Large functions such as ruby-calculate-indent need a comment to explain every group of lines. Maintaining Emacs is hard already, and if we don't want to make it harder, we need to ensure that new files are really clear. It would also be good to add comments at the top of the file decribing the features that the mode provides. (cond ((featurep 'font-lock) (or (boundp 'font-lock-variable-name-face) (setq font-lock-variable-name-face font-lock-type-face)) (setq ruby-font-lock-syntactic-keywords Please delete that cond, and put all the contents at top level.