From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch for user-emacs-directory Date: Sun, 03 Jun 2007 01:08:44 -0400 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1180847355 30862 80.91.229.12 (3 Jun 2007 05:09:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2007 05:09:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: tromey@redhat.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 07:09:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HuiL1-0007Ey-IE for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2007 07:09:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HuiL0-0006nd-MI for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2007 01:09:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HuiKw-0006nY-29 for emacs-devel@gnu.org; Sun, 03 Jun 2007 01:09:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HuiKu-0006nM-0K for emacs-devel@gnu.org; Sun, 03 Jun 2007 01:09:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HuiKt-0006nJ-O2 for emacs-devel@gnu.org; Sun, 03 Jun 2007 01:09:03 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HuiKt-0007lh-Cw for emacs-devel@gnu.org; Sun, 03 Jun 2007 01:09:03 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1HuiKa-0003YC-HY; Sun, 03 Jun 2007 01:08:44 -0400 In-reply-to: (message from Tom Tromey on Sat, 02 Jun 2007 21:26:17 -0600) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72098 Archived-At: > Cc: emacs-devel@gnu.org > From: Tom Tromey > Reply-To: tromey@redhat.com > Date: Sat, 02 Jun 2007 21:26:17 -0600 > > - ((file-directory-p (convert-standard-filename "~/.emacs.d/")) > - (convert-standard-filename > - (expand-file-name "completions" "~/.emacs.d/"))) > + ((file-directory-p user-emacs-directory) > + (expand-file-name "completions" user-emacs-directory)) > > I'm happy to reword this, but can you explain how this change can > cause failures? convert-standard-filename has a non-trivial definition on more systems than just MS-DOS. I don't think it's right to remove it, because doing so have a potential of letting invalid file names creep into Emacs on those systems. IOW, I think leaving convert-standard-filename is good engineering, not something for which I have specific failure scenarios. In general, we should run _all_ file names hard-wired into Emacs through this function. (I apologize for saying ``quite a few'' where evidently there's only one instance of removal; in my defence I can only say that a quick reading of the patch did somehow seem to remove convert-standard-filename in more instances.)