* compose-mail-other-window
@ 2007-03-24 18:41 martin rudalics
2007-03-25 8:30 ` compose-mail-other-window Leo
` (3 more replies)
0 siblings, 4 replies; 15+ messages in thread
From: martin rudalics @ 2007-03-24 18:41 UTC (permalink / raw)
To: emacs-devel
Due to the recent change of `compose-mail' `compose-mail-other-window'
will fail to show the window for editing the message. Removing the
`save-window-excursion' in `compose-mail' should cure this.
Similar misbehaviors have been reported previously by Alfred M. Szmidt
and John ffitch.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-03-24 18:41 compose-mail-other-window martin rudalics
@ 2007-03-25 8:30 ` Leo
2007-03-25 17:28 ` compose-mail-other-window Richard Stallman
` (2 subsequent siblings)
3 siblings, 0 replies; 15+ messages in thread
From: Leo @ 2007-03-25 8:30 UTC (permalink / raw)
To: emacs-devel
On 2007-03-24, martin rudalics said:
> Due to the recent change of `compose-mail'
> `compose-mail-other-window' will fail to show the window for editing
> the message. Removing the `save-window-excursion' in `compose-mail'
> should cure this.
>
> Similar misbehaviors have been reported previously by Alfred
> M. Szmidt and John ffitch.
Indeed, compose-mail-other-window is broken in my Emacs 22.0.95 built
on 2007-03-18. It puts the mail buffer in fundamental mode.
--
Leo <sdl.web AT gmail.com> (GPG Key: 9283AA3F)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-03-24 18:41 compose-mail-other-window martin rudalics
2007-03-25 8:30 ` compose-mail-other-window Leo
@ 2007-03-25 17:28 ` Richard Stallman
2007-03-25 18:45 ` compose-mail-other-window martin rudalics
2007-03-25 18:05 ` compose-mail-other-window Chong Yidong
2007-05-26 0:30 ` compose-mail-other-window Leo
3 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2007-03-25 17:28 UTC (permalink / raw)
To: martin rudalics, Alfred M. Szmidt; +Cc: emacs-devel
Due to the recent change of `compose-mail' `compose-mail-other-window'
will fail to show the window for editing the message. Removing the
`save-window-excursion' in `compose-mail' should cure this.
This removes the `save-window-excursion'. Does this work right?
*** simple.el 19 Mar 2007 17:03:02 -0500 1.852
--- simple.el 25 Mar 2007 11:52:34 -0500
***************
*** 4729,4739 ****
(let ((function (get mail-user-agent 'composefunc))
result-buffer)
(if switch-function
! (save-window-excursion
! (prog1
! (funcall function to subject other-headers continue
! nil yank-action send-actions)
! (funcall switch-function (current-buffer))))
(funcall function to subject other-headers continue
nil yank-action send-actions))))
--- 4729,4738 ----
(let ((function (get mail-user-agent 'composefunc))
result-buffer)
(if switch-function
! (prog1
! (funcall function to subject other-headers continue
! nil yank-action send-actions)
! (funcall switch-function (current-buffer)))
(funcall function to subject other-headers continue
nil yank-action send-actions))))
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-03-24 18:41 compose-mail-other-window martin rudalics
2007-03-25 8:30 ` compose-mail-other-window Leo
2007-03-25 17:28 ` compose-mail-other-window Richard Stallman
@ 2007-03-25 18:05 ` Chong Yidong
2007-05-26 0:30 ` compose-mail-other-window Leo
3 siblings, 0 replies; 15+ messages in thread
From: Chong Yidong @ 2007-03-25 18:05 UTC (permalink / raw)
To: rms; +Cc: martin rudalics, emacs-devel
martin rudalics <rudalics@gmx.at> writes:
> Due to the recent change of `compose-mail' `compose-mail-other-window'
> will fail to show the window for editing the message. Removing the
> `save-window-excursion' in `compose-mail' should cure this.
>
> Similar misbehaviors have been reported previously by Alfred M. Szmidt
> and John ffitch.
I think the offending patch should be reverted. It tries to avoid
passing the SWITCH-FUNCTION argument to sendmail-user-agent-compose;
if I'm not mistaken, this change originated from Michaël Cadilhac's
2007-03-07 complaint to emacs-devel that report-emacs-bug overrides
mail buffers that are already open. But this behavior was tolerable;
it doesn't justify working around the neat SWITCH-FUNCTION interface
to sendmail-user-agent-compose.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-03-24 18:41 compose-mail-other-window martin rudalics
` (2 preceding siblings ...)
2007-03-25 18:05 ` compose-mail-other-window Chong Yidong
@ 2007-05-26 0:30 ` Leo
2007-05-28 2:13 ` compose-mail-other-window Katsumi Yamaoka
3 siblings, 1 reply; 15+ messages in thread
From: Leo @ 2007-05-26 0:30 UTC (permalink / raw)
To: emacs-devel
----- martin rudalics (2007-03-24) wrote:-----
> Due to the recent change of `compose-mail' `compose-mail-other-window'
> will fail to show the window for editing the message. Removing the
> `save-window-excursion' in `compose-mail' should cure this.
>
> Similar misbehaviors have been reported previously by Alfred M. Szmidt
> and John ffitch.
This bug is not completely fixed.
To reproduce:
1. emacs -q
2. (setq mail-user-agent 'message-user-agent)
3. C-x 5 m
The mail buffer is still in fundamental mode.
I have also tested it with the default value and gnus-user-agent and it
works fine.
--
Leo <sdl.web AT gmail.com> (GPG Key: 9283AA3F)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-26 0:30 ` compose-mail-other-window Leo
@ 2007-05-28 2:13 ` Katsumi Yamaoka
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Katsumi Yamaoka @ 2007-05-28 2:13 UTC (permalink / raw)
To: Leo; +Cc: ding, emacs-devel
>>>>> In <m2abvsfmtd.fsf@sl392.st-edmunds.cam.ac.uk> Leo wrote:
> ----- martin rudalics (2007-03-24) wrote:-----
>> Due to the recent change of `compose-mail' `compose-mail-other-window'
>> will fail to show the window for editing the message. Removing the
>> `save-window-excursion' in `compose-mail' should cure this.
>>
>> Similar misbehaviors have been reported previously by Alfred M. Szmidt
>> and John ffitch.
> This bug is not completely fixed.
> To reproduce:
> 1. emacs -q
> 2. (setq mail-user-agent 'message-user-agent)
> 3. C-x 5 m
> The mail buffer is still in fundamental mode.
> I have also tested it with the default value and gnus-user-agent and it
> works fine.
Sorry, that's my bad.
2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
* message.el (message-generate-new-buffers):
[...]
(message-mail): Prefer `switch-function' if it is given;
It requires running `message-mode' further. I've fixed it in
both the trunk and the v5-10 branch of the Gnus CVS repository.
I think this change is worth merging to not only the Emacs trunk
but also the EMACS_22_BASE branch.
Regards,
P.S.
http://www.jpl.org/ftp/pub/elisp/message-multiple-frames.el.gz
has already been updated.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-28 2:13 ` compose-mail-other-window Katsumi Yamaoka
@ 2007-05-28 2:46 ` Chong Yidong
2007-05-28 3:06 ` compose-mail-other-window Katsumi Yamaoka
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
2007-05-28 7:25 ` compose-mail-other-window Leo
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
2 siblings, 2 replies; 15+ messages in thread
From: Chong Yidong @ 2007-05-28 2:46 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: Leo, ding, emacs-devel
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> 2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
>
> * message.el (message-generate-new-buffers):
> [...]
> (message-mail): Prefer `switch-function' if it is given;
>
> It requires running `message-mode' further. I've fixed it in
> both the trunk and the v5-10 branch of the Gnus CVS repository.
> I think this change is worth merging to not only the Emacs trunk
> but also the EMACS_22_BASE branch.
I checked it, and it looks good. I checked it into the EMACS_22_BASE
branch. Thanks.
(I assumed the automagic syncing between Gnus CVS and Emacs CVS HEAD
will take care of the trunk; is that right?)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
@ 2007-05-28 3:06 ` Katsumi Yamaoka
2007-05-28 4:13 ` compose-mail-other-window Chong Yidong
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
1 sibling, 1 reply; 15+ messages in thread
From: Katsumi Yamaoka @ 2007-05-28 3:06 UTC (permalink / raw)
To: Chong Yidong; +Cc: Leo, ding, emacs-devel
>>>>> In <87wsytekd0.fsf@stupidchicken.com> Chong Yidong wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> 2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
>>
>> * message.el (message-generate-new-buffers):
>> [...]
>> (message-mail): Prefer `switch-function' if it is given;
>>
>> It requires running `message-mode' further. I've fixed it in
>> both the trunk and the v5-10 branch of the Gnus CVS repository.
>> I think this change is worth merging to not only the Emacs trunk
>> but also the EMACS_22_BASE branch.
> I checked it, and it looks good. I checked it into the EMACS_22_BASE
> branch. Thanks.
> (I assumed the automagic syncing between Gnus CVS and Emacs CVS HEAD
> will take care of the trunk; is that right?)
Thank you very much for this. Could you merge another fix that
I made recently to the EMACS_22_BASE branch, too? The discussion
is here:
http://news.gmane.org/group/gmane.emacs.gnus.general/thread=64667/force_load=t
And this is the patch:
2007-05-24 Katsumi Yamaoka <yamaoka@jpl.org>
* message.el (message-narrow-to-headers-or-head): Ignore
mail-header-separator in the body.
--8<---------------cut here---------------start------------->8---
*** message.el~ Mon May 28 03:03:46 2007
--- message.el Mon May 28 03:05:06 2007
***************
*** 2225,2238 ****
(widen)
(narrow-to-region
(goto-char (point-min))
! (cond
! ((re-search-forward
! (concat "^" (regexp-quote mail-header-separator) "\n") nil t)
! (match-beginning 0))
! ((search-forward "\n\n" nil t)
! (1- (point)))
! (t
! (point-max))))
(goto-char (point-min)))
(defun message-news-p ()
--- 2225,2236 ----
(widen)
(narrow-to-region
(goto-char (point-min))
! (if (re-search-forward (concat "\\(\n\\)\n\\|^\\("
! (regexp-quote mail-header-separator)
! "\n\\)")
! nil t)
! (or (match-end 1) (match-beginning 2))
! (point-max)))
(goto-char (point-min)))
(defun message-news-p ()
--8<---------------cut here---------------end--------------->8---
Thanks in advance.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
2007-05-28 3:06 ` compose-mail-other-window Katsumi Yamaoka
@ 2007-05-29 0:03 ` Richard Stallman
1 sibling, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2007-05-29 0:03 UTC (permalink / raw)
To: Chong Yidong; +Cc: yamaoka, sdl.web, ding, emacs-devel
I checked it, and it looks good. I checked it into the EMACS_22_BASE
branch. Thanks.
I'd like the doc fix in rx.el to be checked, and applied if correct.
Also, Martin's table.el change.
Aside from that, I think we are ready for a release, but let's
first have people run it for a couple of days.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-28 2:13 ` compose-mail-other-window Katsumi Yamaoka
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
@ 2007-05-28 7:25 ` Leo
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
2 siblings, 0 replies; 15+ messages in thread
From: Leo @ 2007-05-28 7:25 UTC (permalink / raw)
To: emacs-devel; +Cc: ding
----- Katsumi Yamaoka (2007-05-28) wrote:-----
> Sorry, that's my bad.
>
> 2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
>
> * message.el (message-generate-new-buffers):
> [...]
> (message-mail): Prefer `switch-function' if it is given;
Thank you for the fix.
--
Leo <sdl.web AT gmail.com> (GPG Key: 9283AA3F)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-28 2:13 ` compose-mail-other-window Katsumi Yamaoka
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
2007-05-28 7:25 ` compose-mail-other-window Leo
@ 2007-05-29 0:03 ` Richard Stallman
2007-05-29 0:22 ` compose-mail-other-window Katsumi Yamaoka
2 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2007-05-29 0:03 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: sdl.web, ding, emacs-devel
2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
* message.el (message-generate-new-buffers):
[...]
(message-mail): Prefer `switch-function' if it is given;
It requires running `message-mode' further. I've fixed it in
both the trunk and the v5-10 branch of the Gnus CVS repository.
I think this change is worth merging to not only the Emacs trunk
but also the EMACS_22_BASE branch.
Please fix it in EMACS_22_BASE.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: compose-mail-other-window
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
@ 2007-05-29 0:22 ` Katsumi Yamaoka
0 siblings, 0 replies; 15+ messages in thread
From: Katsumi Yamaoka @ 2007-05-29 0:22 UTC (permalink / raw)
To: rms; +Cc: sdl.web, ding, emacs-devel
>>>>> In <E1HspBN-0001RB-8m@fencepost.gnu.org> Richard Stallman wrote:
> 2007-03-15 Katsumi Yamaoka <yamaoka@jpl.org>
> * message.el (message-generate-new-buffers):
> [...]
> (message-mail): Prefer `switch-function' if it is given;
> It requires running `message-mode' further. I've fixed it in
> both the trunk and the v5-10 branch of the Gnus CVS repository.
> I think this change is worth merging to not only the Emacs trunk
> but also the EMACS_22_BASE branch.
> Please fix it in EMACS_22_BASE.
It has already been checked by Chong Yidong. Thanks.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2007-05-29 0:22 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-24 18:41 compose-mail-other-window martin rudalics
2007-03-25 8:30 ` compose-mail-other-window Leo
2007-03-25 17:28 ` compose-mail-other-window Richard Stallman
2007-03-25 18:45 ` compose-mail-other-window martin rudalics
2007-03-25 18:05 ` compose-mail-other-window Chong Yidong
2007-05-26 0:30 ` compose-mail-other-window Leo
2007-05-28 2:13 ` compose-mail-other-window Katsumi Yamaoka
2007-05-28 2:46 ` compose-mail-other-window Chong Yidong
2007-05-28 3:06 ` compose-mail-other-window Katsumi Yamaoka
2007-05-28 4:13 ` compose-mail-other-window Chong Yidong
2007-05-28 4:18 ` compose-mail-other-window Katsumi Yamaoka
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
2007-05-28 7:25 ` compose-mail-other-window Leo
2007-05-29 0:03 ` compose-mail-other-window Richard Stallman
2007-05-29 0:22 ` compose-mail-other-window Katsumi Yamaoka
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.