From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: EOL conversion of files in .tar archives Date: Wed, 23 May 2007 10:22:06 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1179883344 11322 80.91.229.12 (23 May 2007 01:22:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 May 2007 01:22:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 23 03:22:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HqfYQ-0006vv-Ni for ged-emacs-devel@m.gmane.org; Wed, 23 May 2007 03:22:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqfYR-0002fM-Ny for ged-emacs-devel@m.gmane.org; Tue, 22 May 2007 21:22:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HqfYO-0002ez-4K for emacs-devel@gnu.org; Tue, 22 May 2007 21:22:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HqfYM-0002cf-Ef for emacs-devel@gnu.org; Tue, 22 May 2007 21:22:14 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqfYM-0002cc-9T for emacs-devel@gnu.org; Tue, 22 May 2007 21:22:14 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HqfYK-0007Um-T0; Tue, 22 May 2007 21:22:13 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id l4N1M7E5024770; Wed, 23 May 2007 10:22:07 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id l4N1M7O1002910; Wed, 23 May 2007 10:22:07 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id l4N1M63C019530; Wed, 23 May 2007 10:22:06 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.63) (envelope-from ) id 1HqfYE-00032e-46; Wed, 23 May 2007 10:22:06 +0900 In-reply-to: (message from Eli Zaretskii on Tue, 22 May 2007 14:19:14 +0300) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.0 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71638 Archived-At: In article , Eli Zaretskii writes: > I'd like to suggest an alternative change that is local to > tar-mode.el, see below. It mimics what arc-mode.el does. It seems that the alternative change works well too especially because arc-mode is doing the same thing. But... > +(defun tar-file-name-handler (op &rest args) > + "Helper function for `tar-extract'." > + (or (eq op 'file-exists-p) > + (let ((file-name-handler-alist nil)) > + (apply op args)))) Is it ok to check only file-exists-p? How about file-readable-p? > Sorry, that patch was incomplete, and so did an imperfect job. Please > use the one below. Does this new version have the following problem too? > This solves the problem with the EOL decoding, but reveals a very > strange phenomenon: dos-w32.el and dos-w32.elc behave differently. > The latter is preloaded into Emacs on Windows, and if I visit a file > inside a tarball (after applying the patch below), plain text files > with Unix EOLs get latin-1-unix buffer-file-coding-system, instead of > the expected undecided-unix. But if I manually load dos-w32.el and > visit the same file again, its buffer-file-coding-system is now > undecided-unix, as expected! Is this some problem with the byte > compiler? --- Kenichi Handa handa@m17n.org