* url-cookie.el: Minor patch for handling trusted sites:
@ 2007-04-27 13:15 T. V. Raman
2007-04-30 22:09 ` Richard Stallman
0 siblings, 1 reply; 2+ messages in thread
From: T. V. Raman @ 2007-04-27 13:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Magnus Henoch
Here is a minor patch to url-cookie.el:
Description: Package url provides a user settable option
url-cookie-trusted-urls that specifies a list of trusted sites.
The function that is supposed to use this ---
url-cookie-handle-set-cookie computes the "trustability" of a
set cookie action, but then omits to use what it computed.
This patch adds a check for that test.
diff url-cookie.el.orig url-cookie.el
452c452,453
< ((url-cookie-host-can-set-p (url-host url-current-object) domain)
---
> ((or trusted
> (url-cookie-host-can-set-p (url-host url-current-object) domain))
06:10:33 labrador url $
While in the neighborhood, could someone also look at function
url-cookie-host-can-set-p -- the test in that function for
checking whether a host is within a particular domain didn't make
much sense to me.
Thanks,
--Raman
--
Best Regards,
--raman
Email: raman@users.sf.net
WWW: http://emacspeak.sf.net/raman/
AIM: emacspeak GTalk: tv.raman.tv@gmail.com
PGP: http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman
IRC: irc://irc.freenode.net/#emacs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: url-cookie.el: Minor patch for handling trusted sites:
2007-04-27 13:15 url-cookie.el: Minor patch for handling trusted sites: T. V. Raman
@ 2007-04-30 22:09 ` Richard Stallman
0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2007-04-30 22:09 UTC (permalink / raw)
To: raman; +Cc: mange, emacs-devel
It DOES use the result of matching url-cookie-trusted-urls, in that it
overrides a possible match for url-cookie-untrusted-urls.
I am not sure that the behavior is wrong. I think we should not
change this now. However, would someone who understands the URL
package please DTRT for after the release?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-30 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-27 13:15 url-cookie.el: Minor patch for handling trusted sites: T. V. Raman
2007-04-30 22:09 ` Richard Stallman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.