From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Fwd: parse-time-string error with non ASCII timestamp Date: Tue, 17 Apr 2007 20:50:00 +0900 Message-ID: References: <1175499420.269736.200740@b75g2000hsg.googlegroups.com> <9649271a0704170310s5c92163bv15f8d6e8eaef37db@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1176810621 25575 80.91.229.12 (17 Apr 2007 11:50:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 17 Apr 2007 11:50:21 +0000 (UTC) Cc: zslevin@gmail.com, emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 17 13:50:14 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HdmCK-0006xL-2u for ged-emacs-devel@m.gmane.org; Tue, 17 Apr 2007 13:50:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HdmH2-00067P-3s for ged-emacs-devel@m.gmane.org; Tue, 17 Apr 2007 07:55:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HdmGz-00067K-TX for emacs-devel@gnu.org; Tue, 17 Apr 2007 07:55:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HdmGy-000678-Gk for emacs-devel@gnu.org; Tue, 17 Apr 2007 07:55:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HdmGy-000675-Ac for emacs-devel@gnu.org; Tue, 17 Apr 2007 07:55:00 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HdmCE-0007S3-U8 for emacs-devel@gnu.org; Tue, 17 Apr 2007 07:50:07 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id l3HBo16C025100; Tue, 17 Apr 2007 20:50:01 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp4.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id l3HBo0eu006236; Tue, 17 Apr 2007 20:50:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp4.aist.go.jp with ESMTP id l3HBo0Ag015030; Tue, 17 Apr 2007 20:50:00 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.63) (envelope-from ) id 1HdmC8-000240-AJ; Tue, 17 Apr 2007 20:50:00 +0900 In-reply-to: (message from Andreas Schwab on Tue, 17 Apr 2007 13:33:23 +0200) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.97 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69523 Archived-At: In article , Andreas Schwab writes: [...] >>> (defsubst parse-time-string-chars (char) >>> ! (and (< char (length parse-time-syntax)) >>> ! (aref parse-time-syntax char))) > > > > It seems that this is the right fix at the moment because > > parse-time.el doesn't pay attention to non-ASCII characters > > at all. In the future, we may have to improve it for > > non-ASCII characters if necesary. > I'd guess all that needs to be done is to make parse-time-digits and > parse-time-syntax char tables. Just making them char-tables has the same effect as above. If we want to handle a multibyte time-string well, we must set proper values to those char-tables which, I think, is beyond what we should do at the moment. > > Shall I install that change? > digit-char-p has the same problem. But, it seems that it is never called with a multibyte character. --- Kenichi Handa handa@m17n.org