From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: weird desktop.el change Date: Fri, 13 Apr 2007 23:45:28 -0400 Message-ID: References: <87d52bbwro.fsf@catnip.gol.com> <878xcycx95.fsf@catnip.gol.com> <87wt0g2oog.fsf@gmx.at> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1176522492 710 80.91.229.12 (14 Apr 2007 03:48:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2007 03:48:12 +0000 (UTC) Cc: lekktu@gmail.com, emacs-devel@gnu.org, markus.triska@gmx.at, miles@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 14 05:48:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HcZFA-0006Lo-JC for ged-emacs-devel@m.gmane.org; Sat, 14 Apr 2007 05:48:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HcZJV-0006cD-1E for ged-emacs-devel@m.gmane.org; Fri, 13 Apr 2007 23:52:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HcZJQ-0006Wz-Q5 for emacs-devel@gnu.org; Fri, 13 Apr 2007 23:52:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HcZJQ-0006W0-Cd for emacs-devel@gnu.org; Fri, 13 Apr 2007 23:52:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HcZJQ-0006Ve-9G for emacs-devel@gnu.org; Fri, 13 Apr 2007 23:52:32 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HcZF4-0000c5-Dx for emacs-devel@gnu.org; Fri, 13 Apr 2007 23:48:02 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1HcZCa-0001Hm-PY; Fri, 13 Apr 2007 23:45:28 -0400 In-reply-to: (message from Stefan Monnier on Fri, 13 Apr 2007 15:20:11 -0400) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69420 Archived-At: > 2007-04-13 Markus Triska > * emacs-lisp/byte-opt.el (byte-optimize-form-code-walker): rewrite > `mapcar' to `mapc' when called for effect Please, let's not add this before the release. I agree. PS: I'm not even sure it's a good optimization: in 99% of the cases it would be better to educate the programmer about mapc by emitting a warning, and in 99% of those cases, it'd be even better to replace the mapc(ar) by a dolist loop. Markus says his code does issue a warning. However, I think it would be better to implement this warning in the code generation stage so as to give the warning the correct line number. I think that would make the optimization unnecessary.