all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* eshell ansi colors, copyright q
@ 2007-03-09 17:26 Mark A. Hershberger
  2007-03-10 15:50 ` Richard Stallman
  0 siblings, 1 reply; 6+ messages in thread
From: Mark A. Hershberger @ 2007-03-09 17:26 UTC (permalink / raw)
  To: emacs-devel


Question: Is this sufficiently short/different/obvious that it doesn't
require a copyright assignment?

After reading on http://www.emacswiki.org/cgi-bin/wiki/EshellColor
that eshell doesn't handle ansi colors properly, I would like to add
the following to eshell/esh-mode.el:

--- esh-mode.el	09 Mar 2007 12:11:17 -0500	1.27
+++ esh-mode.el	09 Mar 2007 12:20:17 -0500	
@@ -1078,6 +1078,13 @@
 (custom-add-option 'eshell-output-filter-functions
 		   'eshell-handle-control-codes)
 
+(defun eshell-handle-ansi-color ()
+  (ansi-color-apply-on-region eshell-last-output-start
+                              eshell-last-output-end))
+
+(custom-add-option 'eshell-output-filter-functions
+		   'eshell-handle-ansi-color)
+
 ;;; Code:
 
 ;;; arch-tag: ec65bc2b-da14-4547-81d3-a32af3a4dc57


The emacswiki page contains the following snip which I adapted above:

    (defun eshell-handle-ansi-color ()
      (ansi-color-apply-on-region eshell-last-output-start
                                  eshell-last-output-end))
    (add-to-list 'eshell-output-filter-functions 'eshell-handle-ansi-color)

-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: eshell ansi colors, copyright q
  2007-03-09 17:26 eshell ansi colors, copyright q Mark A. Hershberger
@ 2007-03-10 15:50 ` Richard Stallman
  2007-03-11  1:51   ` Mark A. Hershberger
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2007-03-10 15:50 UTC (permalink / raw)
  To: Mark A. Hershberger; +Cc: emacs-devel

    Question: Is this sufficiently short/different/obvious that it doesn't
    require a copyright assignment?

It does, but since you have signed an assignment, why do you ask?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: eshell ansi colors, copyright q
  2007-03-10 15:50 ` Richard Stallman
@ 2007-03-11  1:51   ` Mark A. Hershberger
  2007-03-11 20:01     ` Richard Stallman
  0 siblings, 1 reply; 6+ messages in thread
From: Mark A. Hershberger @ 2007-03-11  1:51 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

Richard Stallman <rms@gnu.org> writes:

>     Question: Is this sufficiently short/different/obvious that it doesn't
>     require a copyright assignment?
>
> It does, but since you have signed an assignment, why do you ask?

Maybe I wasn't clear?  I wasn't concerned about my the diff I
created.  I was trying to understand if the diff I created was ok to
commit even though I had based it off of a snippet that I found on
emacswiki.

That is, would I have to track down the emacswiki contributor, or was
my diff sufficiently different that I could just commit the code?

-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: eshell ansi colors, copyright q
  2007-03-11  1:51   ` Mark A. Hershberger
@ 2007-03-11 20:01     ` Richard Stallman
  2007-03-11 21:36       ` Mark A. Hershberger
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Stallman @ 2007-03-11 20:01 UTC (permalink / raw)
  To: Mark A. Hershberger; +Cc: emacs-devel

      I was trying to understand if the diff I created was ok to
    commit even though I had based it off of a snippet that I found on
    emacswiki.

Now I understand.  (I had no idea, before, that you had not written
the code.)

The question is how much new or changed text you got from that snippet.
Can you show us?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: eshell ansi colors, copyright q
  2007-03-11 20:01     ` Richard Stallman
@ 2007-03-11 21:36       ` Mark A. Hershberger
  2007-03-12  4:24         ` Richard Stallman
  0 siblings, 1 reply; 6+ messages in thread
From: Mark A. Hershberger @ 2007-03-11 21:36 UTC (permalink / raw)
  To: emacs-devel; +Cc: Richard M. Stallman

Richard Stallman <rms@gnu.org> writes:

> The question is how much new or changed text you got from that snippet.
> Can you show us?

On the wiki (http://www.emacswiki.org/cgi-bin/wiki/EshellColor):

    (defun eshell-handle-ansi-color ()
      (ansi-color-apply-on-region eshell-last-output-start
                                  eshell-last-output-end))
    (add-to-list 'eshell-output-filter-functions 'eshell-handle-ansi-color)

In my diff:

   (defun eshell-handle-ansi-color ()
     (ansi-color-apply-on-region eshell-last-output-start
                                 eshell-last-output-end))

   (custom-add-option 'eshell-output-filter-functions
                      'eshell-handle-ansi-color)

So, 3 identical lines and 1ish different one.  I'm not sure how the code
could be done differently, unless I was to change the name of the
function.

Mark.

-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: eshell ansi colors, copyright q
  2007-03-11 21:36       ` Mark A. Hershberger
@ 2007-03-12  4:24         ` Richard Stallman
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Stallman @ 2007-03-12  4:24 UTC (permalink / raw)
  To: Mark A. Hershberger; +Cc: emacs-devel

    So, 3 identical lines and 1ish different one.

Don't worry about it.  4 lines isn't enough to matter.
We can treat this patch as yours.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-03-12  4:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-09 17:26 eshell ansi colors, copyright q Mark A. Hershberger
2007-03-10 15:50 ` Richard Stallman
2007-03-11  1:51   ` Mark A. Hershberger
2007-03-11 20:01     ` Richard Stallman
2007-03-11 21:36       ` Mark A. Hershberger
2007-03-12  4:24         ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.