[david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Richard Stallman]

Would someone please DTRT, then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE,
	UNPARSEABLE_RELAY autolearn=no version=3.1.0
From: David Hansen <david.hansen@physik.fu-berlin.de>
To: emacs-pretest-bug@gnu.org
Organization: disorganized
Date: Wed, 07 Mar 2007 14:58:34 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: partial-completion-mode and Info-menu


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello,

note that this one seems to be *not* related to the other
patial-completion-mode bug\|misfeature i reported.

Here is how to reproduce:

$ emacs -Q

M-x partial-completion-mode RET

C-h i

m Dired-X RET ;; any node with a `-' in its name seems to work

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p t)
  PC-do-completion(exit)
  PC-do-complete-and-exit()
  PC-complete-and-exit()
  call-interactively(PC-complete-and-exit)
  completing-read("Menu item: " Info-complete-menu-item nil t)
  (let ((completion-ignore-case t) (Info-complete-menu-buffer ...)) (completing-read (if default ... "Menu item: ") (quote Info-complete-menu-item) nil t))
  (setq item (let (... ...) (completing-read ... ... nil t)))
  (while (null item) (setq item (let ... ...)) (if (string= item "") (if default ... ...)))
  (let ((item nil)) (while (null item) (setq item ...) (if ... ...)) (list item current-prefix-arg))
  (let ((completions ...) (default nil) (p ...) beg (last nil) (case-fold-search t)) (save-excursion (goto-char ...) (if ... ...) (setq beg ...) (and ... ...)) (let (...) (while ... ... ...) (list item current-prefix-arg)))
  call-interactively(Info-menu)


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/dhansen/share/emacs/22.0.95/etc/DEBUG for instructions.


In GNU Emacs 22.0.95.3 (i686-pc-linux-gnu, X toolkit)
 of 2007-03-07 on robotron
X server distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=/home/dhansen' '--disable-pop' '--with-xtookit=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Info

Minor modes in effect:
  erc-menu-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  partial-completion-mode: t
  TeX-PDF-mode: t
  jabber-activity-mode: t
  erc-services-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-smiley-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  erc-scrolltobottom-mode: t
  which-function-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  abbrev-mode: 1

Recent input:
1 C-c C-c y C-z C-n M-> c p SPC l i s <tab> SPC <backspace> 
/ c o m <tab> p l <tab> e . <tab> * SPC ~ / s h <tab> 
e m <tab> 2 2 <tab> l i <tab> c o m <tab> p l <tab> 
e <tab> <M-backspace> <M-backspace> <return> C-p C-e 
c o m <tab> o <backspace> p l <tab> . <backspace> e 
<tab> C-a C-M-k C-M-k g z i p SPC <return> y <return> 
<switch-frame> <switch-frame> <switch-frame> C-x b 
C-g M-x r e p <tab> o <tab> r <tab> b u <tab> <ret
urn>

Recent messages:
Mark set
Partially completed
Hit space to flush
Partially completed [2 times]
Hit space to flush
Partially completed [2 times]
Hit space to flush
Partially completed [2 times]
Quit
Loading emacsbug...done


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Glenn Morris]

Richard Stallman wrote:

> Would someone please DTRT, then ack?
>
> From: David Hansen <david.hansen@physik.fu-berlin.de>
> Subject: partial-completion-mode and Info-menu

I believe the patch presented by Martin Rudalics in the thread "EVAL
and mouse selection in *Completion" will fix this issue as well. This
one comes from the first call to try-completion in PC-do-completion
returning t, resulting in a call `(insert t)'.

Patch is here:
http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00389.html

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Richard Stallman]

    I believe the patch presented by Martin Rudalics in the thread "EVAL
    and mouse selection in *Completion" will fix this issue as well.

That has been installed, I think.  So this should be fixed.

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[David Hansen]

On Thu, 08 Mar 2007 16:47:46 -0500 Richard Stallman wrote:

>     I believe the patch presented by Martin Rudalics in the thread "EVAL
>     and mouse selection in *Completion" will fix this issue as well.
>
> That has been installed, I think.  So this should be fixed.

I still get the error:

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p t)
  PC-do-completion(exit)
  PC-do-complete-and-exit()
  PC-complete-and-exit()
  call-interactively(PC-complete-and-exit)
  completing-read("Menu item: " Info-complete-menu-item nil t)
  (let ((completion-ignore-case t) (Info-complete-menu-buffer ...)) (completing-read (if default ... "Menu item: ") (quote Info-complete-menu-item) nil t))
  (setq item (let (... ...) (completing-read ... ... nil t)))
  (while (null item) (setq item (let ... ...)) (if (string= item "") (if default ... ...)))
  (let ((item nil)) (while (null item) (setq item ...) (if ... ...)) (list item current-prefix-arg))
  (let ((completions ...) (default nil) (p ...) beg (last nil) (case-fold-search t)) (save-excursion (goto-char ...) (if ... ...) (setq beg ...) (and ... ...)) (let (...) (while ... ... ...) (list item current-prefix-arg)))
  call-interactively(Info-menu)

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[martin rudalics]

>>That has been installed, I think.  So this should be fixed.
> 
> 
> I still get the error:

I just installed it, please try again.

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Glenn Morris]

martin rudalics wrote:

>>>That has been installed, I think.  So this should be fixed.
>> I still get the error:
>
> I just installed it, please try again.

I think you failed to change the relevant try-completion call; I just
did so.

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[martin rudalics]

> I think you failed to change the relevant try-completion call; I just
> did so.

I completely ignored that Chong added another call here.  Thanks a lot
for spotting and fixing this.

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[David Hansen]

On Fri, 09 Mar 2007 04:00:32 -0500 Glenn Morris wrote:

> martin rudalics wrote:
>
>>>>That has been installed, I think.  So this should be fixed.
>>> I still get the error:
>>
>> I just installed it, please try again.
>
> I think you failed to change the relevant try-completion call; I just
> did so.

Works now, thanks.

David

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Glenn Morris]

Martin, it seems we still need the part of your patch that stops
partial-completion erasing the buffer contents:


*** complete.el    9 Mar 2007 09:00:59 -0000 1.65
--- complete.el    10 Mar 2007 03:04:50 -0000
***************
*** 417,423 ****
     (pred minibuffer-completion-predicate)
      (filename (funcall PC-completion-as-file-name-predicate))
       (dirname nil)        ; non-nil only if a filename is being
       completed
!       (dirlength 0)
         (str (buffer-substring beg end))
          (incname (and filename (string-match "<\\([^\"<>]*\\)>?$"
          str)))
           (ambig nil)
--- 417,423 ----
     (pred minibuffer-completion-predicate)
      (filename (funcall PC-completion-as-file-name-predicate))
       (dirname nil)        ; non-nil only if a filename is being
       completed
!       dirlength
         (str (buffer-substring beg end))
          (incname (and filename (string-match "<\\([^\"<>]*\\)>?$"
          str)))
           (ambig nil)

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[martin rudalics]

> Martin, it seems we still need the part of your patch that stops
> partial-completion erasing the buffer contents:

Honestly I didn't understand whether Chong's patch was supposed to
fix this.  Since binding dirlength to nil should not cause any
problems I checked it in.  Maybe you could have another look.

Re: [david.hansen@physik.fu-berlin.de: partial-completion-mode and Info-menu]

[Glenn Morris]

martin rudalics wrote:

>> Martin, it seems we still need the part of your patch that stops
>> partial-completion erasing the buffer contents:
>
> Honestly I didn't understand whether Chong's patch was supposed to
> fix this.  

Me neither. But it wasn't working before, the old code was obviously
wrong when not completing a filename, and it is working now. Good
enough for me. :)