bs--up not to be interactive.

bs--up not to be interactive.

[Michaël Cadilhac]

[-- Attachment #1.1.1: Type: text/plain, Size: 81 bytes --]

I can't see why bs--up should be interactive.

Should I install the following ?


[-- Attachment #1.1.2: bs.patch --]
[-- Type: text/x-patch, Size: 1043 bytes --]

Index: lisp/bs.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/bs.el,v
retrieving revision 1.30
diff -c -r1.30 bs.el
*** lisp/bs.el	10 Nov 2006 01:34:35 -0000	1.30
--- lisp/bs.el	20 Dec 2006 15:01:16 -0000
***************
*** 999,1005 ****
  (defun bs--up ()
    "Move cursor vertically up one line.
  If on top of buffer list go to last line."
-   (interactive "p")
    (if (> (count-lines 1 (point)) bs-header-lines-length)
        (forward-line -1)
      (goto-char (point-max))
--- 999,1004 ----
Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.10462
diff -C0 -r1.10462 ChangeLog
*** lisp/ChangeLog	20 Dec 2006 05:57:40 -0000	1.10462
--- lisp/ChangeLog	20 Dec 2006 15:01:28 -0000
***************
*** 0 ****
--- 1,4 ----
+ 2006-12-20  Michaël Cadilhac  <michael.cadilhac@lrde.org>
+ 
+ 	* bs.el (bs--up): Remove the `interactive' part.
+ 

[-- Attachment #1.1.3: Type: text/plain, Size: 411 bytes --]


TIA!

-- 
/!\ My mail address has changed, please update your files accordingly.
 |      Michaël `Micha' Cadilhac     |  Would someone please DTRT with this,  |
 |         Epita/LRDE Promo 2007     |        then ACK?                       |
 |  http://michael.cadilhac.name     |          -- Richard Stallman           |
 `--JID: michael.cadilhac@gmail.com--'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: bs--up not to be interactive.

[Juanma Barranquero]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On 12/20/06, Michaël Cadilhac <michael@cadilhac.name> wrote:

> I can't see why bs--up should be interactive.

I think it's leftover code.

> Should I install the following ?

Probably.

BTW, a more standard description for the ChangeLog would be "Remove
interactive spec.", at least according to previous ChangeLog entries
documenting that fact.

                    /L/e/k/t/u

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: bs--up not to be interactive.

[Richard Stallman]

I think you are right.

Re: bs--up not to be interactive.

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 910 bytes --]

michael@cadilhac.name (Michaël Cadilhac) writes:

> I can't see why bs--up should be interactive.
>
> Should I install the following ?
>
> --- lisp/bs.el	20 Dec 2006 15:01:16 -0000
> ***************
> *** 999,1005 ****
>   (defun bs--up ()
>     "Move cursor vertically up one line.
>   If on top of buffer list go to last line."
> -   (interactive "p")
>     (if (> (count-lines 1 (point)) bs-header-lines-length)
>         (forward-line -1)
>       (goto-char (point-max))


Installed.

-- 
/!\ My mail address has changed, please update your files accordingly.
 |      Michaël `Micha' Cadilhac     |  (\(\  This is the cute bunny virus,   |
 |         Epita/LRDE Promo 2007     |  (^.^)  please copy this into your     |
 |  http://michael.cadilhac.name     |  (")")  sig so it can spread.          |
 `--JID: michael.cadilhac@gmail.com--'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel