all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* string-to-char
@ 2006-11-27  9:51 martin rudalics
  2006-11-27 10:52 ` string-to-char Juanma Barranquero
  2006-11-27 13:38 ` string-to-char Stefan Monnier
  0 siblings, 2 replies; 11+ messages in thread
From: martin rudalics @ 2006-11-27  9:51 UTC (permalink / raw)


 From the Elisp manual on `string-to-char':

      This function may be eliminated in the future if it does not seem
      useful enough to retain.

Given that some 60 files of current Emacs use `string-to-char' these
lines appear incongruous and should be eliminated.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27  9:51 string-to-char martin rudalics
@ 2006-11-27 10:52 ` Juanma Barranquero
  2006-11-27 19:32   ` string-to-char Nick Roberts
                     ` (2 more replies)
  2006-11-27 13:38 ` string-to-char Stefan Monnier
  1 sibling, 3 replies; 11+ messages in thread
From: Juanma Barranquero @ 2006-11-27 10:52 UTC (permalink / raw)
  Cc: emacs-devel

On 11/27/06, martin rudalics <rudalics@gmx.at> wrote:

> Given that some 60 files of current Emacs use `string-to-char'

And some of those uses are quite weird, BTW:

 - In erc/erc.el:
    (separator (make-string erc-fill-column (string-to-char "=")))
    (make-string (length x) (string-to-char "b"))

 - In progmodes/fortran.el:
    (or (equal char (string-to-char " "))

Aren't these redundant? (I don't think the unibyte/multibyte issue is
relevant in any of them...)

                    /L/e/k/t/u

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27  9:51 string-to-char martin rudalics
  2006-11-27 10:52 ` string-to-char Juanma Barranquero
@ 2006-11-27 13:38 ` Stefan Monnier
  1 sibling, 0 replies; 11+ messages in thread
From: Stefan Monnier @ 2006-11-27 13:38 UTC (permalink / raw)
  Cc: emacs-devel

>      This function may be eliminated in the future if it does not seem
>      useful enough to retain.

> Given that some 60 files of current Emacs use `string-to-char' these
> lines appear incongruous and should be eliminated.

I think (aref STR 0) is just as good.  And as someone else mentioned,
string-to-char is surprisingly often used in odd cases where the whole thing
could be completely removed.


        Stefan

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 10:52 ` string-to-char Juanma Barranquero
@ 2006-11-27 19:32   ` Nick Roberts
  2006-11-27 20:13     ` string-to-char Juanma Barranquero
  2006-11-27 23:43   ` string-to-char Richard Stallman
  2006-11-28  0:36   ` string-to-char Glenn Morris
  2 siblings, 1 reply; 11+ messages in thread
From: Nick Roberts @ 2006-11-27 19:32 UTC (permalink / raw)
  Cc: martin rudalics, emacs-devel

 > And some of those uses are quite weird, BTW:
 > 
 >  - In erc/erc.el:
 >     (separator (make-string erc-fill-column (string-to-char "=")))
 >     (make-string (length x) (string-to-char "b"))
 > 
 >  - In progmodes/fortran.el:
 >     (or (equal char (string-to-char " "))
 > 
 > Aren't these redundant? (I don't think the unibyte/multibyte issue is
 > relevant in any of them...)

Very probably.  The problem with changing them and the large numbers of files
to which you are applying trivial fixes is that the code being pretested is no
longer that in the repository.  I think it's best to follow the adage: "If it
ain't broke then don't fix it.".  At least, until After The Release (TM).


-- 
Nick                                           http://www.inet.net.nz/~nickrob

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 19:32   ` string-to-char Nick Roberts
@ 2006-11-27 20:13     ` Juanma Barranquero
  2006-11-27 20:59       ` string-to-char Nick Roberts
  2006-11-29  3:28       ` string-to-char Richard Stallman
  0 siblings, 2 replies; 11+ messages in thread
From: Juanma Barranquero @ 2006-11-27 20:13 UTC (permalink / raw)
  Cc: emacs-devel

On 11/27/06, Nick Roberts <nickrob@snap.net.nz> wrote:

> Very probably.  The problem with changing them and the large numbers of files
> to which you are applying trivial fixes is that the code being pretested is no
> longer that in the repository.

Well, yeah, except that: 1) the changes I've done are really trivial
(you're right on that account) and it would be very surprising if they
broke something (and I'm assuming you're referring to the \s changes,
as the other are mostly doc fixes), and 2) the 22.0.91 pretest has not
been announced, AFAIK. At least, I'm in the pretester's list and
didn't receive any announce (I received one in the devel list). So I
don't think it's being tested, more or less than the CVS HEAD usually
is. I would not be doing changes if there were a public pretest.

                    /L/e/k/t/u

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 20:13     ` string-to-char Juanma Barranquero
@ 2006-11-27 20:59       ` Nick Roberts
  2006-11-29  3:28       ` string-to-char Richard Stallman
  1 sibling, 0 replies; 11+ messages in thread
From: Nick Roberts @ 2006-11-27 20:59 UTC (permalink / raw)
  Cc: emacs-devel

 >                              ... and 2) the 22.0.91 pretest has not
 > been announced, AFAIK. At least, I'm in the pretester's list and
 > didn't receive any announce (I received one in the devel list). So I
 > don't think it's being tested, more or less than the CVS HEAD usually
 > is. I would not be doing changes if there were a public pretest.

We're either in pretest or we're not.  It's been reported on LWN, reports
are coming in... so it seems pretty public.  Having a limbo state of quasi
pretest seems a bit meaningless to me.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 10:52 ` string-to-char Juanma Barranquero
  2006-11-27 19:32   ` string-to-char Nick Roberts
@ 2006-11-27 23:43   ` Richard Stallman
  2006-11-28  0:36   ` string-to-char Glenn Morris
  2 siblings, 0 replies; 11+ messages in thread
From: Richard Stallman @ 2006-11-27 23:43 UTC (permalink / raw)
  Cc: rudalics, emacs-devel

    And some of those uses are quite weird, BTW:

     - In erc/erc.el:
	(separator (make-string erc-fill-column (string-to-char "=")))
	(make-string (length x) (string-to-char "b"))

     - In progmodes/fortran.el:
	(or (equal char (string-to-char " "))

    Aren't these redundant? (I don't think the unibyte/multibyte issue is
    relevant in any of them...)

Please feel free to simplify them.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 10:52 ` string-to-char Juanma Barranquero
  2006-11-27 19:32   ` string-to-char Nick Roberts
  2006-11-27 23:43   ` string-to-char Richard Stallman
@ 2006-11-28  0:36   ` Glenn Morris
  2 siblings, 0 replies; 11+ messages in thread
From: Glenn Morris @ 2006-11-28  0:36 UTC (permalink / raw)
  Cc: martin rudalics, emacs-devel

"Juanma Barranquero" wrote:

> - In progmodes/fortran.el:
>    (or (equal char (string-to-char " "))

I'll get rid of that one, which as you say is unnecessary.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-27 20:13     ` string-to-char Juanma Barranquero
  2006-11-27 20:59       ` string-to-char Nick Roberts
@ 2006-11-29  3:28       ` Richard Stallman
  2006-11-29  9:09         ` string-to-char Juanma Barranquero
  1 sibling, 1 reply; 11+ messages in thread
From: Richard Stallman @ 2006-11-29  3:28 UTC (permalink / raw)
  Cc: nickrob, emacs-devel

I announced the pretest to the list of pretesters
but you are not on that list.  If you were on the list before,
you were removed, probably because of not responding when I asked you
if you wanted to remain on the list.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-29  3:28       ` string-to-char Richard Stallman
@ 2006-11-29  9:09         ` Juanma Barranquero
  2006-11-30  3:20           ` string-to-char Richard Stallman
  0 siblings, 1 reply; 11+ messages in thread
From: Juanma Barranquero @ 2006-11-29  9:09 UTC (permalink / raw)
  Cc: emacs-devel

On 11/29/06, Richard Stallman <rms@gnu.org> wrote:

> I announced the pretest to the list of pretesters
> but you are not on that list.  If you were on the list before,
> you were removed, probably because of not responding when I asked you
> if you wanted to remain on the list.

My sent-email folder on Gmail contains the attached e-mail. (You
wrote, I think, to lektu@terra.es, which is redirected to Gmail, so I
received it and answered it from my Gmail account).

                    /L/e/k/t/u


> X-Gmail-Received: 754ac04ec11b8e70f7732b69cd7f7236544771b2
> Received: by 10.82.136.11 with HTTP; Sun, 29 Oct 2006 10:49:32 -0800 (PST)
> Message-ID:
> <f7ccd24b0610291049o78903f71mff6468463193cd45@mail.gmail.com>
> Date: Sun, 29 Oct 2006 19:49:32 +0100
> From: "Juanma Barranquero" <lekktu@gmail.com>
> To: rms@gnu.org
> Subject: Re: Emacs pretesting (Juanma Barranquero <lektu@terra.es>)
> In-Reply-To: <E1GeFhO-0007zP-JS@fencepost.gnu.org>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8; format=flowed
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
> References: <E1GeFhO-0007zP-JS@fencepost.gnu.org>
> Delivered-To: lekktu@gmail.com
>
> On 10/29/06, Richard Stallman <rms@gnu.org> wrote:
> > If you are still interested in being on the Emacs pretest list,
> > would you please tell me?
>
> Yes, but please use the current e-mail: lekktu@gmail.com.
>
> --
>                     /L/e/k/t/u

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: string-to-char
  2006-11-29  9:09         ` string-to-char Juanma Barranquero
@ 2006-11-30  3:20           ` Richard Stallman
  0 siblings, 0 replies; 11+ messages in thread
From: Richard Stallman @ 2006-11-30  3:20 UTC (permalink / raw)
  Cc: emacs-devel

Perhaps the change in email address caused my script to think there
was no reply from you.  I put you back in the list.

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2006-11-30  3:20 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-27  9:51 string-to-char martin rudalics
2006-11-27 10:52 ` string-to-char Juanma Barranquero
2006-11-27 19:32   ` string-to-char Nick Roberts
2006-11-27 20:13     ` string-to-char Juanma Barranquero
2006-11-27 20:59       ` string-to-char Nick Roberts
2006-11-29  3:28       ` string-to-char Richard Stallman
2006-11-29  9:09         ` string-to-char Juanma Barranquero
2006-11-30  3:20           ` string-to-char Richard Stallman
2006-11-27 23:43   ` string-to-char Richard Stallman
2006-11-28  0:36   ` string-to-char Glenn Morris
2006-11-27 13:38 ` string-to-char Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.