From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: local keymap patch for key-binding Date: Wed, 13 Sep 2006 15:25:06 -0400 Message-ID: References: <87slj1hybl.fsf@stupidchicken.com> <85pse5cbqw.fsf@lola.goethe.zz> <87zmd7yjq4.fsf@furball.mit.edu> <85pse3n99c.fsf@lola.goethe.zz> <87r6yjxh7k.fsf@furball.mit.edu> <85venuc27c.fsf@lola.goethe.zz> <85r6yiivi7.fsf@lola.goethe.zz> <85hczdbdv2.fsf@lola.goethe.zz> <85mz959kkw.fsf@lola.goethe.zz> <85irjs4tda.fsf@lola.goethe.zz> <85ejug4pl4.fsf@lola.goethe.zz> <85k648kwy7.fsf@lola.goethe.zz> <85irjsj8s7.fsf@lola.goethe.zz> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1158175741 25787 80.91.229.2 (13 Sep 2006 19:29:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 13 Sep 2006 19:29:01 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 13 21:28:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GNaPf-0003qo-Mm for ged-emacs-devel@m.gmane.org; Wed, 13 Sep 2006 21:28:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNaPf-0007kT-6j for ged-emacs-devel@m.gmane.org; Wed, 13 Sep 2006 15:28:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GNaM8-00023k-TS for emacs-devel@gnu.org; Wed, 13 Sep 2006 15:25:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GNaM8-00022j-Al for emacs-devel@gnu.org; Wed, 13 Sep 2006 15:25:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNaM7-00022L-TZ for emacs-devel@gnu.org; Wed, 13 Sep 2006 15:25:08 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GNaNu-0000KK-G5 for emacs-devel@gnu.org; Wed, 13 Sep 2006 15:26:58 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1GNaM6-00084w-Om; Wed, 13 Sep 2006 15:25:06 -0400 Original-To: David Kastrup In-reply-to: <85irjsj8s7.fsf@lola.goethe.zz> (message from David Kastrup on Wed, 13 Sep 2006 13:38:48 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59796 Archived-At: There is one concern that I have: the type of the "location" argument. This currently is a key sequence. But it might make more sense to turn this into the "location" data structure that `event-start' and/or `event-end' return. This would make it much easier to feed lookup-key with data produced from, say, `posn-at-x-y'. That seems like a good idea. (We call that a "position".) In order to get this data easier, it might make sense to define a convenience function. (defun key-event (key) "Return event from moused-base key sequence KEY." (and (vectorp key) (if (consp (aref key 0)) (aref key 0) (and (symbolp (aref key 0)) (> (length key) 1) (consp (aref key 1)) (aref key 1))))) I have nothing against it, but do we really need it? Is there a place that needs to call this, outside of the code of Fkey_binding itself?