[Patch] rmail-get-new-mail: say if all messages are spam

[Patch] rmail-get-new-mail: say if all messages are spam

[Diane Murray]

Included is a patch to rmail.el which changes the message that shows
how many new messages were read, making it state clearly if all
messages were found to be spam when using the rmail-spam-filter.  The
way it works now, it is possible to miss seeing both numbers before
the message goes away and then wonder how many messages *weren't*
spam.


	* mail/rmail.el (rmail-get-new-mail): If all the messages are
	found to be spam say "all" instead of showing the number.


Index: rmail.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.426
diff -c -r1.426 rmail.el
*** rmail.el	20 May 2006 17:36:07 -0000	1.426
--- rmail.el	4 Sep 2006 00:06:19 -0000
***************
*** 1677,1688 ****
  			 (if (and (featurep 'rmail-spam-filter)
  				  rmail-use-spam-filter
  				  (> rsf-number-of-spam 0))
! 			     (if (= 1 new-messages)
! 				 ", and found to be a spam message"
! 			       (if (> rsf-number-of-spam 1)
! 				   (format ", %d of which found to be spam messages"
! 					   rsf-number-of-spam)
! 				 ", one of which found to be a spam message"))
  			   ""))
  		(if (and (featurep 'rmail-spam-filter)
  			 rmail-use-spam-filter
--- 1677,1691 ----
  			 (if (and (featurep 'rmail-spam-filter)
  				  rmail-use-spam-filter
  				  (> rsf-number-of-spam 0))
! 			     (cond ((= 1 new-messages)
! 				    ", and found to be a spam message")
! 				   ((= 1 rsf-number-of-spam)
! 				    ", one of which found to be a spam message")
! 				   ((= new-messages rsf-number-of-spam)
! 				    ", all found to be spam messages")
! 				   (t
! 				    (format ", %d of which found to be spam messages"
! 					    rsf-number-of-spam)))
  			   ""))
  		(if (and (featurep 'rmail-spam-filter)
  			 rmail-use-spam-filter

Re: [Patch] rmail-get-new-mail: say if all messages are spam

[Richard Stallman]

I will make a change like this, but I wonder if some other change is
needed too.  Since the default for rsf-sleep-after-message is 2.0,
that means the message will appear for 2 seconds.  Do you find that
insufficient?

Re: [Patch] rmail-get-new-mail: say if all messages are spam

[Diane Murray]

Richard Stallman <rms@gnu.org> wrote:

> I will make a change like this, but I wonder if some other change is
> needed too.  Since the default for rsf-sleep-after-message is 2.0,
> that means the message will appear for 2 seconds.  Do you find that
> insufficient?

I never noticed that the message went away too quickly.  The message
actually remains there indefinitely until I make it go away by moving
something (I just tested it to make sure).  I guess it has more to do
with the amount and type of concentration on the message that's
displayed - I usually just pay more attention to the number of spam
messages found.  So I think changing the message to say "all found to
be spam" should be enough.