From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Changing of line format and undo
Date: Wed, 23 Aug 2006 00:06:08 -0400
Message-ID: <E1GFk0G-0005cP-EX@fencepost.gnu.org>
References: <44987375.2010000@student.lu.se> <u3bdz2nv8.fsf@gnu.org>
	<449961F6.6020001@student.lu.se> <85mzc6y204.fsf@lola.goethe.zz>
	<44996AE1.7020907@student.lu.se> <858xnqxyg9.fsf@lola.goethe.zz>
	<4499781F.7090802@student.lu.se>
	<87k66wvx4u.fsf-monnier+emacs@gnu.org>
	<m3y7tip3ir.fsf@kfs-l.imdomain.dk>
	<E1GFQtv-0000CM-2L@fencepost.gnu.org>
	<m38xlh3yva.fsf@kfs-l.imdomain.dk> <m33bbp3y8k.fsf@kfs-l.imdomain.dk>
Reply-To: rms@gnu.org
NNTP-Posting-Host: main.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: sea.gmane.org 1156305986 15881 80.91.229.2 (23 Aug 2006 04:06:26 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 23 Aug 2006 04:06:26 +0000 (UTC)
Cc: lennart.borgman.073@student.lu.se, eliz@gnu.org, monnier@iro.umontreal.ca,
	emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 23 06:06:24 2006
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1GFk0U-0001yj-Uh
	for ged-emacs-devel@m.gmane.org; Wed, 23 Aug 2006 06:06:23 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1GFk0U-0008HS-9h
	for ged-emacs-devel@m.gmane.org; Wed, 23 Aug 2006 00:06:22 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GFk0J-0008Gf-8U
	for emacs-devel@gnu.org; Wed, 23 Aug 2006 00:06:11 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GFk0I-0008G1-Lp
	for emacs-devel@gnu.org; Wed, 23 Aug 2006 00:06:10 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GFk0I-0008Fy-GT
	for emacs-devel@gnu.org; Wed, 23 Aug 2006 00:06:10 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GFk83-0005Mr-4r
	for emacs-devel@gnu.org; Wed, 23 Aug 2006 00:14:11 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1GFk0G-0005cP-EX; Wed, 23 Aug 2006 00:06:08 -0400
Original-To: storm@cua.dk (Kim F. Storm)
In-reply-to: <m33bbp3y8k.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:58755
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/58755>

    BTW, this change does not fix the original problem of recording undo
    information for changing line endings; it only addresses undo for
    multibyte.

set-buffer-multibyte changes the buffer contents, so it ought to be
undoable.  Changing buffer-file-coding-system does not change the buffer
contents, so I am not sure it ought to be undoable.  It only affects
how the buffer will be saved.  set-visited-file-name also affects
how the buffer will be saved, and we did not make it undoable.

I am not convinced it is correct to try to make undo cover changes
in how the buffer would be saved.