From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: two related edebug problems Date: Sat, 12 Aug 2006 17:50:17 -0400 Message-ID: References: <2cd46e7f0608071130o7d72123ct82841031bf757f5d@mail.gmail.com> <2cd46e7f0608081226o63f2a0d5q9e79575021d0a181@mail.gmail.com> <873bc4k1yl.fsf@furball.mit.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1155419466 19246 80.91.229.2 (12 Aug 2006 21:51:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2006 21:51:06 +0000 (UTC) Cc: cyd@stupidchicken.com, ken.manheimer@gmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 12 23:51:04 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GC1Nd-00022B-4S for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2006 23:50:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GC1Nb-0002ns-4Q for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2006 17:50:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GC1N5-0002Jf-PU for emacs-devel@gnu.org; Sat, 12 Aug 2006 17:50:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GC1N4-0002Hr-NU for emacs-devel@gnu.org; Sat, 12 Aug 2006 17:50:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GC1N4-0002HV-HR for emacs-devel@gnu.org; Sat, 12 Aug 2006 17:50:18 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GC1SW-0003A7-4T for emacs-devel@gnu.org; Sat, 12 Aug 2006 17:55:56 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1GC1N3-0006tH-Ks; Sat, 12 Aug 2006 17:50:17 -0400 Original-To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 11 Aug 2006 18:34:29 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58337 Archived-At: > I found out the cause of the bug. edebug-display calls sit-for to > pause before displaying eval results, then calls > edebug-recursive-edit. However, edebug-recursive-edit rebinds > unread-command-events, causing sit-for interruptions (which are put > into unread-command-events) to go unnoticed. This creates problems > when you type in edebug commands in quick succession. I fixed this by > moving the rebinding of unread-command-events to edebug-display. This is a workaround rather than a fix. A real fix would be to change sit-for so it doesn't use unread-command-events but an internal variable instead with which other code can't mess. I disagree. unread-command-events is defined to do what it does. If Lisp code sets it to nil, that gets rid of the pending events. If Lisp code later sets it back to something non-nil, that restores them. If the result of doing that isn't what you want, you should not do that.