all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
Cc: eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: safe_call1 considered harmful
Date: Sun, 30 Jul 2006 18:18:48 +0900	[thread overview]
Message-ID: <E1G77Rg-0000dD-00@etlken> (raw)
In-Reply-To: <E1G5548-0002HD-8x@fencepost.gnu.org> (message from Richard Stallman on Mon, 24 Jul 2006 14:22:04 -0400)

In article <E1G5548-0002HD-8x@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

>     find-operation-coding-system calls a registered function
>     with a single argument; a list of arguments given to
>     find-operation-coding-system.  So, appending an extra
>     argument at the tail of the list is fairly safe.

> It might seem that way; but what happens if we change the calling
> convention of one of the operations, giving it an additional argument?
> That may be necessary some day.  I prefer the current convention.

We can change tar-mode/arc-mode/jka-compr to call
find-operation-coding-system with full number of arguments
plus the extra argument BUFFER.  Then, a function called
from find-operation-coding-system can check if the number of
arguments is greater than the normal number (which can be
checked by subr-arity).  If it is greater, the function can
know that the last argument is BUFFER.  By that way, the
function doesn't break even if we add a new argument to
find-operation-coding-system.

---
Kenichi Handa
handa@m17n.org

  reply	other threads:[~2006-07-30  9:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-21  9:36 safe_call1 considered harmful Eli Zaretskii
2006-07-21 11:34 ` Kenichi Handa
2006-07-21 15:49   ` Eli Zaretskii
2006-07-24  1:36     ` Kenichi Handa
2006-07-29 11:00       ` Eli Zaretskii
2006-07-31  3:04         ` Kenichi Handa
2006-07-21 19:37   ` Richard Stallman
2006-07-24  1:44     ` Kenichi Handa
2006-07-24 18:22       ` Richard Stallman
2006-07-30  9:18         ` Kenichi Handa [this message]
2006-07-31  4:38           ` Richard Stallman
2006-07-31  5:14             ` Kenichi Handa
2006-07-31 22:16               ` Richard Stallman
2006-08-01  0:50                 ` Kenichi Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1G77Rg-0000dD-00@etlken \
    --to=handa@m17n.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.