all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] help-mode.el
@ 2006-07-21  6:04 Nick Roberts
  2006-07-21 19:36 ` Richard Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Roberts @ 2006-07-21  6:04 UTC (permalink / raw)



If help can't find the location in a file, how about a message explaining
this to the user?

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** help-mode.el	13 Jul 2006 20:31:48 +1200	1.49
--- help-mode.el	21 Jul 2006 18:01:01 +1200	
*************** The format is (FUNCTION ARGS...).")
*** 157,164 ****
  		   (let ((location
  			  (find-function-search-for-symbol fun nil file)))
  		     (pop-to-buffer (car location))
! 		     (when (cdr location)
! 		       (goto-char (cdr location)))))
    'help-echo (purecopy "mouse-2, RET: find function's definition"))
  
  (define-button-type 'help-variable-def
--- 157,165 ----
  		   (let ((location
  			  (find-function-search-for-symbol fun nil file)))
  		     (pop-to-buffer (car location))
! 		     (if (cdr location)
! 			 (goto-char (cdr location))
! 		       (message "Unable to find location in file"))))
    'help-echo (purecopy "mouse-2, RET: find function's definition"))
  
  (define-button-type 'help-variable-def
*************** The format is (FUNCTION ARGS...).")
*** 168,175 ****
  		     (setq file (help-C-file-name var 'var)))
  		   (let ((location (find-variable-noselect var file)))
  		     (pop-to-buffer (car location))
! 		     (when (cdr location)
! 		       (goto-char (cdr location)))))
    'help-echo (purecopy "mouse-2, RET: find variable's definition"))
  
  (define-button-type 'help-face-def
--- 169,177 ----
  		     (setq file (help-C-file-name var 'var)))
  		   (let ((location (find-variable-noselect var file)))
  		     (pop-to-buffer (car location))
! 		     (if (cdr location)
! 		       (goto-char (cdr location))
! 		       (message "Unable to find location in file"))))
    'help-echo (purecopy "mouse-2, RET: find variable's definition"))
  
  (define-button-type 'help-face-def
*************** The format is (FUNCTION ARGS...).")
*** 181,188 ****
  		   (let ((location
  			  (find-function-search-for-symbol fun 'defface file)))
  		     (pop-to-buffer (car location))
! 		     (when (cdr location)
! 		       (goto-char (cdr location)))))
    'help-echo (purecopy "mouse-2, RET: find face's definition"))
  
  \f
--- 183,191 ----
  		   (let ((location
  			  (find-function-search-for-symbol fun 'defface file)))
  		     (pop-to-buffer (car location))
! 		     (if (cdr location)
! 			 (goto-char (cdr location))
! 		       (message "Unable to find location in file"))))
    'help-echo (purecopy "mouse-2, RET: find face's definition"))
  
  \f

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] help-mode.el
  2006-07-21  6:04 [PATCH] help-mode.el Nick Roberts
@ 2006-07-21 19:36 ` Richard Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2006-07-21 19:36 UTC (permalink / raw)
  Cc: emacs-devel

Ok, please install.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-21 19:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-21  6:04 [PATCH] help-mode.el Nick Roberts
2006-07-21 19:36 ` Richard Stallman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.