From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: safe_call1 considered harmful Date: Fri, 21 Jul 2006 20:34:16 +0900 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1153481726 29119 80.91.229.2 (21 Jul 2006 11:35:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Jul 2006 11:35:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 21 13:35:23 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G3tHt-0004nZ-0A for ged-emacs-devel@m.gmane.org; Fri, 21 Jul 2006 13:35:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G3tHs-0004xm-Gt for ged-emacs-devel@m.gmane.org; Fri, 21 Jul 2006 07:35:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G3tHg-0004xf-Uq for emacs-devel@gnu.org; Fri, 21 Jul 2006 07:35:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G3tHe-0004xR-LM for emacs-devel@gnu.org; Fri, 21 Jul 2006 07:35:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G3tHe-0004xO-GK for emacs-devel@gnu.org; Fri, 21 Jul 2006 07:35:06 -0400 Original-Received: from [150.29.246.133] (helo=mx1.aist.go.jp) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G3tI0-0004T3-J3; Fri, 21 Jul 2006 07:35:29 -0400 Original-Received: from smtp3.aist.go.jp ([150.29.246.12]) by mx1.aist.go.jp with ESMTP id k6LBYvmH000672; Fri, 21 Jul 2006 20:34:57 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id k6LBYu8T018339; Fri, 21 Jul 2006 20:34:56 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1G3tGq-0006Z3-00; Fri, 21 Jul 2006 20:34:16 +0900 Original-To: Eli Zaretskii In-reply-to: (message from Eli Zaretskii on Fri, 21 Jul 2006 12:36:48 +0300) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57425 Archived-At: In article , Eli Zaretskii writes: > The change below was presumably made to avoid errors in functions that > are put on the various *-coding-system-alist variables. Those errors > might have been caused by the recent changes in several modes that now > use a cons cell `(FILENAME . BUFFER)' instead of just the file name as > the argument to find-operation-coding-system (when the operation is > insert-file-contents), because some packages put functions on the > file-coding-system-alist that are not ready for the cons cell. > I think the change in coding.c is for the worse: it masks such > problems from us, so instead of seeing bug reports, we sweep the > problems under the carpet, where they run risk to be left undetected > until after the release. > A case in point is the function find-buffer-file-type-coding-system > that dos-w32.el adds to file-coding-system-alist: it was not modified > to support the change in the find-operation-coding-system's interface, > and caused files with DOS EOLs uncompressed from archives to be shown > with the ^M characters. This happened because > find-buffer-file-type-coding-system throws an error, but safe_call1 > silently ignores it. > So how about if we undo the change below? Ah, hmmm, I didn't think about such a situation. The change was to avoid the backward incompatiblity reported by the attached mail. But, by considering this problem again, I found another solution than calling find-operation-coding-system with (FILENAME . BUFFER). That is to provide an extra argument BUFFER. Then, we can keep backward compatibility and find-buffer-file-type-coding-system works as before, and, by modifying po-find-file-coding-system to check that extra argument instead of checking if FILENAME is cons or not, we can make it work well too. Do I still miss something? If not, I'll try to change the current code along that line. --- Kenichi Handa handa@m17n.org Date: Sun, 28 May 2006 10:23:16 +0200 From: Sven Joachim MIME-Version: 1.0 To: Kenichi Handa In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: emacs-pretest-bug@gnu.org Subject: Re: Coding system of compressed PO files is not recognized X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.3 Kenichi Handa wrote: > Do you mean that, po-compat.el was able to detect a coding > system of compressed PO file correctly before my change? No, it wasn't. But at least it was able to visit the file without getting an error. ;-) _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug