[cyd@stupidchicken.com: Re: [johnsu01@wjsullivan.net: C-n doesn't work in Customize Option buffer in -nw with long value displayed]]

[cyd@stupidchicken.com: Re: [johnsu01@wjsullivan.net: C-n doesn't work in Customize Option buffer in -nw with long value displayed]]

[Richard Stallman]

Could you please study this proposed change and comment?
We need the help of your expertise to do a good job.


------- Start of forwarded message -------
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: [johnsu01@wjsullivan.net: C-n doesn't work in Customize Option buffer in -nw with long value displayed]
From: Chong Yidong <cyd@stupidchicken.com>
Date: Tue, 18 Jul 2006 10:22:17 -0400
In-Reply-To: <E1G2dDM-000176-Pi@fencepost.gnu.org> (Richard Stallman's message of "Mon, 17 Jul 2006 20:13:28 -0400")
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

> From: johnsu01 <johnsu01@wjsullivan.net>
> Subject: C-n doesn't work in Customize Option buffer in -nw with long value
> 	displayed
>
> M-x customize-variable RET gnus-summary-line-format RET
>
> Make sure the value is displayed (so the button now says Hide Value). With
> point on the "Gnus Summary Line Format" (or on the value button itself), hit
> C-n. The cursor won't move.

The bug occurs because `line-beginning-position' and
`line-end-position' respect field boundaries, but `move-to-column'
doesn't.  The following change to `line-move-to-column' should fix
this problem, but it would be nice if someone could check to make sure
it won't get point stuck in other situations.

*** emacs/lisp/simple.el.~1.809.~	2006-07-15 09:34:18.000000000 -0400
- --- emacs/lisp/simple.el	2006-07-18 10:20:19.000000000 -0400
***************
*** 3695,3703 ****
  This function works only in certain cases,
  because what we really need is for `move-to-column'
  and `current-column' to be able to ignore invisible text."
!   (if (zerop col)
!       (beginning-of-line)
!     (move-to-column col))
  
    (when (and line-move-ignore-invisible
  	     (not (bolp)) (line-move-invisible-p (1- (point))))
- --- 3695,3705 ----
  This function works only in certain cases,
  because what we really need is for `move-to-column'
  and `current-column' to be able to ignore invisible text."
!   (let ((opoint (point)))
!     (if (zerop col)
! 	(beginning-of-line)
!       (move-to-column col))
!     (goto-char (constrain-to-field (point) opoint)))
  
    (when (and line-move-ignore-invisible
  	     (not (bolp)) (line-move-invisible-p (1- (point))))
------- End of forwarded message -------

[cyd@stupidchicken.com: Re: [johnsu01@wjsullivan.net: C-n doesn't work in Customize Option buffer in -nw with long value displayed]]

[Richard Stallman]

[I sent this message a week ago but did not get a response.]

Could you please study this proposed change and comment?
We need the help of your expertise to do a good job.


------- Start of forwarded message -------
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: [johnsu01@wjsullivan.net: C-n doesn't work in Customize Option buffer in -nw with long value displayed]
From: Chong Yidong <cyd@stupidchicken.com>
Date: Tue, 18 Jul 2006 10:22:17 -0400
In-Reply-To: <E1G2dDM-000176-Pi@fencepost.gnu.org> (Richard Stallman's message of "Mon, 17 Jul 2006 20:13:28 -0400")
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

> From: johnsu01 <johnsu01@wjsullivan.net>
> Subject: C-n doesn't work in Customize Option buffer in -nw with long value
> 	displayed
>
> M-x customize-variable RET gnus-summary-line-format RET
>
> Make sure the value is displayed (so the button now says Hide Value). With
> point on the "Gnus Summary Line Format" (or on the value button itself), hit
> C-n. The cursor won't move.

The bug occurs because `line-beginning-position' and
`line-end-position' respect field boundaries, but `move-to-column'
doesn't.  The following change to `line-move-to-column' should fix
this problem, but it would be nice if someone could check to make sure
it won't get point stuck in other situations.

*** emacs/lisp/simple.el.~1.809.~	2006-07-15 09:34:18.000000000 -0400
- --- emacs/lisp/simple.el	2006-07-18 10:20:19.000000000 -0400
***************
*** 3695,3703 ****
  This function works only in certain cases,
  because what we really need is for `move-to-column'
  and `current-column' to be able to ignore invisible text."
!   (if (zerop col)
!       (beginning-of-line)
!     (move-to-column col))
  
    (when (and line-move-ignore-invisible
  	     (not (bolp)) (line-move-invisible-p (1- (point))))
- --- 3695,3705 ----
  This function works only in certain cases,
  because what we really need is for `move-to-column'
  and `current-column' to be able to ignore invisible text."
!   (let ((opoint (point)))
!     (if (zerop col)
! 	(beginning-of-line)
!       (move-to-column col))
!     (goto-char (constrain-to-field (point) opoint)))
  
    (when (and line-move-ignore-invisible
  	     (not (bolp)) (line-move-invisible-p (1- (point))))
------- End of forwarded message -------