[drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Richard Stallman]

Would someone please DTRT and ack?

------- Start of forwarded message -------
From: "Drew Adams" <drew.adams@oracle.com>
To: "Emacs-Pretest-Bug" <emacs-pretest-bug@gnu.org>
Date: Sun, 18 Jun 2006 13:21:54 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: Customize value menu doesn't recognize mouse-2
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4

emacs -Q

M-x customize-variable ad-default-compilation-action

Click mouse-2 on button Value Menu. The menu opens. Try to click
mouse-2 on a menu item - the action is unrecognized.

Mouse-2 can be used to click any links and buttons. However, if you
use it to open the Value Menu, then you cannot also use it to choose
an item in the menu. Mouse-2 should be usable for all actions,
including choosing a menu item. 

More precisely, if a mouse button opens a menu, then it should also
choose from it. If you don't want mouse-2 to choose from the menu,
then it should not be able to open the menu either. I would prefer
that mouse-2 be able to do both, but if it can do neither, then that
is acceptable.


In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600)
 of 2006-03-20 on W2ONE
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Id:/g/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t

Recent input:
s s SPC s ? h e SPC c a n SPC c u s t o m i z e SPC 
s o m e t h i n g . M-q C-c C-c y e s <return> <down-mouse-1> 
<mouse-1> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> M-x c u s t o m i z e - a p 
r o o <backspace> <tab> <tab> <tab> - o p <tab> <return> 
. <return> <help-echo> <help-echo> <down-mouse-1> <mouse-1> 
q C-x 0 C-v <down-mouse-2> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <re
port-emacs-bug>

Recent messages:
Creating customization items ...96%
Loading whitespace...done
Creating customization items ...98% [9 times]
Loading winner...done
Creating customization items ...99% [6 times]
Loading xt-mouse...done
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
To install your edits, invoke [State] and choose the Set operation



_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

[drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Richard Stallman]

[I sent this message a few weeks ago but did not get a response.]

Would someone please DTRT and ack?

------- Start of forwarded message -------
From: "Drew Adams" <drew.adams@oracle.com>
To: "Emacs-Pretest-Bug" <emacs-pretest-bug@gnu.org>
Date: Sun, 18 Jun 2006 13:21:54 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: Customize value menu doesn't recognize mouse-2
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4

emacs -Q

M-x customize-variable ad-default-compilation-action

Click mouse-2 on button Value Menu. The menu opens. Try to click
mouse-2 on a menu item - the action is unrecognized.

Mouse-2 can be used to click any links and buttons. However, if you
use it to open the Value Menu, then you cannot also use it to choose
an item in the menu. Mouse-2 should be usable for all actions,
including choosing a menu item. 

More precisely, if a mouse button opens a menu, then it should also
choose from it. If you don't want mouse-2 to choose from the menu,
then it should not be able to open the menu either. I would prefer
that mouse-2 be able to do both, but if it can do neither, then that
is acceptable.


In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600)
 of 2006-03-20 on W2ONE
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Id:/g/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t

Recent input:
s s SPC s ? h e SPC c a n SPC c u s t o m i z e SPC 
s o m e t h i n g . M-q C-c C-c y e s <return> <down-mouse-1> 
<mouse-1> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> M-x c u s t o m i z e - a p 
r o o <backspace> <tab> <tab> <tab> - o p <tab> <return> 
. <return> <help-echo> <help-echo> <down-mouse-1> <mouse-1> 
q C-x 0 C-v <down-mouse-2> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <re
port-emacs-bug>

Recent messages:
Creating customization items ...96%
Loading whitespace...done
Creating customization items ...98% [9 times]
Loading winner...done
Creating customization items ...99% [6 times]
Loading xt-mouse...done
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
To install your edits, invoke [State] and choose the Set operation



_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Chong Yidong]

> From: "Drew Adams" <drew.adams@oracle.com>
> Subject: Customize value menu doesn't recognize mouse-2
>
> emacs -Q
>
> M-x customize-variable ad-default-compilation-action
>
> Click mouse-2 on button Value Menu. The menu opens. Try to click
> mouse-2 on a menu item - the action is unrecognized.

On GNU/Linux, with either GTK or no X toolkit, the value menu goes
away when I release the mouse button; selection is done by holding the
mouse button and moving the cursor over the menu item.  It works with
both mouse-1 and mouse-2.

Maybe this is Windows-specific behavior.

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Eli Zaretskii]

> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Mon, 24 Jul 2006 15:19:20 -0400
> Cc: emacs-devel@gnu.org
> 
> > From: "Drew Adams" <drew.adams@oracle.com>
> > Subject: Customize value menu doesn't recognize mouse-2
> >
> > emacs -Q
> >
> > M-x customize-variable ad-default-compilation-action
> >
> > Click mouse-2 on button Value Menu. The menu opens. Try to click
> > mouse-2 on a menu item - the action is unrecognized.
> 
> On GNU/Linux, with either GTK or no X toolkit, the value menu goes
> away when I release the mouse button; selection is done by holding the
> mouse button and moving the cursor over the menu item.  It works with
> both mouse-1 and mouse-2.
> 
> Maybe this is Windows-specific behavior.

Yes, it is, and it's deliberate: as long as the menu is active, the
Windows version ignores the middle and the right mouse clicks; you
must use the left button only to select menu items.

This behavior was introduced by this change:

    2006-03-11  Eli Zaretskii  <eliz@gnu.org>

	    * w32fns.c (w32_wnd_proc): Ignore middle and extra button events
	    if a menu is already active (the menubar_active flag is on).

The reason was a much more annoying problem reported by Drew in this
thread:

  http://lists.gnu.org/archive/html/emacs-pretest-bug/2006-03/msg00024.html

Drew, I don't see any particular problem in asking Windows users to
click the left button, even if they are in a menu dropped by the right
button.  Do you?  (FWIW, I never select with the right button, even in
other GUI applications.)

RE: [drew.adams@oracle.com: Customize value menu doesn't recognizemouse-2]

[Drew Adams]

    > > emacs -Q
    > >
    > > M-x customize-variable ad-default-compilation-action
    > >
    > > Click mouse-2 on button Value Menu. The menu opens. Try to click
    > > mouse-2 on a menu item - the action is unrecognized.
    >
    > On GNU/Linux, with either GTK or no X toolkit, the value menu goes
    > away when I release the mouse button; selection is done by holding the
    > mouse button and moving the cursor over the menu item.  It works with
    > both mouse-1 and mouse-2.
    >
    > Maybe this is Windows-specific behavior.

    Yes, it is, and it's deliberate: as long as the menu is active, the
    Windows version ignores the middle and the right mouse clicks; you
    must use the left button only to select menu items.

    This behavior was introduced by this change:

        2006-03-11  Eli Zaretskii  <eliz@gnu.org>

    	    * w32fns.c (w32_wnd_proc): Ignore middle and extra button events
    	    if a menu is already active (the menubar_active flag is on).

    The reason was a much more annoying problem reported by Drew in this
    thread:


http://lists.gnu.org/archive/html/emacs-pretest-bug/2006-03/msg00024.html

    Drew, I don't see any particular problem in asking Windows users to
    click the left button, even if they are in a menu dropped by the right
    button.  Do you?  (FWIW, I never select with the right button, even in
    other GUI applications.)

1. It would be good if the behavior were the same on Windows as other
platforms, if that were possible.

2. It would be good if either a) you could neither open the menu nor choose
a menu item using mouse-2 or b) you could both open the menu and choose a
menu item using mouse-2. It is the combination of being able to open the
menu using mouse-2 but not being able to choose a menu item using mouse-2
that seems wrong.

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Mon, 24 Jul 2006 13:52:39 -0700
> 
>     This behavior was introduced by this change:
> 
>         2006-03-11  Eli Zaretskii  <eliz@gnu.org>
> 
>     	    * w32fns.c (w32_wnd_proc): Ignore middle and extra button events
>     	    if a menu is already active (the menubar_active flag is on).
> 
>     The reason was a much more annoying problem reported by Drew in this
>     thread:
> 
> 
> http://lists.gnu.org/archive/html/emacs-pretest-bug/2006-03/msg00024.html
> 
>     Drew, I don't see any particular problem in asking Windows users to
>     click the left button, even if they are in a menu dropped by the right
>     button.  Do you?  (FWIW, I never select with the right button, even in
>     other GUI applications.)
> 
> 1. It would be good if the behavior were the same on Windows as other
> platforms, if that were possible.

Sorry, I don't know how to do that without introducing worse
problems.  If someone else knows, please speak up.

> 2. It would be good if either a) you could neither open the menu nor choose
> a menu item using mouse-2 or b) you could both open the menu and choose a
> menu item using mouse-2.

Richard, should I go ahead and remove the mouse-2 binding for
widget-button-click?  I could do that either for MS-Windows or for all
platforms.

Btw, why do we bind both buttons to the same action here?

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Luc Teirlinck]

Eli Zaretskii wrote:

   Richard, should I go ahead and remove the mouse-2 binding for
   widget-button-click?  I could do that either for MS-Windows or for all
   platforms.

There is no need to remove it on other platforms, because there is no
bug on other platforms.

   Btw, why do we bind both buttons to the same action here?

Because mouse-2 has this kind of functionality in other Emacs buffers
and because people who have mouse-1-click-follows-link set to nil are
used to use mouse-2 for this kind of functionality.

Sincerely,

Luc.

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Richard Stallman]

    Richard, should I go ahead and remove the mouse-2 binding for
    widget-button-click?  I could do that either for MS-Windows or for all
    platforms.

What would be the purpose of this?  I did not follow the previous
discussion.

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org
> Date: Mon, 31 Jul 2006 00:38:54 -0400
> 
>     Richard, should I go ahead and remove the mouse-2 binding for
>     widget-button-click?  I could do that either for MS-Windows or for all
>     platforms.
> 
> What would be the purpose of this?  I did not follow the previous
> discussion.

Right now, you can pop the value menu by clicking mouse-2, but you
cannot select items from that menu with mouse-2, you need to use
mouse-1 for that.  (The latter part happens only on MS-Windows.)

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Richard Stallman]

    Right now, you can pop the value menu by clicking mouse-2, but you
    cannot select items from that menu with mouse-2, you need to use
    mouse-1 for that.

On GNU/Linux, probably with Lucid menus, I can select from the menu
using any of the three mouse buttons.

      (The latter part happens only on MS-Windows.)

It sounds like a bug in the way menus work in Emacs on Windows.

To make Mouse-2 stop working on buttons in Emacs would be an
incompatible change that would affect all buttons, not just those
that lead to menus.  It would be a step for the worse.
Please leave things alone.

Re: [drew.adams@oracle.com: Customize value menu doesn't recognize mouse-2]

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org
> Date: Mon, 31 Jul 2006 18:17:32 -0400
> 
> It sounds like a bug in the way menus work in Emacs on Windows.

Actually, the code in w32menu.c is written to explicitly ignore clicks
on any button but mouse-1 as long as a menu is open.  This was done to
solve a much more annoying bug on Windows, whereby, if you click
mouse-2 while browsing a menu, Emacs would yank killed text after the
menu pops down.

> Please leave things alone.

Done.