many lines of blabber at top of *Completions* buffer

many lines of blabber at top of *Completions* buffer

[Dan Jacobson]

Regarding the *Completions* buffer,
   Click <mouse-2> on a completion to select it.
   In this buffer, type RET to select the completion near point.

   Possible completions are:
   ../				   ./
   MAKEFLOPPIES			   a2dismod
   a2dissite			   a2enmod
   a2ensite			   ab...

Hurmf, wasted 1, 2, 3, 4 or 5 lines of precious completion buffer
space, depending on one's experience.  Might as well throw in a total
count of how many completions, like bash if lots. And mention the
variables to limit the above verboseness.

Re: many lines of blabber at top of *Completions* buffer

[Dan Jacobson]

rms> The first two lines are needed for beginners.
rms> You could edit the code so as to remove them.
Edit the code? Naw, want setq completions-user-maturity 'advanced.

Re: many lines of blabber at top of *Completions* buffer

[John Paul Wallington]

Dan Jacobson <jidanni@jidanni.org> writes:

> rms> The first two lines are needed for beginners.
> rms> You could edit the code so as to remove them.
> Edit the code? Naw, want setq completions-user-maturity 'advanced.

That's a good idea.  How about this change ?
Is it too late to install this before the pretest ?

2006-09-03  John Paul Wallington  <jpw@pobox.com>

	* simple.el (completion-show-help): New defcustom.
	(completion-setup-function): Heed it.

Index: simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.812
diff -u -r1.812 simple.el
--- simple.el	20 Aug 2006 12:16:58 -0000	1.812
+++ simple.el	3 Sep 2006 16:59:53 -0000
@@ -4982,6 +4982,12 @@
 
 ;; Variables and faces used in `completion-setup-function'.
 
+(defcustom completion-show-help t
+  "Non-nil means show help message in *Completions* buffer."
+  :type 'boolean
+  :version "22.1"
+  :group 'completion)
+
 (defface completions-first-difference
   '((t (:inherit bold)))
   "Face put on the first uncommon character in completions in *Completions* buffer."
@@ -5068,14 +5074,15 @@
 	      (if (get-char-property element-common-end 'mouse-face)
 		  (put-text-property element-common-end (1+ element-common-end)
 				     'font-lock-face 'completions-first-difference))))))
-      ;; Insert help string.
-      (goto-char (point-min))
-      (if (display-mouse-p)
-	  (insert (substitute-command-keys
-		   "Click \\[mouse-choose-completion] on a completion to select it.\n")))
-      (insert (substitute-command-keys
-	       "In this buffer, type \\[choose-completion] to \
-select the completion near point.\n\n")))))
+      ;; Maybe insert help string.
+      (when completion-show-help
+	(goto-char (point-min))
+	(if (display-mouse-p)
+	    (insert (substitute-command-keys
+		     "Click \\[mouse-choose-completion] on a completion to select it.\n")))
+	(insert (substitute-command-keys
+		 "In this buffer, type \\[choose-completion] to \
+select the completion near point.\n\n"))))))
 
 (add-hook 'completion-setup-hook 'completion-setup-function)

RE: many lines of blabber at top of *Completions* buffer

[Drew Adams]

    > rms> The first two lines are needed for beginners.
    > rms> You could edit the code so as to remove them.
    > Edit the code? Naw, want setq completions-user-maturity 'advanced.

    That's a good idea.  How about this change ?

I agree. I do the same thing in my own completion code, in fact, following a
user request.

Re: many lines of blabber at top of *Completions* buffer

[Richard Stallman]

It is ok to install this.  I think there is no need to document it
in the Emacs manual.

Re: many lines of blabber at top of *Completions* buffer

[John Paul Wallington]

Richard Stallman <rms@gnu.org> writes:

> It is ok to install this.  I think there is no need to document it
> in the Emacs manual.

Installed.