better not have a non-header line after Subject

better not have a non-header line after Subject

[Dan Jacobson]

Both plain emacs 22 or "No gnus", send differently mangled mail when given

Subject: bla, and
a second non header line starting in column 1

Garbage in, garbage out, but not caught.

Re: better not have a non-header line after Subject

[Kevin Rodgers]

Dan Jacobson wrote:
> Both plain emacs 22 or "No gnus", send differently mangled mail when given
> 
> Subject: bla, and
> a second non header line starting in column 1
> 
> Garbage in, garbage out, but not caught.

There is code in mail-send to detect that:

	;; Complain about any invalid line.
	(goto-char (point-min))
	(while (< (point) (mail-header-end))
	  (unless (looking-at "[ \t]\\|.*:\\|$")
	    (push-mark opoint)
	    (error "Invalid header line (maybe a continuation line lacks 
initial whitespace)"))
	  (forward-line 1))

But mail-header-end seems to be broken: it calls rfc822-goto-eoh instead
of searching for the mail-header-separator (either the text on a line by
itself or the category text property value).

-- 
Kevin

Re: better not have a non-header line after Subject

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

> Could someone please debug this?

I checked in the required fix to sendmail.el.  Thanks.

(I think message-mode needs to be fixed too; CC'ing ding@gnus.org).

> From: Kevin Rodgers <ihs_4664@yahoo.com>
> Subject: Re: better not have a non-header line after Subject
> To: bug-gnu-emacs@gnu.org
>
> Dan Jacobson wrote:
>> Both plain emacs 22 or "No gnus", send differently mangled mail when given
>>
>> Subject: bla, and
>> a second non header line starting in column 1
>>
>> Garbage in, garbage out, but not caught.
>
> There is code in mail-send to detect that:
>
> 	;; Complain about any invalid line.
> 	(goto-char (point-min))
> 	(while (< (point) (mail-header-end))
> 	  (unless (looking-at "[ \t]\\|.*:\\|$")
> 	    (push-mark opoint)
> 	    (error "Invalid header line (maybe a continuation line
> lacks initial whitespace)"))
> 	  (forward-line 1))
>
> But mail-header-end seems to be broken: it calls rfc822-goto-eoh instead
> of searching for the mail-header-separator (either the text on a line by
> itself or the category text property value).

Re: better not have a non-header line after Subject

[Katsumi Yamaoka]

>>>>> In <87odwuz2mb.fsf@stupidchicken.com> Chong Yidong wrote:

> Richard Stallman <rms@gnu.org> writes:

>> Could someone please debug this?

> I checked in the required fix to sendmail.el.  Thanks.

> (I think message-mode needs to be fixed too; CC'ing ding@gnus.org).

Thanks.  Gnus checks for continuation header lines only when
posting news articles.  I've made it do so for mail messages as
well in the Gnus CVS repository.  The changes will be merged to
the Emacs CVS after a while.

(As for blank header lines, Gnus removes them silently using
`message-cleanup-headers'.)

>> From: Kevin Rodgers <ihs_4664@yahoo.com>
>> Subject: Re: better not have a non-header line after Subject
>> To: bug-gnu-emacs@gnu.org
>>
>> Dan Jacobson wrote:
>>> Both plain emacs 22 or "No gnus", send differently mangled mail when given
>>>
>>> Subject: bla, and
>>> a second non header line starting in column 1
>>>
>>> Garbage in, garbage out, but not caught.
>>
>> There is code in mail-send to detect that:
>>
>> 	;; Complain about any invalid line.
>> 	(goto-char (point-min))
>> 	(while (< (point) (mail-header-end))
>> 	  (unless (looking-at "[ \t]\\|.*:\\|$")
>> 	    (push-mark opoint)
>> 	    (error "Invalid header line (maybe a continuation line
>> lacks initial whitespace)"))
>> 	  (forward-line 1))
>>
>> But mail-header-end seems to be broken: it calls rfc822-goto-eoh instead
>> of searching for the mail-header-separator (either the text on a line by
>> itself or the category text property value).

Re: better not have a non-header line after Subject

[Richard Stallman]

Thanks.

Re: better not have a non-header line after Subject

[Katsumi Yamaoka]

>>>>> In <b4m4pylb9ul.fsf@jpl.org> Katsumi Yamaoka wrote:

>>>>>> In <87odwuz2mb.fsf@stupidchicken.com> Chong Yidong wrote:

>> (I think message-mode needs to be fixed too; CC'ing ding@gnus.org).

> Thanks.  Gnus checks for continuation header lines only when
> posting news articles.  I've made it do so for mail messages as
> well in the Gnus CVS repository.  The changes will be merged to
> the Emacs CVS after a while.

I've made a minor change in docstring of `message-syntax-checks'
and updated the Mesage Info manual (both trunk and v5-10 branch).

bug#7144: better not have a non-header line after Subject

[Lars Magne Ingebrigtsen]

Dan Jacobson <jidanni@jidanni.org> writes:

> Both plain emacs 22 or "No gnus", send differently mangled mail when given
>
> Subject: bla, and
> a second non header line starting in column 1

That's how continuation lines work...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

bug#7144: better not have a non-header line after Subject

[Lars Magne Ingebrigtsen]

Bug created by mistake.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen