Crashes with latest font code

Crashes with latest font code

[Romain Francoise]

Richard's latest changes to the font handling code (which are not
documented in src/ChangeLog) cause very reliable crashes with my setup.
Starting Gnus or loading my w3m session is enough to cause a segfault.

The backtrace is as follows:

#0  0xffffe410 in __kernel_vsyscall ()
#1  0xa763ab16 in kill () from /lib/tls/i686/cmov/libc.so.6
#2  0x081244fc in fatal_error_signal (sig=11) at emacs.c:430
#3  <signal handler called>
#4  0x080e6b7c in best_matching_font (f=0x86a9b60, attrs=0x8be8ba0, 
    fonts=0xa630f58, nfonts=1, width_ratio=1, needs_overstrike=0xafefdd18)
    at xfaces.c:6684
#5  0x080e721c in choose_face_font (f=0x86a9b60, attrs=0x8be8ba0, fontset=2, 
    c=294912, needs_overstrike=0xafefdd18) at xfaces.c:6910
#6  0x080de15c in load_face_font (f=0x86a9b60, face=0x8be8b58, c=294912)
    at xfaces.c:1257
#7  0x080e7ab7 in realize_face (cache=0x86acd68, attrs=0x98412f8, c=294912, 
    base_face=0x98412b0, former_face_id=-1) at xfaces.c:7166
#8  0x080e4fd6 in lookup_face (f=0x86a9b60, attr=0x98412f8, c=294912, 
    base_face=0x98412b0) at xfaces.c:5687
[...]

I can provide more info if needed.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Crashes with latest font code

[Richard Stallman]

    Richard's latest changes to the font handling code (which are not
    documented in src/ChangeLog) cause very reliable crashes with my setup.

I am surprised the new code behaves differently from the old.  Can you
figure out why?  It must be some tiny bug.

Re: Crashes with latest font code

[YAMAMOTO Mitsuharu]

Richard Stallman <rms <at> gnu.org> writes:

> 
>     Richard's latest changes to the font handling code (which are not
>     documented in src/ChangeLog) cause very reliable crashes with my setup.
> 
> I am surprised the new code behaves differently from the old.  Can you
> figure out why?  It must be some tiny bug.
> 

I'm not sure if this is a right fix, but I could avoid similar
crashes on my side with the following change.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/xfaces.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xfaces.c,v
retrieving revision 1.347
diff -c -r1.347 xfaces.c
*** src/xfaces.c	17 May 2006 22:51:07 -0000	1.347
--- src/xfaces.c	20 May 2006 03:38:09 -0000
***************
*** 6636,6642 ****
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 1; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
  	&& better_font_p (specified, fonts + i, best, 1, avgwidth))
        {
--- 6636,6642 ----
    best = NULL;
  
    /* Find the best match among the non-scalable fonts.  */
!   for (i = 0; i < nfonts; ++i)
      if (!font_scalable_p (fonts + i)
  	&& better_font_p (specified, fonts + i, best, 1, avgwidth))
        {

Re: Crashes with latest font code

[Romain Francoise]

Richard Stallman <rms@gnu.org> writes:

> I am surprised the new code behaves differently from the old.  Can you
> figure out why?  It must be some tiny bug.

Kim installed a fix for this bug, it works fine now.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter