From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unicode Lisp reader escapes Date: Mon, 08 May 2006 10:31:20 +0900 Message-ID: References: <17491.34779.959316.484740@parhasard.net> <17495.932.70900.796282@parhasard.net> <17495.57895.90438.848865@parhasard.net> <17498.28361.392872.954484@parhasard.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1147051909 11277 80.91.229.2 (8 May 2006 01:31:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 8 May 2006 01:31:49 +0000 (UTC) Cc: schwab@suse.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 08 03:31:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fcub7-0005eS-J7 for ged-emacs-devel@m.gmane.org; Mon, 08 May 2006 03:31:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fcub6-0001sY-Ge for ged-emacs-devel@m.gmane.org; Sun, 07 May 2006 21:31:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fcuau-0001rU-Cu for emacs-devel@gnu.org; Sun, 07 May 2006 21:31:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fcuas-0001qw-05 for emacs-devel@gnu.org; Sun, 07 May 2006 21:31:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fcuar-0001qt-Op for emacs-devel@gnu.org; Sun, 07 May 2006 21:31:25 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fcuba-0002dL-Dq for emacs-devel@gnu.org; Sun, 07 May 2006 21:32:10 -0400 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k481VL3Y007093; Mon, 8 May 2006 10:31:21 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.13.4/8.13.4/Debian-3sarge1) with ESMTP id k481VKsi010101; Mon, 8 May 2006 10:31:20 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1Fcuam-0007ry-00; Mon, 08 May 2006 10:31:20 +0900 Original-To: Aidan Kehoe In-reply-to: <17498.28361.392872.954484@parhasard.net> (message from Aidan Kehoe on Thu, 4 May 2006 23:14:49 +0200) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54050 Archived-At: In article <17498.28361.392872.954484@parhasard.net>, Aidan Kehoe writes: >> Kevin Rodgers writes: >> >> > readcharfun is declared as a Lisp_Object in read1, so it should be >> > possible to check it's type and only GCPRO when necessary. >> >> I don't see any need to GCPRO readcharfun. When called from Lisp the >> arguments are already protected by being part of the call frame, and all >> uses from C protect the object by other means (eg, by being put on >> eval-buffer-list). > That was my understanding of the code too. For instance, Fread is called from Fcall_interactively as below: Lisp_Object tem; [...] tem = Fread_from_minibuffer (build_string (callint_message), Qnil, Qnil, Qnil, Qnil, Qnil, Qnil, Qnil); if (! STRINGP (tem) || SCHARS (tem) == 0) args[i] = Qnil; else args[i] = Fread (tem); In the calling sequence of Fread->read_internal_start->read0->read1, I see no place where the original `tem' is GCPROed. Do I overlook something? --- Kenichi Handa handa@m17n.org