From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Qs on free variable occurrences
Date: Sun, 07 May 2006 01:00:52 -0400 [thread overview]
Message-ID: <E1FcbO0-0002Tx-Lb@fencepost.gnu.org> (raw)
In-Reply-To: <DNEMKBNJBGPAOPIJOOICEELHDFAA.drew.adams@oracle.com>
4. Byte-compiling the file gives no warning of the variable
being used as a free variable (in #3 and #4).
This is not a criticism, but a couple of questions.
a. Why #4? Is it because the byte-compiler cannot detect these
as free occurrences of the variable or is it intentional
(TRT)? If the latter, what's the rationale?
It is because the variable has a definition elsewhere.
(In the C code.)
I will add a comment to say so.
b. Is this coding style considered good or bad? In particular,
should `minibuffer-history-position' be declared a global
variable by giving it a defvar?
If it weren't used in the C code, that's what we'd do.
next prev parent reply other threads:[~2006-05-07 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 21:25 Qs on free variable occurrences Drew Adams
2006-05-01 21:29 ` Drew Adams
2006-05-06 14:57 ` Drew Adams
2006-05-07 5:00 ` Richard Stallman [this message]
2006-05-07 14:54 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1FcbO0-0002Tx-Lb@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.