From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [mange@freemail.hu: grep-tree doesn't shell-quote-argument] Date: Tue, 18 Apr 2006 08:57:34 -0400 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1145365077 361 80.91.229.2 (18 Apr 2006 12:57:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Apr 2006 12:57:57 +0000 (UTC) Cc: Magnus Henoch Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 18 14:57:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FVpmA-0005aC-SJ for ged-emacs-devel@m.gmane.org; Tue, 18 Apr 2006 14:57:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FVpmA-0006VE-EM for ged-emacs-devel@m.gmane.org; Tue, 18 Apr 2006 08:57:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FVplz-0006V1-Bj for emacs-devel@gnu.org; Tue, 18 Apr 2006 08:57:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FVply-0006Up-02 for emacs-devel@gnu.org; Tue, 18 Apr 2006 08:57:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FVplx-0006Um-Q8 for emacs-devel@gnu.org; Tue, 18 Apr 2006 08:57:37 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FVpmq-0007tD-Aj for emacs-devel@gnu.org; Tue, 18 Apr 2006 08:58:32 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FVplu-0005th-51; Tue, 18 Apr 2006 08:57:34 -0400 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53003 Archived-At: Since M-x grep does not do this, I am not sure it is desirable to make M-x grep-tree incompatible with it. But I don't use grep-tree. What do others think? ------- Start of forwarded message ------- Mail-Followup-To: emacs-pretest-bug@gnu.org To: emacs-pretest-bug@gnu.org From: Magnus Henoch Date: Mon, 17 Apr 2006 23:17:14 +0200 Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Mail-Copies-To: never Jabber-Id: legoscia@jabber.cd.chalmers.se Subject: grep-tree doesn't shell-quote-argument X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed version=3.0.4 - --=-=-= grep-tree doesn't quote its regexp argument to protect it from the shell. This makes it harder to use * and ? in regexps. I propose this patch: 2006-04-17 Magnus Henoch * progmodes/grep.el (grep-tree): Call shell-quote-argument on regexp. - --=-=-= Content-Type: text/x-patch Content-Disposition: inline *** orig/lisp/progmodes/grep.el - --- mod/lisp/progmodes/grep.el *************** *** 631,637 **** (setq files (cdr mf))))) (let ((command-args (grep-expand-command-macros grep-tree-command ! (setq grep-tree-last-regexp regexp) (and files (concat "-name '" files "'")) (if subdirs (if (stringp subdirs) - --- 632,638 ---- (setq files (cdr mf))))) (let ((command-args (grep-expand-command-macros grep-tree-command ! (shell-quote-argument (setq grep-tree-last-regexp regexp)) (and files (concat "-name '" files "'")) (if subdirs (if (stringp subdirs) - --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug - --=-=-=-- ------- End of forwarded message -------