Problem report #31

Problem report #31

[Dan Nicolaescu]

CID: 31
Checker: NEGATIVE_RETURNS (help)
File: emacs/src/process.c
Function: Fprocess_send_eof
Description: Tracked variable "new_outfd" used as index to array "proc_encode_coding_system"

Event negative_return_fn: Called negative-returning function "emacs_open" [model]
Event var_assign: NEGATIVE return value of "emacs_open" assigned to signed variable "new_outfd"
Also see events: [var_assign][negative_returns]

6233 	      new_outfd = emacs_open (NULL_DEVICE, O_WRONLY, 0);
6234 	      old_outfd = XINT (XPROCESS (proc)->outfd);
6235 	

Event negative_returns: Tracked variable "new_outfd" used as index to array "proc_encode_coding_system"
Also see events: [negative_return_fn][var_assign]

6236 	      if (!proc_encode_coding_system[new_outfd])
6237 		proc_encode_coding_system[new_outfd]
6238 		  = (struct coding_system *) xmalloc (sizeof (struct coding_system));
6239 	      bcopy (proc_encode_coding_system[old_outfd],
6240 		     proc_encode_coding_system[new_outfd],
6241 		     sizeof (struct coding_system));
6242 	      bzero (proc_encode_coding_system[old_outfd],
6243 		     sizeof (struct coding_system));

Re: Problem report #31

[Stuart D. Herring]

> Event var_assign: NEGATIVE return value of "emacs_open" assigned to signed
> variable "new_outfd"
> Also see events: [var_assign][negative_returns]
>
> 6233 	      new_outfd = emacs_open (NULL_DEVICE, O_WRONLY, 0);
> 6234 	      old_outfd = XINT (XPROCESS (proc)->outfd);
> 6235
>
> Event negative_returns: Tracked variable "new_outfd" used as index to
> array "proc_encode_coding_system"
> Also see events: [negative_return_fn][var_assign]
>
> 6236 	      if (!proc_encode_coding_system[new_outfd])

Seems kinda unlikely that opening the null device would fail, but I
suppose it's possible.  Should probably check this.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: Problem report #31

[Richard Stallman]

    Seems kinda unlikely that opening the null device would fail, but I
    suppose it's possible.  Should probably check this.

I put that in.  Thanks.