From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: locate-with-filter Date: Thu, 30 Mar 2006 22:10:41 -0500 Message-ID: References: <200603160048.k2G0msu23696@raven.dms.auburn.edu> <200603170221.k2H2L1H14401@raven.dms.auburn.edu> <17435.52238.927514.585806@kahikatea.snap.net.nz> <200603181716.k2IHGpN17847@raven.dms.auburn.edu> <17436.56026.490667.58771@kahikatea.snap.net.nz> <200603190455.k2J4tEK25830@raven.dms.auburn.edu> <200603200512.k2K5CFN12390@raven.dms.auburn.edu> <200603290409.k2T49W729435@raven.dms.auburn.edu> <200603300029.k2U0TxZ11021@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1143774684 14760 80.91.229.2 (31 Mar 2006 03:11:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2006 03:11:24 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 05:11:23 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FPA2c-0008Kz-F8 for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2006 05:11:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FPA2b-00052A-P3 for ged-emacs-devel@m.gmane.org; Thu, 30 Mar 2006 22:11:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FPA27-0004mJ-Md for emacs-devel@gnu.org; Thu, 30 Mar 2006 22:10:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FPA27-0004ls-0b for emacs-devel@gnu.org; Thu, 30 Mar 2006 22:10:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FPA26-0004lk-M7 for emacs-devel@gnu.org; Thu, 30 Mar 2006 22:10:42 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FPA4P-0006Xw-NL for emacs-devel@gnu.org; Thu, 30 Mar 2006 22:13:05 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1FPA25-0001tc-DT; Thu, 30 Mar 2006 22:10:41 -0500 Original-To: Luc Teirlinck In-reply-to: <200603300029.k2U0TxZ11021@raven.dms.auburn.edu> (message from Luc Teirlinck on Wed, 29 Mar 2006 18:29:59 -0600 (CST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52243 Archived-At: Because after your changes, `help-follow' is a function that just unconditionally gives an error message, even when invoked on a button. Right--because it should not get called on a button. The button itself takes care of its own commands. `help-follow' exists only in case you try to activate a button where there is no button. If you mean the bug that binding `help-follow' to anything else but RET does not work, then my third patch fixes that bug. You would have to change the bindings in the button's (text-property) keymap if you want different commands to operate on the button. Is that feasible? Maybe it is not easy for users to find out which keymap to change in order to change the behavior of the button. Is it? I do not know how to fix the problem with "\\[help-follow]" and (presumably) `minor-mode-overriding-map-alist', even after applying my third patch. I am not sure which problem that refers to. If you mean how to make the help mode's doc string refer to the button's commands, one way would be to tell it to do lookups in the button's keymap. The behavior after my patches is _exactly_ the same as the behavior after your changes, as long as help-follow is only bound to RET. Ok, I see the idea now. So there are two approaches: 1. Say that users who want to change the behavior of the buttons should change the keymap that they use. 2. Install your change in help-follow, and then we can get rid of the buttons' text property keymap.