From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Richard M. Stallman" Newsgroups: gmane.emacs.devel Subject: Re: Risky local variable mechanism Date: Sat, 11 Feb 2006 11:44:10 -0500 Message-ID: References: <87mzhbly89.fsf-monnier+emacs@gnu.org> <87k6c3ojyp.fsf@stupidchicken.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1139694913 18348 80.91.229.2 (11 Feb 2006 21:55:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 11 Feb 2006 21:55:13 +0000 (UTC) Cc: storm@cua.dk, monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 11 22:55:06 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F82ht-0003en-Ve for ged-emacs-devel@m.gmane.org; Sat, 11 Feb 2006 22:55:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F82bd-00051o-8x for ged-emacs-devel@m.gmane.org; Sat, 11 Feb 2006 16:48:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F81n2-0006UL-Ae for emacs-devel@gnu.org; Sat, 11 Feb 2006 15:56:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F81Ml-0005Z5-Vc for emacs-devel@gnu.org; Sat, 11 Feb 2006 15:29:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F80IQ-0007qr-6O for emacs-devel@gnu.org; Sat, 11 Feb 2006 14:20:38 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F7xv3-0002HC-UW for emacs-devel@gnu.org; Sat, 11 Feb 2006 11:48:21 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1F7xr0-0003af-JA; Sat, 11 Feb 2006 11:44:10 -0500 Original-To: Chong Yidong In-reply-to: <87k6c3ojyp.fsf@stupidchicken.com> (message from Chong Yidong on Fri, 10 Feb 2006 00:34:38 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50370 Archived-At: What you've implemented is the sort of thing I had in mind. It seems basically right. Here are a few comments on minor details. ! (or (= char ?!) ! (= char ? ) It would be better to use \s. + (defcustom safe-local-variables nil I would call it safe-local-variable-values. + "Alist of safe local variables. It is not really an alist. In an alist, the car of an element is a key, so only the first element with a given car really counts. This is a list of variable-value pairs. + :type 'alist) It is ok to use `alist' as the custom type if it gives the right results in the custom buffer, as it seems to do. But it might be cleaner to do this another way just to avoid misleading someone. By the way, this variable should be marked risky.