Re: Visual cleanup for customize buffers

["Richard M. Stallman" <rms@gnu.org>]

    --- 2551,2558 ----
	    ;; this anyway. The doc string widget should be added like the others.
	    ;; --dv
	    (widget-put widget :buttons buttons)
    !       (unless (eq (preceding-char) ?\n)
    ! 	(insert "\n"))
	    ;; Insert documentation.
	    (widget-default-format-handler widget ?h)


If this deletes the blank line after the STATE line,
I am against it, for reasons I stated here before.

      (define-widget 'custom-face-edit 'checklist
	"Edit face attributes."
    !   :format "%t:\n             %v"
	:tag "Attributes"
	:extra-offset 13
	:button-args '(:help-echo "Control whether this attribute has any effect.")

What is the user-visible effect of that?

		   ((eq escape ?\])
    ! 		(save-excursion
    ! 		  (setq button-end (point))
    ! 		  (when value-choice-button
    ! 		    (goto-char button-begin)
    ! 		    (when (re-search-forward "[:\n]" button-end t)
    ! 		      (setq button-end (1- (point))))
    ! 		    (goto-char button-end)
    ! 		    (when (eq (preceding-char) ?\n)
    ! 		      (backward-char 1))
    ! 		    (insert " ")
    ! 		    (if (display-graphic-p)
    ! 			(insert-image
    ! 			 (or widget-choice-menu-image
    ! 			     (setq widget-choice-menu-image
    ! 				   (create-image "\377\176\176\074\074\030\030\377"
    ! 						 'xbm t :width 8 :height 8
    ! 						 :foreground
    ! 						 (if (facep 'custom-button)
    ! 						     (face-foreground 'custom-button)
    ! 						   "black")
    ! 						 :background
    ! 						 (if (facep 'custom-button)
    ! 						     (face-background 'custom-button)
    ! 						   "lightgrey")
    ! 						 :ascent 'center))) ">")
    ! 		      (insert (propertize "?>" )))
    ! 		    (setq button-end (point)))
    ! 		  (insert (widget-get-indirect widget :button-suffix))))
		   ((eq escape ?\{)
		    (setq sample-begin (point)))
		   ((eq escape ?\})

What does that do?  (It needs comments!)

    --- 3596,3602 ----
      (define-widget 'choice 'menu-choice
	"A union of several sexp types."
	:tag "Choice"
    !   :format "%{%t%}: %[%V%]"
	:button-prefix 'widget-push-button-prefix
	:button-suffix 'widget-push-button-suffix
	:prompt-value 'widget-choice-prompt-value)

What user-visible change does that make?