From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Display slowness that is painful Date: Fri, 03 Feb 2006 10:50:24 +0900 Message-ID: References: <87slr5c78p.fsf@stupidchicken.com> <877j8fx43q.fsf@stupidchicken.com> <87mzhaqp7p.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1138931475 10786 80.91.229.2 (3 Feb 2006 01:51:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2006 01:51:15 +0000 (UTC) Cc: cyd@stupidchicken.com, rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 03 02:51:13 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F4q6L-0000nm-QL for ged-emacs-devel@m.gmane.org; Fri, 03 Feb 2006 02:51:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F4q9U-00006S-HV for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2006 20:54:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F4q9K-00006D-Nr for emacs-devel@gnu.org; Thu, 02 Feb 2006 20:54:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F4q9H-000060-QE for emacs-devel@gnu.org; Thu, 02 Feb 2006 20:54:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F4q9H-00005x-Nm for emacs-devel@gnu.org; Thu, 02 Feb 2006 20:54:07 -0500 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1F4q89-0008Id-C5; Thu, 02 Feb 2006 20:52:57 -0500 Original-Received: from nfs.m17n.org (nfs.m17n.org [192.47.44.7]) by tsukuba.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id k131oQf7012226; Fri, 3 Feb 2006 10:50:26 +0900 Original-Received: from etlken (etlken.m17n.org [192.47.44.125]) by nfs.m17n.org (8.13.4/8.13.4/Debian-3) with ESMTP id k131oP6L002534; Fri, 3 Feb 2006 10:50:26 +0900 Original-Received: from handa by etlken with local (Exim 3.36 #1 (Debian)) id 1F4q5g-0003pt-00; Fri, 03 Feb 2006 10:50:24 +0900 Original-To: storm@cua.dk (Kim F. Storm) In-reply-to: (storm@cua.dk) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49947 Archived-At: In article , storm@cua.dk (Kim F. Storm) writes: > It seems to be because it needs to merge_face with the escape glyph > for each character -- and that takes extra time. Below is a patch to > speed up the processing for this specific part of the problem. With > the patch, redisplay time for file2 seems to be approx 4 x redisplay time > for file1. I think another reason of the slowness is this part (in set_iterator_to_next): case GET_FROM_DISPLAY_VECTOR: [...] /* Restore face of the iterator to what they were before the display vector entry (these entries may contain faces). */ it->face_id = it->saved_face_id; if (it->dpvec + it->current.dpvec_index == it->dpend) { [...] /* Recheck faces after display vector */ it->stop_charpos = IT_CHARPOS (*it); } break; Because of this, it seems that handle_stop is called for every character after an eight bit character. Isn't it possible to tune it? First of all, why should we recheck faces after display vector? --- Kenichi Handa handa@m17n.org